Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

omit vcs info from build #1514

Merged
merged 1 commit into from
Feb 20, 2025
Merged

omit vcs info from build #1514

merged 1 commit into from
Feb 20, 2025

Conversation

spencerschrock
Copy link
Member

@spencerschrock spencerschrock commented Feb 18, 2025

The detected info is interfering with the manually specified Scorecard version in the LDFLAGS. While buildvcs has been present since Go 1.18, Go 1.24 changed the behavior again. Our docker image uses Go 1.24 as of 3676bbc.

https://go.dev/doc/go1.24#go-command

The go build command now sets the main module’s version in the compiled binary based on the version control system tag and/or commit. A +dirty suffix will be appended if there are uncommitted changes. Use the -buildvcs=false flag to omit version control information from the binary.

This trickled down to the produced output:
Before this PR:

"scorecard": { 
  "version":"v0.0.0-20250218152336-6a62a1cbf280",
  "commit":"cd152cb6742c5b8f2f3d2b5193b41d9c50905198"
}

After:

"scorecard": {
  "version":"v5.1.1",
  "commit":"cd152cb6742c5b8f2f3d2b5193b41d9c50905198"
}

The detected info is interfering with the manually specified Scorecard
version in the LDFLAGS. While `buildvcs` has been present since Go 1.18,
Go 1.24 changed the behavior again. Our docker image uses Go 1.24 as of
3676bbc.

https://go.dev/doc/go1.24#go-command

Signed-off-by: Spencer Schrock <[email protected]>
@spencerschrock spencerschrock requested review from a team, justaugustus and raghavkaul and removed request for a team February 18, 2025 16:29
@spencerschrock spencerschrock enabled auto-merge (squash) February 18, 2025 16:30
@spencerschrock spencerschrock merged commit 69ae593 into ossf:main Feb 20, 2025
9 checks passed
@spencerschrock spencerschrock deleted the buildvcs branch February 20, 2025 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants