Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a converter for PlayerBlack/PlayerWhite #181

Open
artasparks opened this issue Dec 16, 2020 · 0 comments
Open

Add a converter for PlayerBlack/PlayerWhite #181

artasparks opened this issue Dec 16, 2020 · 0 comments
Assignees
Labels
Difficulty:Kyu Single Digit Kyu Level: Describe well-scoped problems / bugs that require some experience.

Comments

@artasparks
Copy link
Member

artasparks commented Dec 16, 2020

We should add a converter for the PlayerBlack & PlayerWhite properties + fields in the GameInfo struct in node.go: https://github.com/otrego/clamshell/blob/master/core/movetree/node.go

Extra care will need to be paid to ensure that comments are escaped correctly. In particular, ] characters should become \]. Currently the parser does the unescaping for comments.

Should have unit tests that test positive & error cases

@artasparks artasparks added the Difficulty:Kyu Single Digit Kyu Level: Describe well-scoped problems / bugs that require some experience. label Dec 16, 2020
@jonathanmli jonathanmli self-assigned this Dec 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Difficulty:Kyu Single Digit Kyu Level: Describe well-scoped problems / bugs that require some experience.
Projects
None yet
Development

No branches or pull requests

2 participants