-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Load video by drag-and-drop #59
Comments
It would be better to skip the dialogue and just load it as video if the file has any of the supported video extensions. |
Sure, I just assumed that extension might not be enough to determine unambiguously whether the file contained a video or subtitles. |
Good idea. The detection can be done by Python's mimetypes module, checking for https://docs.python.org/3/library/mimetypes.html#mimetypes.guess_type https://github.com/otsaloma/gaupol/blob/master/aeidon/agents/preview.py#L25 |
When dragging and dropping a video file on Gaupol, it tells the user that the file seems too big to be a text-based subtitle file. I suggest asking the user to choose between loading the file as a video or as subtitles. (Edit: the issue also happens when passing a video file as an argument when launching Gaupol from the command line. The -v option does not solve the issue as it does not load the video in Gaupol's player.)
The text was updated successfully, but these errors were encountered: