Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buggy hypertext handling #237

Closed
mi5o opened this issue Nov 1, 2022 · 1 comment · Fixed by #249
Closed

Buggy hypertext handling #237

mi5o opened this issue Nov 1, 2022 · 1 comment · Fixed by #249

Comments

@mi5o
Copy link

mi5o commented Nov 1, 2022

The application handles hypertext well, but there are glitches here and there.

Example 1

Original message: <p>text</p>\n<ul>\n<li>text apparent-url text <strong>text</strong> text</li>\n<li>text apparent-url text<strong>text</strong> text</li>\n<li>text apparent-url text &quot;text&quot; text <strong>text</strong> text</li>\n</ul>\n

Displayed as (notice correct strong tag handling, correctly detected URLs in plain text, and ignored ul and li tags):

text

<ul>
<li>text apparent-url text text text</li>
<li>text apparent-url text text text</li>
<li>text "text" text apparent-url text text text</li>
</ul>

Example 2

original message: text-&gt;text

displayed as (ignored > reference):

text-&gt;text

Example 3

original message: \n<h3>text</h3>\n\n<p>text</p>\n\n<p>text<a href="https://example.com">text</a>text<a href="https://example.com">text</a>text</p>\n\n<p>text<strong>text</strong>text</p>\n\n<p><strong>text</strong>text&#39;text</p>\n\n<p><strong>text</strong>\ntext<a href="https://example.com">text</a>text\ntext&#39;text</p>\n\n<p>text<a href="https://example.com">apparent-url</a>text<a href="https://example.com">apparent-url</a>text</p>\n

displayed as (notice three different styles of detecting/handling links, correct handling of ' reference, and no handling of strong and p tags):

text

<p>text</p>
<p>text <a href="https://example.com">text</a> text <a href="https://example.com">text</a>text</p>
<p>text<strong>text</strong>text</p>
<p><strong>text</strong>text'text</p>
<p><strong>text</strong> text <a href="https://example.com">text</a>text text'text</p>
<p>text <a href="https://example.com">apparent-url</a> text apparent-url text</p>


(seen in foss-signed-31.10.2022-V1.apk running in LineageOS)

@ouchadam
Copy link
Owner

ouchadam commented Nov 3, 2022

thanks for the examples! 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants