Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified messages displayed out of their original order #240

Closed
mi5o opened this issue Nov 1, 2022 · 4 comments
Closed

Modified messages displayed out of their original order #240

mi5o opened this issue Nov 1, 2022 · 4 comments

Comments

@mi5o
Copy link

mi5o commented Nov 1, 2022

Modified messages appear (almost) correctly modified, but out of their original order.

Steps to reproduce:

  1. send message 1
  2. send message 2
  3. send message 3
  4. modify message 2 to message 2+

Expected result:

Message 1 [HH:MM]
Message 2+ [edited HH:MM]
Message 3 [HH:MM]

Actual result:

Message 1 [HH:MM]
Message 3 [HH:MM]
* Message2+ [edited HH:MM]

Also note the redundant asterisk at the beginning of the modified message – it already clearly indicates it has been modified.

(seen in foss-signed-31.10.2022-V1.apk running in LineageOS)

@ouchadam
Copy link
Owner

ouchadam commented Nov 3, 2022

can confirm 👍 seems to happen when editing your own messages from another client, when others edit their messages it's working as expected (at least for me!)

@ouchadam
Copy link
Owner

ouchadam commented Nov 3, 2022

fixed by #246 (the asterisk has also been removed in recent commits)

@ouchadam ouchadam closed this as completed Nov 3, 2022
@mi5o
Copy link
Author

mi5o commented Nov 3, 2022

seems to happen when editing your own messages from another client,

I have not seen the fix yet, so maybe it works as expected. But I am going to challenge your description of the cause.

I did everything at one device, in one app (Matrix for Android), in one chat room, as one user, immediately one step after another, editing my own messages in one client.

@ouchadam
Copy link
Owner

ouchadam commented Nov 4, 2022

ah when checking messages from others I may have originally only been trying to edit the latest message, the fix from above will cover both cases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants