Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

开放自定义prefix和缓存键值方法 #474

Merged
merged 4 commits into from
Aug 1, 2016
Merged

开放自定义prefix和缓存键值方法 #474

merged 4 commits into from
Aug 1, 2016

Conversation

xleliu
Copy link
Contributor

@xleliu xleliu commented Jul 30, 2016

No description provided.

/**
* Set access token cache key.
*
* @param string $prefix
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@XiaoLer ???这条信息没看么?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@overtrue param string $prefix 这个吗? 已fix
sorry~

*
* @return $this
*/
public function setCacheKey($cacheKey)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

参数名叫 $cacheKey 然而注释却叫:$prefix 😢

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@overtrue 提交fix sorry sorry~

@overtrue overtrue merged commit dddfc69 into w7corp:master Aug 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants