Not logging Affected Relations?

[bbredewold]

Is it correct that any updated relations are not being logged in the database?
I'm using eloquent's sync() function a lot, for updating many-to-many relations...

Any ideas how to do that?

[camih]

The auditing currently uses events, but in case of pivots, there are no events being triggered. There are many issues reported regarding this. See for example here: laravel/framework#8452 .
I also need this and currently did not find a very nice way to handle it.

[robclancy]

Can you not just override those methods like sync, attach and detach? Or even better would be a chain on the relationship in some way, will explain more if I come up with a way of doing this. Trying out this package and I think we will need it to work for this and we can work around it easy enough, if a workaround is good enough we will make a PR.

[anteriovieira]

Sorry for the delay.

Hello @robclancy , let's think of something. I'll keep this open to give continuity to this improvement.

[fly-studio]

yes, 'sync attach detach' donot log,
4.x support it?

[quetzyg]

@fly-studio, as soon as version 4.0 is out the door, we'll try to work on many-to-many audit support for 4.1.

[projct1]

When will release 4 version? 😃

[quetzyg]

@rorc, when it's done (i.e. when I finish adding tests)

Meanwhile, you already can use "owen-it/laravel-auditing": "4.0.x-dev" in your composer.json.
The v4 documentation is available here.

[projct1]

@quetzyg Ok, thanks 😄

[jschlies]

I strongly vote for this feature. I'm currently working on a custom auditor that would record (to a seperate table) the foreign key relationships relations to a separate table, then I extend $Model->getAuditArr() to pull it all together the way we want. Lots of DB hits and in general, not a perfect solution. Will switch off this when this feature is implemented.

[projct1]

How progress here? 😀

[od3n]

+1 still waiting for the best solution

[ghost]

considering using this package but I would need pivot auditing

[neylsongularte]

tenho o mesmo problema

[neylsongularte]

Experimental package for events in many to many relations:

https://github.com/neylsongularte/eloquent-extra-events

My temporary solution:

// Add on your AppServiceProvider
$saveManyToManyAudit = function ($event, $eventData) {
            $audit = new Audit;
            $audit->user_id = Auth::check() ? Auth::user()->getAuthIdentifier() : null;
            $audit->event = $event;
            $audit->auditable_id = $eventData['parent_id'];
            $audit->auditable_type = $eventData['parent_model'];
            $audit->old_values = [];
            unset($eventData['parent_id']);
            unset($eventData['parent_model']);
            $audit->new_values = $eventData;
            $audit->url = App::runningInConsole() ? 'console' : Request::fullUrl();
            $audit->ip_address = Request::ip();
            $audit->user_agent = Request::header('User-Agent');
            $audit->created_at = Carbon::now();
            $audit->save();
        };

        $this->app['events']->listen('eloquent.synced*', function ($eventData) use ($saveManyToManyAudit) {
            if($eventData['changes']['attached'] || $eventData['changes']['detached'] || $eventData['changes']['updated']) {
                $saveManyToManyAudit('synced', $eventData);
            }
        });

        $this->app['events']->listen('eloquent.attached*', function ($eventData) use ($saveManyToManyAudit) {
            $saveManyToManyAudit('attached', $eventData);
        });

        $this->app['events']->listen('eloquent.detached*', function ($eventData) use ($saveManyToManyAudit) {
            $saveManyToManyAudit('detached', $eventData);
        });

@anteriovieira

[neylsongularte]

laravel/framework#14988

[TheAlexLichter]

Any update concerning this problem?

[quetzyg]

Hi everyone,

I've been thinking in a few ways to achieve this, and I'm inclided to leave it up to the developer to implement part of the functionality.

The package can already handle other events besides created, updated,deleted and restored, and like Taylor suggests, the attach/detach/sync logic should be handled in a repository, in which the proper event is fired after the DB operation happens.

So, the idea is to add three new AuditableObserver methods: attached(), detached() and synced()

The developer would be responsible for firing/dispatching said events and pass the data they wish to audit/log.

From that point on, the appropriate AuditableObserver method would kick in and handle things.

I think this brings a good balance between new feature and code complexity.

Thoughts?

[TheAlexLichter]

@quetzyg Sounds good to me! Because there won't be an official support concerning the events, I think that's a very good way, especially because the developers are now "unrestricted".

But please provide an example for the implementation in the docs 😛

[quetzyg]

@manniL, yeah, the idea is to keep it flexible, because I have no idea how developers want to store changes, specially when we're talking about sync events, which may affect more than one row in a pivot table. Do they want to create an audit with all the row changes or do they want to audit each row individually? There's no one-size-fits-all in this case.

And don't worry, the docs will be updated once this gets implemented.

[TheAlexLichter]

@quetzyg That's a good plan!

Well, in my case I'd simply store the changes (e.g. User A Was linked to posts 1,2,3 and is now linked to Post 4,6,7, I'd just change the stored numbers). If the relation models itself were changed, it'd be fine if there would be an extra audit model for that.

[quetzyg]

For a simple case like the one you described it's fine to use just one audit record, but when you have extra data in the pivot or when you detach hundreds of relations in one go, things would get out of hand very quickly and stuffing all that data in just one record would make it hard to track changes.

But again, I'll leave that decision to the developer.

[TheAlexLichter]

@quetzyg Yes, this can become very hairy in situations like the one you described. But as the developers are flexible, everyone will adapt it to their needs :)

[jschlies]

I think I have a solution for issue. Are you accepting pull requests??? It has, I admin, some of the data issues stated above. I can have it done in acceptable form in a couple of Saturdays

[quetzyg]

@jschlies, sure. Feel free to send a PR and we'll review it.

[TheAlexLichter]

I'm very curious! Good luck @jschlies and hit me up when u need help :)

[neylsongularte]

👍

[kevin1193]

Is the pivot observer already implemented in 5.8?

[eumanito]

Yes, @milhouse1337 shared here, take a look.

[djdony]

I think the missing feature to make it work (model events on pivot tables) is now in Laravel 5.8

https://laravel.com/docs/5.8/releases

Intermediate Table / Pivot Model Events
In previous versions of Laravel, Eloquent model events were not dispatched when attaching, detaching, or syncing custom intermediate table / "pivot" models of a many-to-many relationship. When using custom intermediate table models in Laravel 5.8, these events will now be dispatched.

Here is the PR:
laravel/framework#27571

Can you please explain more how to use with audit?

[waska14]

Hi.
As I understand, it is not yet implemented auditing many to many relations, right?

[PizzaTibe]

Helo I also need this function for a projekt, is there news?

[PizzaTibe]

I found a beter pakage https://altek.gitlab.io/accountant it works out of box for pivot relations super easy and no hacks

[eumanito]

@waska14 I have not implemented it yet

[eumanito]

@PizzaTibe Thanks for contributing, I will test this package.

[vpillinger]

Laravel 5.8 now fires eloquent events if a custom Pivot model exists. Therefore, it should be possible to get pivot audits by

1. Creating a custom pivot model
2. Adding Auditable Trait
3. Append the pivot model audit to the main model(s) audits manually in the model for display purposes.

Maybe this should be added somewhere in the docs because this seems like it is a common question.

[rogierborst]

I can confirm it works in Laravel 5.8.
As far as I can tell, your pivot table needs to have its own incrementing id and you need to set public $incrementing = true; on the pivot model. Otherwise you'll run into sql integrity constraint violations, since no auditable_id is passed.

(https://laravel.com/docs/5.8/eloquent-relationships#defining-custom-intermediate-table-models)

[amsoell]

I'm surprised there has been no follow-up here since August, as I'm unable to get this working. It seems like, even if you have $incrementing = true on your pivot model, Laravel doesn't include the model ID, and thus the Auditing package is unable to use it. Has anybody been successful in getting this package to work with custom pivot models?

[eumanito]

I gave up. To work I'm using this package: https://github.com/fico7489/laravel-pivot

[amsoell]

I gave up. To work I'm using this package: https://github.com/fico7489/laravel-pivot

It looks like it was working in version 9.3.1 but then regressed in the latest release. Put an issue up about it, hopefully we can get it working again.

[zacharias-pavlatos]

I can confirm it works in Laravel 5.8.
As far as I can tell, your pivot table needs to have its own incrementing id and you need to set public $incrementing = true; on the pivot model. Otherwise you'll run into sql integrity constraint violations, since no auditable_id is passed.

(https://laravel.com/docs/5.8/eloquent-relationships#defining-custom-intermediate-table-models)

Can you provide a gist ?

[wrabit]

@quetzyg do you have any plans on bringing the pivot auditing capability from your package Accountant into this one?

[quetzyg]

@quetzyg do you have any plans on bringing the pivot auditing capability from your package Accountant into this one?

I do not, but you can always use Accountant, instead.

[wrabit]

@quetzyg saving everything for one field change in a table with 30+ columns is overkill for my use-case, especially when 1 or 2 fields change frequently, so I prefer Auditing's flexibility.

[YoussefAshraf397]

@quetzyg How to fire a relation?
I have a translatable model and the $translatedAttributes doesn't affect when making changes in this model.

[neylsongularte]

up

[neylsongularte]

could do optional functionality with Laravel Pivot (https://github.com/fico7489/laravel-pivot)

[neylsongularte]

new Pivot Model Events from laravel not the best style

[tmishutin]

Any update on this idea @quetzyg

[quetzyg]

@tmishutin like I said a few times before, I'm no longer a maintainer of this project. Read the entire thread for suggested alternatives if you require such feature.

[MortenDHansen]

With version 13 we have addressed the oldest issue and now provide a way to solve this. https://www.laravel-auditing.com/docs/13.0/audit-custom