Incorrect user associated with audit when changing users dynamically

[dariusvelavicius]

PHP Version

8.1

Laravel Version

8.x

Package Version

13.6.8

Description

Hello guys,

When changing user on-the-fly and performing a few changes on the same model, all audits have the same associated user because of this change - 66498a9#diff-682a5b02fc6acf79eda6201541882897f0f0a3fca0d35f02e3398021fd77c63eR368-R372

Is there a reason why the user is always preloaded? Can we discuss an approach where it would be possible to control when the user should be preloaded and when it should be re-resolved?

Steps To Reproduce

• Set up Auditable for any model
• On the same request:
  • Update the model
  • Dynamically change the user (Auth::setUser())
  • Update the model some more

Possible Solutions

No response

[erikn69]

because of this change - 66498a9#diff-682a5b02fc6acf79eda6201541882897f0f0a3fca0d35f02e3398021fd77c63eR368-R372

• Fix queue auditing contracts breaking changes #883 is a correction of Queued Auditing #846 breaking changes

Is there a reason why the user is always preloaded?

You could ask the author of that change, maybe he will give you an answer.
You could also clear that variable to return to the old functionality.

Can we discuss an approach where it would be possible to control when the user should be preloaded and when it should be re-resolved?

Feel free to open a PR for that feature

[parallels999]

Dynamically change the user (Auth::setUser())

Why??
Are you doing some type of impersonalization? like 404labfr/laravel-impersonate

[willpower232]

If you have multiple users within a single request to your code doing auditable activity as well as changing users, it would probably be easier to make use of transformAudit rather than rely on observers which won't match your particular use case