Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance mode should be activate after successful download of ownCloud tarball #66

Closed
d7oc opened this issue Jun 10, 2022 · 4 comments · Fixed by #68
Closed

Maintenance mode should be activate after successful download of ownCloud tarball #66

d7oc opened this issue Jun 10, 2022 · 4 comments · Fixed by #68
Labels
enhancement New feature or request

Comments

@d7oc
Copy link
Contributor

d7oc commented Jun 10, 2022

Currently when the tarball could not be downloaded successfully, the Ansible scripts leave the system behind in maintenance mode. It would be more fail-safe to check the download before putting the system in maintenance mode. Or to gracefully return the system from maintenance mode if the installation couldn't be done.

@xoxys
Copy link
Contributor

xoxys commented Jun 12, 2022

Happy to discuss possible solutions. The main issue is that there are a lot of cases where "something" could happen that interrupts a playbook run and keeps a system unfinished. IMO Ansible is designed to just execute the playbook again to bring the system into the desired state, especially in the described case this would only be a temp issue, e.g. network/target unreachable and a re-run will successfully download the artifact and bring the system back into a desired state.

@d7oc
Copy link
Contributor Author

d7oc commented Jun 13, 2022

I agree that there are lot of cases for failures and for sure not all of them can be covered in Ansible due to the way Ansible works. So there is AFAIK no "rollback" which would be needed to cover all of them. Nevertheless I would like to at least cover the low hanging fruits, which means that the system should not start if the "gathering" phase already contains errors. So everything which is part of this phase should happen before the scripts actually make a change.

For the current issue I could offer to send a PR with the solution I had in mind.

@xoxys
Copy link
Contributor

xoxys commented Jun 13, 2022

Sure, happy to review.

@d7oc
Copy link
Contributor Author

d7oc commented Jun 13, 2022

See #68

@xoxys xoxys linked a pull request Jun 13, 2022 that will close this issue
@xoxys xoxys closed this as completed in #68 Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants