Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure we only ship the really needed dependencies #33

Closed
5 tasks done
georgehrke opened this issue Sep 12, 2015 · 9 comments
Closed
5 tasks done

Make sure we only ship the really needed dependencies #33

georgehrke opened this issue Sep 12, 2015 · 9 comments

Comments

@georgehrke
Copy link
Contributor

Do we really need ... at all?

  • angular-route
  • fontawesome
  • jquery-fileupload
  • appframeworkjs

Do we need ... in production?

  • angular-mocks
@georgehrke georgehrke added this to the Rework - Sprint 4 milestone Sep 12, 2015
@raghunayyar
Copy link
Member

We can get definitely get rid of fontawesome if get some awesome icons from @jancborchardt. I can supply the list of icons needed, they can be a part of core.

I dont think we need mocks in production, we need it in development. jquery-timepicker is used in the events editor when the all day mode is turned off. We can think of getting rid of that as use the angular date-picker itself.

@jancborchardt
Copy link
Member

List the icons you use from fontawesome and where/why you need them.

(Great initiative to question the dependencies!)

@georgehrke georgehrke modified the milestones: Rework - Sprint 4, ownCloud 9.0 Nov 20, 2015
@georgehrke
Copy link
Contributor Author

List the icons you use from fontawesome and where/why you need them.

ping @raghunayyar

@raghunayyar
Copy link
Member

I think we should use font-awesome till the time we have the editor our way, I will remove it when we start pushing it to a popover.

@jancborchardt
Copy link
Member

I’d say drop fontawesome as soon as possible.

@georgehrke
Copy link
Contributor Author

I'd really go with @jancborchardt here. We use at most 5 font-awesome icons in the in the events editor, probably less. font awesome is huge, shipping it is a real overkill for us

@raghunayyar
Copy link
Member

file upload will also go once the import PR is in. \o/

@georgehrke
Copy link
Contributor Author

angular-mocks is only a development dependency by now,
ng ui calendar requires ng-route -> can't drop

@georgehrke
Copy link
Contributor Author

jQuery file upload will go with #58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants