-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure we only ship the really needed dependencies #33
Comments
We can get definitely get rid of fontawesome if get some awesome icons from @jancborchardt. I can supply the list of icons needed, they can be a part of core. I dont think we need mocks in production, we need it in development. jquery-timepicker is used in the events editor when the all day mode is turned off. We can think of getting rid of that as use the angular date-picker itself. |
List the icons you use from fontawesome and where/why you need them. (Great initiative to question the dependencies!) |
ping @raghunayyar |
I think we should use font-awesome till the time we have the editor our way, I will remove it when we start pushing it to a popover. |
I’d say drop fontawesome as soon as possible. |
I'd really go with @jancborchardt here. We use at most 5 font-awesome icons in the in the events editor, probably less. font awesome is huge, shipping it is a real overkill for us |
file upload will also go once the import PR is in. \o/ |
angular-mocks is only a development dependency by now, |
jQuery file upload will go with #58 |
Do we really need ... at all?
Do we need ... in production?
The text was updated successfully, but these errors were encountered: