[Testpilotcloud] Update channel warning does not reset dropdown selection

[fmoc]

Pre-submission Checks

• I checked for similar issues, but could not find any. I also checked the closed issues. I could not contribute additional information to any existing issue.
• I will take the time to fill in all the required fields. I know that the bug report may be dismissed otherwise due to lack of information.

Describe the bug

When changing the update channel in the settings, a dialog will pop up informing about the consequences. If the dialog is aborted, the selection in the dropdown is not reset.

The selection can be reset manually without triggering a new dialog.

Expected behavior

When aborting a dialog like this, the original state should be restored.

Steps to reproduce the issue

Change the update channel from "beta" to "stable" for instance.

Screenshots

No response

Logs

No response

Client version number

3.0.0-beta1 build 9006 on Ubuntu 22.04

Desktop environment (Linux only)

No response

Client package version and origin (Linux only)

No response

Installation path (Windows only)

No response

Server information

No response

Additional context

No response

[github-actions]

This issue was marked stale because it has been open for 30 days with no activity. Remove the stale label or comment or this will be closed in 7 days.

[TheOneRing]

Can't reproduce on Windows.

[fmoc]

Reproduced on Ubuntu 22.04 with the latest AppImage:

testpilotcloud 3.2.0.10137-daily20230213 c03e01
Qt Bibliotheken 5.15.5, OpenSSL 1.1.1q 5 Jul 2022
verwenden die Erweiterung für virtuelle Dateien: suffix
ubuntu-5.15.0-56-generic

[fmoc]

Turns out the issue is localization. The settings dialog sets the entry by string and also uses string comparison to configure the current channel. When, e.g., using a German locale, the strings change from "stable" to "Stabil" and "beta" to "Beta", breaking the code. Using numeric indices to change back to the original value fixes the problem.

[Salipa-Gurung]

Version : testpilotcloud 4.0.0.10477-daily20230322 bb5d97

Reproduced on	Ubuntu 22.04.2	Windows 10 pro
Initial channel: beta
Selecting stable from dropdown and aborting dialog
dropdown selection changed to: stable
	initial state is not restored ❌	initial state is not restored ❌

When initial channel is stable same behaviour is shown while selecting beta from dropdown and aborting dialog

CC: @fmoc @TheOneRing @HanaGemela

[fmoc]

Please test with a non-English locale.

[Salipa-Gurung]

After changing language to Deutsch, dropdown selection is not resetting after aborting dialog box ❌

[fmoc]

Confirmed; worse than before, en locale is broken as well.

[fmoc]

Fix provided in #10627.

[saw-jan]

Tested with testpilotcloud 4.0.0.10610-daily20230411 a8eb35

Default state	Change the channel and Cancel	Reverts to previous state ✔️