Firefox crashes when opening Explorer due to ownCloud dll

[annavanharmelen]

Pre-submission Checks

• I checked for similar issues, but could not find any. I also checked the closed issues. I could not contribute additional information to any existing issue.
• I will take the time to fill in all the required fields. I know that the bug report may be dismissed otherwise due to lack of information.

Describe the bug

Since the 5.3.0 release of the ownCloud desktop app on Windows, the following started happening: When opening the Explorer from Firefox, e.g. for selecting a file for an upload input or saving a file (from the print dialog or just the entire web page), Firefox crashed. The crash reports mention a ownCloud dll (OCOverlays.dll) and removing the desktop app did solve the issue.

Expected behavior

I expected to be able to open Explorer when trying to save or upload a file from Firefox.

Steps to reproduce the issue

1. Have ownCloud installed, in this case logged in with an Enterprise account (from my university)
2. Have Firefox installed (version 126.0.1/127 beta doesn't matter, troubleshoot mode doesn't matter)
3. Open Firefox
4. Press Ctrl+S to save any open page
5. Firefox crashes

Screenshots

No response

Logs

I don't have ownCloud specific logs, but I do have some Firefox crash reports:

• https://crash-stats.mozilla.org/report/index/8ff5e1db-fdc4-46c5-99fe-f6db00240610
• https://crash-stats.mozilla.org/report/index/42902b22-e938-466f-ba89-a81ae0240610
• https://crash-stats.mozilla.org/report/index/e7cf502a-827c-4f62-8712-b42ba0240607
  Can provide more if needed.

Client version number

ownCloud 5.3.0.13987 bda4a9
Libraries Qt 6.4.3, OpenSSL 3.1.2 1 Aug 2023
Using virtual files plugin: wincfapi
OS: windows-10.0.22631
QPA: windows

Desktop environment (Linux only)

No response

Client package version and origin (Linux only)

No response

Installation path (Windows only)

C:\Program Files\ownCloud

Server information

No response

Additional context

I tried:

• Troubleshoot mode of Firefox
• Edge (worked)
• Refreshing and reinstalling Firefox

[TheOneRing]

https://central.owncloud.org/t/owncloud-client-5-2-1-13040-owncloud-client-explorer-exe-crash-loop/48472/17

[TheOneRing]

The issue is related to https://cmake.org/cmake/help/latest/variable/CMAKE_MSVC_RUNTIME_LIBRARY.html#variable:CMAKE_MSVC_RUNTIME_LIBRARY
Which causes https://github.com/owncloud/client/blob/master/shell_integration/windows/CMakeLists.txt#L10 to have no effect.

[T-SysDev]

We ran into this with multiple programs (Outlook, Excel, MS Teams). I'm assuming that it has something to do with Microsoft's file selection window that many programs use. I don't mean that it's a MS issue. It does appear to be an ownCloud 5.3.0 client issue for Windows 11 22H2 (at least that's the only place it's caused us problems). What worked for us is to uninstall 5.3.0 and install 5.2.1 for now. Note too that we ran into problems upgrading Windows while 5.3.0 was installed, but didn't spend much time figuring out if that was a MS or ownCloud client issue.

[jmairboeck]

For the record: I noticed the same problem also in Visual Studio 2022: https://developercommunity.visualstudio.com/t/Visual-Studio-crashes-after-opening-any-/10679034

[TheOneRing]

Fixed in https://github.com/owncloud/client/releases/tag/v5.3.1

[annavanharmelen]

Wow! Thanks for the quick solution 🤩 I've downloaded the new version and it works like a charm!