Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OC.Previews utility in JS side telling what preview mimetypes are available #17543

Closed
PVince81 opened this issue Jul 9, 2015 · 5 comments
Closed

Comments

@PVince81
Copy link
Contributor

PVince81 commented Jul 9, 2015

@rullzer @oparoz as discussed, a utility class on the JS side that stores a list of mimetypes for which previews are supported.

This makes it possible to get rid of "isPreviewAvailable" so the server doesn't have to compute and return this for every file.

@PVince81
Copy link
Contributor Author

PVince81 commented Jul 9, 2015

This could go even further and provide utility methods to retrieve previews either for file icons or also real thumbnails. Basically move "lazyLoadPreviews" here but give it a better name.

Then also find a way to override it for the public page.

@oparoz
Copy link
Contributor

oparoz commented Jul 9, 2015

OK from me. Gallery already uses such an array to build the thumbnails list or the slideshow, so all good.

@PVince81
Copy link
Contributor Author

@VicDeo didn't we add something recently to avoid 404s ?

@VicDeo
Copy link
Member

VicDeo commented Jan 5, 2018

@PVince81 here you go https://github.com/owncloud/core/blob/master/core/js/config.php#L172
Seems to be done since 10.0.0

@lock
Copy link

lock bot commented Jul 31, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants