Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tests of escaped file and folder names more flexible. #38367

Closed
phil-davis opened this issue Feb 1, 2021 · 0 comments · Fixed by #38374
Closed

Make tests of escaped file and folder names more flexible. #38367

phil-davis opened this issue Feb 1, 2021 · 0 comments · Fixed by #38374
Assignees
Labels

Comments

@phil-davis
Copy link
Contributor

See cs3org/reva#1425

There are tests that check the d:href string that is returned in PROPFIND or other API requests. If the file path contains "special characters" then those have been escaped. For example, a space character is escaped as %20, a question mark is escaped as %3F or %3f

https://tools.ietf.org/html/rfc3986#section-2.1 specifies that this escaping/encoding is not case-sensitive. %3F and %3f are both valid representations of ?.

Find the places in the core API test suite where the tests are currently "too fussy". Make those tests case-insensitive.

This will help when testing against other implementations like OCIS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants