Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cli tests for occ db commands #39190

Closed
kiranparajuli589 opened this issue Sep 9, 2021 · 3 comments
Closed

add cli tests for occ db commands #39190

kiranparajuli589 opened this issue Sep 9, 2021 · 3 comments
Assignees
Labels

Comments

@kiranparajuli589
Copy link
Contributor

From #33051

add cli tests for db commands (might have to setup a ci pipeline to start with multiple dbs and convert them back and forth)

Ref:
Databse conversion command docs

@kiranparajuli589 kiranparajuli589 changed the title add cli tests for db commands add cli tests for occ db commands Sep 9, 2021
@kiranparajuli589 kiranparajuli589 changed the title add cli tests for occ db commands add cli tests for occ db commands Sep 9, 2021
@kiranparajuli589 kiranparajuli589 changed the title add cli tests for occ db commands add cli tests for occ db commands Sep 9, 2021
@saw-jan saw-jan self-assigned this Oct 19, 2021
@saw-jan
Copy link
Member

saw-jan commented Nov 18, 2021

I was working on this issue before and the PR is WIP. see #39393
problem encountered: one db-convert scenario finishes and then after & before hooks fail. Maybe some problem occurred in reverting server state after converting the db type

I got occupied by tasks in desktop-client and was hoping to look back into this issue.

I will leave this issue for others to take. But I will take it later if this is still in ToDo

@saw-jan saw-jan removed their assignment Nov 18, 2021
@phil-davis
Copy link
Contributor

Ref: https://doc.owncloud.com/server/10.8/admin_manual/configuration/database/db_conversion.html

We can just have a single scenario that, for example, starts with an SQLite database and converts to MariaDB (or mySQL), and run that in its own pipeline. Don't then try to revert in an AfterScenario. This is a by-definition infrastructure-changing test. It is something that can be run in a throw-away environment (separate drone pipeline).

Tag in a way that it will not accidentally be run by any oC10 app or other CI that runs tests core tests.

@kiranparajuli589 kiranparajuli589 self-assigned this Dec 3, 2021
@kiranparajuli589
Copy link
Contributor Author

#39393 has been cherry-picked for master see here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants