Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make uuid middleware work with other service-registry than mdns #1435

Closed
IljaN opened this issue May 11, 2020 · 2 comments
Closed

Make uuid middleware work with other service-registry than mdns #1435

IljaN opened this issue May 11, 2020 · 2 comments

Comments

@IljaN
Copy link
Contributor

IljaN commented May 11, 2020

See https://github.com/owncloud-docker/compose-playground/blob/master/examples/services/add-user/add-user.go#L17 for an example. Maybe there is even a better way which does not require instantiation of a new service?

Micro controls the service-registry type with the environment variable MICRO_REGISTRY. This setting does not work because the proxy is not wrapped in a micro-service.

Two possible routes to fix this:

  • Use the micro way and wrap the proxy in to a service.
  • Manually instantiate a dummy service and use it`s client. (like in the example above)
@IljaN IljaN transferred this issue from owncloud/ocis-accounts May 11, 2020
@IljaN IljaN changed the title Make accounts work with other service-registry than mdns Make service discovery work with other service-registry than mdns May 11, 2020
@IljaN IljaN changed the title Make service discovery work with other service-registry than mdns Make uuid middleware work with other service-registry than mdns May 11, 2020
@butonic
Copy link
Member

butonic commented Jun 30, 2020

AFAIU the default registry is mdns, but it can be changed to etcd by setting MICRO_REGISTRY="etcd".
Other implementations, eg consul or nats are available as plugins

but ... we need to pass the registry Option to the micro client as well, because the exampleso use the micre cmd which parses the env variable and passes it accordingly https://github.com/micro/go-micro/blob/4f0f4326df8bef9c0d1b81d79792500b38a942f2/config/cmd/cmd.go#L440

@haribhandari07 haribhandari07 transferred this issue from owncloud/ocis-proxy Jan 25, 2021
@phil-davis
Copy link
Contributor

@IljaN @butonic this is an old issue that was transferred from the archived ocis-proxy repo a few weeks ago.
Please close if no longer relevant.

@IljaN IljaN closed this as completed Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants