-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ocis should not have default secrets #212
Labels
Type:Story
User Story
Comments
refs
changed the title
Hard-coded default-secrets. ocis init?
Hardcoded default-secrets. ocis init?
Jan 13, 2021
currently only covered by documentation: https://owncloud.dev/ocis/deployment/#secure-an-ocis-instance |
exalate-issue-sync
bot
added
p3-medium
Type:Story
User Story
and removed
Type:Bug
labels
Mar 24, 2022
exalate-issue-sync
bot
changed the title
Hardcoded default-secrets. ocis init?
Ocis should not start with default secrets
Apr 6, 2022
exalate-issue-sync
bot
removed
Topic:Security
Category:Defect
Existing functionality is not working as expected
labels
Apr 6, 2022
exalate-issue-sync
bot
changed the title
Ocis should not start with default secrets
Ocis should not have with default secrets
Apr 6, 2022
exalate-issue-sync
bot
changed the title
Ocis should not have with default secrets
Ocis should not have default secrets
Apr 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
To have a seamless first run experience we currently hard-code shared-secrets in to different services as default values:
https://github.com/owncloud/ocis-reva/blob/master/pkg/flagset/gateway.go#L79
https://github.com/search?q=org%3Aowncloud+Pive-Fumkiu4&type=Code
When running
ocis server
a admin who forgets to change this variable will use an insecure default configuration.Proposal to fix this would be to create an "ocis init" command which for example could generate an .env file and required certificates and defaults. This would also remove all the default handling from the services and bundle it in to one place.
Additionally ocis init could abstract away the knowledge of how to set the same parameter across every single service. For example IDP/Issuer configuration could be configured once and the generated .env file or config would reflect the setting for every single service.
User Stories
Value
Acceptance Criteria
Definition of ready
[ ] everybody needs to understand the value written in the user story
[ ] acceptance criteria has to be defined
[ ] all dependencies of the user story need to be identified
[ ] feature should be seen from an end user perspective
[ ] user story has to be estimated
[ ] story points need to be less then 20
Definition of done
[ ] functionality described in the user story works
[ ] acceptance criteria are fulfilled
[ ] codre review happened
[ ] CI is green
[ ] critical code received unit tests by the developer
[ ] automated tests passed (if automated tests are not available, this test needs to be created and passed
[ ] no sonar cloud issues
The text was updated successfully, but these errors were encountered: