Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download of file inside public link is named after the token #2670

Closed
labkode opened this issue Oct 25, 2021 · 4 comments
Closed

Download of file inside public link is named after the token #2670

labkode opened this issue Oct 25, 2021 · 4 comments

Comments

@labkode
Copy link
Member

labkode commented Oct 25, 2021

Describe the bug

Given a public link like this:
Screenshot 2021-10-25 at 07 26 13

When I download the file, the downloaded file is named:
rWAjMExZgbrkhml, note there is NO extension.

Such behaviour is terrible from a usability perspective.

I imagine something like this is missing or is wrong:
https://github.com/cernbox/revaold/blob/67b606cb07160c6d937cbe05840aea70d05a30cd/ocproxy/api/api.go#L3547

@wkloucek
Copy link
Contributor

I could not reproduce this issue with oCIS 25d6e4e and REVA cs3org/reva@582ce36aadcc

Looks all fine:

Peek.2021-10-25.08-39.mp4

@labkode
Copy link
Member Author

labkode commented Nov 5, 2021

@wkloucek in the video I don't see the downloaded files.
Have you checked they are downloaded with the correct name?

@wkloucek
Copy link
Contributor

wkloucek commented Nov 5, 2021

@wkloucek in the video I don't see the downloaded files. Have you checked they are downloaded with the correct name?

you can see them in the bottom left corner (media controls might overlay that)

@butonic
Copy link
Member

butonic commented Dec 2, 2021

AFAICT fixed by cs3org/reva#2303

@wkloucek wkloucek closed this as completed Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants