Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate Propfind deep benchmark #2687

Closed
micbar opened this issue Oct 27, 2021 · 9 comments
Closed

Investigate Propfind deep benchmark #2687

micbar opened this issue Oct 27, 2021 · 9 comments
Labels
OCIS-Fastlane Planned outside of the sprint Priority:p2-high Escalation, on top of current planning, release blocker Status:Completed Topic:Performance

Comments

@micbar
Copy link
Contributor

micbar commented Oct 27, 2021

Description

We have a slight performance drop (~25%) between ocis 1.13 and ocis 1.14.

See #2671

Investigation is needed.

@micbar micbar added Priority:p2-high Escalation, on top of current planning, release blocker OCIS-Fastlane Planned outside of the sprint labels Oct 27, 2021
@micbar micbar mentioned this issue Oct 27, 2021
22 tasks
@stale
Copy link

stale bot commented Dec 26, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 10 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status:Stale label Dec 26, 2021
@micbar
Copy link
Contributor Author

micbar commented Dec 27, 2021

Still open

@stale stale bot removed the Status:Stale label Dec 27, 2021
@stale
Copy link

stale bot commented Feb 25, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 10 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status:Stale label Feb 25, 2022
@micbar
Copy link
Contributor Author

micbar commented Feb 25, 2022

still needs investigation

@stale stale bot removed the Status:Stale label Feb 25, 2022
@stale
Copy link

stale bot commented Apr 27, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 10 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status:Stale label Apr 27, 2022
@stale stale bot closed this as completed May 9, 2022
@micbar
Copy link
Contributor Author

micbar commented May 9, 2022

still needs investigation

@micbar micbar reopened this May 9, 2022
@stale stale bot removed the Status:Stale label May 9, 2022
@C0rby C0rby assigned C0rby and unassigned C0rby May 11, 2022
@butonic
Copy link
Member

butonic commented Jun 21, 2022

this is getting worse. AFAICT cdperf uses the legacy /dav/files/{username} endpoint. For that the ocdav service acts as a client that has to query every storage space a user has access to to determine the most recent etag to present for the root. First the code lists all storage spaces the user has access to, then it has to do a stat request to fill the etag and mtime. by requesting the new root_info property we could get rid of the additional stat request.

Furthermore, the ocdav service should cache share spaces for recipients, because they don't need to immediately see changes when using the legacy endpoint.

For /dav/spaces/{spaceid} this enumeration problem does not exist.

@stale
Copy link

stale bot commented Aug 31, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 10 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status:Stale label Aug 31, 2022
@stale stale bot closed this as completed Sep 15, 2022
@micbar
Copy link
Contributor Author

micbar commented Dec 13, 2022

Caching was implemented on some levels.

  • Stat cache
  • xattr cache

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCIS-Fastlane Planned outside of the sprint Priority:p2-high Escalation, on top of current planning, release blocker Status:Completed Topic:Performance
Projects
Archived in project
Development

No branches or pull requests

3 participants