Serveral places with hardcoded UUIDs

[rhafer]

Describe the bug

ocis has still quite a few place where it using hardcoded UUIDs:

• as already mentioned the admin user (hardcoded admin id #3524) and the settings service user (Setttings service (and share manager) require a hardcoded internal service user #3343) use hardcoded UUIDs
• all the roles and permissions have hardcoded UUIDs https://github.com/owncloud/ocis/blob/master/extensions/settings/pkg/store/defaults/defaults.go
• the space id for the settings service is hardcoded https://github.com/owncloud/ocis/blob/master/extensions/settings/pkg/store/metadata/store.go#L23
• likely more (this is just what a quick glance revealed)

I think we need to address all of these to make sure the UUIDs we use are really globally unique (across instances)

cc @dragonchaser @C0rby @butonic @micbar

[wkloucek]

see also #5064

[ScharfViktor]

@rhafer still relevant or can we close? all links in the bug description lead to 404 - page not found

[wkloucek]

@ScharfViktor this issue predates the extensions to services rename.

Still valid:

ocis/services/settings/pkg/store/defaults/defaults.go

Lines 9 to 26 in f74f656

	// BundleUUIDRoleAdmin represents the admin role
	BundleUUIDRoleAdmin = "71881883-1768-46bd-a24d-a356a2afdf7f"
	// BundleUUIDRoleSpaceAdmin represents the space admin role
	BundleUUIDRoleSpaceAdmin = "2aadd357-682c-406b-8874-293091995fdd"
	// BundleUUIDRoleUser represents the user role.
	BundleUUIDRoleUser = "d7beeea8-8ff4-406b-8fb6-ab2dd81e6b11"
	// BundleUUIDRoleUserLight represents the user light role.
	BundleUUIDRoleUserLight = "38071a68-456a-4553-846a-fa67bf5596cc"
	// BundleUUIDProfile represents the user profile.
	BundleUUIDProfile = "2a506de7-99bd-4f0d-994e-c38e72c28fd9"
	// BundleUUIDServiceAccount represents the service account role.
	BundleUUIDServiceAccount = "bcceed81-c610-49cc-ab77-39a024e8da12"
	// SettingUUIDProfileLanguage is the hardcoded setting UUID for the user profile language
	SettingUUIDProfileLanguage = "aa8cfbe5-95d4-4f7e-a032-c3c01f5f062f"
	// SettingUUIDProfileDisableNotifications is the hardcoded setting UUID for the disable notifications setting
	SettingUUIDProfileDisableNotifications = "33ffb5d6-cd07-4dc0-afb0-84f7559ae438"
	// SettingUUIDProfileAutoAcceptShares is the hardcoded setting UUID for the disable notifications setting
	SettingUUIDProfileAutoAcceptShares = "ec3ed4a3-3946-4efc-8f9f-76d38b12d3a9"

ocis/services/settings/pkg/store/metadata/store.go

Line 24 in f74f656

settingsSpaceID = "f1bdd61a-da7c-49fc-8203-0558109d1b4f" // uuid.Must(uuid.NewV4()).String()

[micbar]

Is there a collision?