Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authorization for tus-uploads on password protected links #3588

Closed
JammingBen opened this issue Apr 26, 2022 · 3 comments
Closed

Authorization for tus-uploads on password protected links #3588

JammingBen opened this issue Apr 26, 2022 · 3 comments
Labels
OCIS-Fastlane Planned outside of the sprint Priority:p2-high Escalation, on top of current planning, release blocker Type:Bug

Comments

@JammingBen
Copy link
Contributor

JammingBen commented Apr 26, 2022

When I'm uploading a file via tus to a password protected public link, the initial POST request succeeds without problems: https://localhost:9200/remote.php/dav/public-files/WoXYZdRaXgPZEZZ/. The auth header is e.g. Basic cHVibGljOnRlc3Q=.

Now the second request, a HEAD request, with the exact same auth header stays in a pending state in the browser network tab. Instead, the classic Basic-Auth-Browser-Window pops up and asks for credentials as the backend response includes Www-Authenticate in its response headers.

The oCIS error log prints ERR error fetching from accounts-service error="{\"id\":\"com.owncloud.api.accounts\",\"code\":401,\"detail\":\"account not found or invalid credentials\",\"status\":\"Unauthorized\"}" query="login eq 'public' and password eq 'test'" service=proxy

I'm not a 100% sure if this is a frontend or a backend issue. But the requests seem to be correct for me, so my first impression is that something in oCIS goes wrong here.

Edit: I also ran the head request via curl, which is giving me 401 Unauthorized as well.

@micbar
Copy link
Contributor

micbar commented May 5, 2022

@kobergj FYI

@micbar micbar added Priority:p2-high Escalation, on top of current planning, release blocker OCIS-Fastlane Planned outside of the sprint labels May 5, 2022
@kobergj
Copy link
Collaborator

kobergj commented May 5, 2022

Fix was merged. Problem is gone with current master

@JammingBen we can remove the workaround now

@JammingBen
Copy link
Contributor Author

Thx, works fine 👍 See owncloud/web#6890 for frontend follow up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCIS-Fastlane Planned outside of the sprint Priority:p2-high Escalation, on top of current planning, release blocker Type:Bug
Projects
None yet
Development

No branches or pull requests

3 participants