Email notifications are not descriptive enough

[tbsbdr]

Steps to reproduce

1. share files with people on https://ocis.ocis-traefik.latest.owncloud.works/
2. open https://mail.ocis-traefik.latest.owncloud.works/
3. read notification mails

Received: from localhost ([172.18.0.6]) by inbucket
  for <[email protected]>; Tue, 26 Jul 2022 06:18:37 +0000 (UTC)
Content-Transfer-Encoding: quoted-printable
Date: Tue, 26 Jul 2022 06:18:37 +0000
Mime-Version: 1.0
From: <[email protected]>
To: <[email protected]>
Content-Type: text/plain; charset=UTF-8

You got a share!

example:

Expected behaviour

• Incorporate learnings from oc10 mails

• Mails should be enriched by:

  • clear sender name
  • useful subject
  • useful description
  • link in description
  • imprint
  • maybe HTML mail

• Mails will be send on those events

  • "you received a share"
  • "virus found" (receiver: user; implications: file not uploaded; filename + path; Infos about the virus so that the user can )
  • "You have been added to a Space"

• exact content incl. subject and sender name / header (write off form oc10?)

• plaintext

• i18n: german + english in 1 mail for a start

---

Share received notification

From

<User> via <product name> ([email protected])

Subject

<User> shared <file/folder> with you

Body

<User> invited you to <file/folder>

Signature

-

Powered by ownCloud - Store. Share. Work. - https://owncloud.com

Imprint<translatable, Imprint link>

Privacy Policy<translatable, Privacy Policy Link>

Default Signature

ownCloud - Store. Share. Work.
https://owncloud.com/

[AlexAndBear]

@tbsbdr Afaik this should be handled by the backend not the frontend?

[tbsbdr]

sure - this is mainly about wording and content

[AlexAndBear]

Fair enough, but I don't think this is something we can change in web, those things have to be done in ocis.
But if you know about that, I am fine with having this ticket in the web repo

[tbsbdr]

update: updated expected behaviour

[kulmann]

Can we move this issue to the ocis repo? Has nothing to do with web.

Also: the backend knows the language that was chosen by the user (otherwise defaults to english, browser language is not known in the backend). But easiest start still is just sending english + german in one email like you proposed.

[tbsbdr]

okok, I'll move

[micbar]

This has two aspects:

1. GA Release -> make the share notification "nicer"
2. 2.1.0 Release -> according to top post

[tbsbdr]

updated:

- Mails will be send on those events
 - "You have been added to a Space"

[tbsbdr]

@fschade if a virus is detected, we need to inform the user about it via mail.
something like this:

could you please state which information we have about the virus ex. virus name, type, description etc.?

[C0rby]

@micbar @tbsbdr what exactly needs to be done for the GA?
I think this ticket should be a story and not a bug since what is implemented was exactly requested like that.

We need a story with detailed acceptance criteria of what should be in the mail, in what format, etc.

[pmaier1]

I think this ticket should be a story and not a bug since what is implemented was exactly requested like that.

Well, "You got a share" is too little unfortunately. What we would like to see for GA for the "Share created" notification is the following (or a variation of it depending on possibilities).

From

<Share creator display name> via ownCloud ([email protected])

Subject

<Share creator display name> shared <file/folder> with you

Body

Hello <recipient display name>,

<Share creator display name> invited you to <file/folder>. Click here to view it: <private link>

---

Hallo <recipient display name>,

<Share creator display name> hat dich zu <file/folder> eingeladen. Klicke hier zum Anzeigen: <private link>

---
ownCloud - Store. Share. Work.
https://owncloud.com/

[rhafer]

@dragonchaser It seems the fix for this has been merged (#4564). Can this be closed? Or can we at least remove it from the GA-Milestone and Blocker List?

[micbar]

removing from GA milestone, requirements reached.

[wkloucek]

request fulfilled