Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Favourite a received share or any item in a share is impossible #724

Closed
individual-it opened this issue Oct 21, 2020 · 8 comments
Closed
Labels
Category:Defect Existing functionality is not working as expected Type:Bug

Comments

@individual-it
Copy link
Member

  1. as einstein create a folder with a file as content
  2. as einstein share that folder with richard
  3. as richard accept the share
  4. as richard try to favourite the file inside the received folder curl -v -k -u richard:superfluidity -X PROPPATCH https://localhost:9200/remote.php/webdav/Shares/f1/english.png -d '<?xml version="1.0"?><d:propertyupdate xmlns:d="DAV:" xmlns:oc="http://owncloud.org/ns"> <d:set><d:prop><oc:favorite xmlns:oc="http://owncloud.org/ns">1</oc:favorite></d:prop></d:set></d:propertyupdate>'

Result: HTTP/1.1 404 Not Found

ocis logs:

2020-10-21T15:53:09+05:45 WRN resource not found path=/home/Shares/f1/english.png pkg=rhttp service=storage traceid=ff5dde45d2697a8b5c5dc82c7380983c
2020-10-21T15:53:09+05:45 WRN http end="21/Oct/2020:15:53:09 +0545" host=127.0.0.1 method=PROPPATCH pkg=rhttp proto=HTTP/1.1 service=storage size=0 start="21/Oct/2020:15:53:09 +0545" status=404 time_ns=365185929 traceid=ff5dde45d2697a8b5c5dc82c7380983c uri=/remote.php/webdav/Shares/f1/english.png url=/remote.php/webdav/Shares/f1/english.png
@refs
Copy link
Member

refs commented Jan 12, 2021

Perhaps because favorites are not yet implemented? @butonic is working on it right now, perhaps back-reference this issue in your PR?

@settings settings bot removed the bug label Jan 12, 2021
@refs refs changed the title favourite a received share or any item in a share is impossible Favourite a received share or any item in a share is impossible Jan 13, 2021
@refs refs added the Category:Defect Existing functionality is not working as expected label Jan 13, 2021
@refs
Copy link
Member

refs commented Jan 18, 2021

possible duplicate of #1228 ?

@individual-it
Copy link
Member Author

@refs this IS 724 ;-)

@refs
Copy link
Member

refs commented Jan 18, 2021

grrrrr, wrong one. Let me fix it. Thanks for the heads up.

@refs
Copy link
Member

refs commented Jan 18, 2021

@refs this IS 724 ;-)

fixed. I was referring to #1228

@individual-it
Copy link
Member Author

This is only about files in received shares and it seems only to happen on owncloud storage not on ocis storage

@refs
Copy link
Member

refs commented Jan 19, 2021

thanks! labeling as storage:oc and moving on. We need to decide at some point what to do with all the storage:oc issues, and if the OC Storage will survive at all

@individual-it
Copy link
Member Author

closing in favour of #1228

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category:Defect Existing functionality is not working as expected Type:Bug
Projects
None yet
Development

No branches or pull requests

2 participants