Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add banned password list to default deployments #7724

Closed
14 tasks
micbar opened this issue Nov 14, 2023 · 7 comments · Fixed by #7784
Closed
14 tasks

Add banned password list to default deployments #7724

micbar opened this issue Nov 14, 2023 · 7 comments · Fixed by #7784
Labels
Type:Story User Story
Milestone

Comments

@micbar
Copy link
Contributor

micbar commented Nov 14, 2023

Description

Follow up of #7682

User Stories

  • As a client developer i want to test the new server implementation.

Value

Easy integration

Acceptance Criteria

  • Continous ocis deployments have configured list as banned passwords which meet the policy

Definition of ready

  • Everybody needs to understand the value written in the user story
  • Acceptance criteria have to be defined
  • All dependencies of the user story need to be identified
  • Feature should be seen from an end user perspective
  • Story has to be estimated
  • Story points need to be less than 20

Definition of done

  • Functional requirements
    • Functionality described in the user story works
    • Acceptance criteria are fulfilled
  • Quality
    • Code review happened
    • CI is green (that includes new and existing automated tests)
    • Critical code received unit tests by the developer
  • Non-functional requirements
    • No sonar cloud issues
  • Configuration changes
    • The next branch of the ocis charts is compatible
@micbar micbar added the Type:Story User Story label Nov 14, 2023
@micbar
Copy link
Contributor Author

micbar commented Nov 14, 2023

@michaelstingl

@micbar
Copy link
Contributor Author

micbar commented Nov 14, 2023

@ScharfViktor do you need a dev to work on that?

@ScharfViktor
Copy link
Contributor

@ScharfViktor do you need a dev to work on that?

I don't know yet. I'll ask Roman for help if I can't figure out how to do it.

@2403905
Copy link
Contributor

2403905 commented Nov 16, 2023

ocis tries to load a file from the FRONTEND_PASSWORD_POLICY_BANNED_PASSWORDS_LIST if file doen't exists then ocis tries OCIS_CONFIG_DIR/FRONTEND_PASSWORD_POLICY_BANNED_PASSWORDS_LIST
@wkloucek @kobergj What is the better way to put the file in to the OCIS_CONFIG_DIR directory?

@2403905
Copy link
Contributor

2403905 commented Nov 20, 2023

@micbar Please clarify what exactly default deployments should be.The ci? The helmchart? The docker compose?

@michaelstingl
Copy link
Contributor

@micbar Please clarify what exactly default deployments should be.

Here:

@micbar
Copy link
Contributor Author

micbar commented Nov 20, 2023

Yes, the docker-compose examples in the ocis repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type:Story User Story
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants