API Test cases for MOVE between project/personal/shares spaces

[saw-jan]

Continued and extended form of #4087

Updated: There will be change in statuscode expectation.
See #8063 (comment)

We should treat a "Cross-Storage" MOVE in ocis like a cross-server move in the RFC like ...when the destination is on another sub-section of the same server namespace. This has the implication that we need to roll back the changes and respond with a 502 Status code like described in the RFC:

MOVE

1. Using file path (Updated)

Test cases

from	from (role)	to	to (role)	expected	result
project	manager/editor	project(same)		201	201 👍
project	viewer	project(same)		403	403 👍
project	manager/editor	project	manager/editor	502	502 👍
project	manager/editor	project	viewer	502	403 👍 (#8315 (comment))
project	viewer	project	manager/editor/viewer	502	403 👍 (#8315 (comment))
project	manager/editor	personal		502	502 👍
project	viewer	personal		502	403 👍 (#8315 (comment))
project	manager/editor/viewer	share jail	all/editor/viewer	502	502 👍
personal		personal(same)		201	201 👍
personal		personal(subfolder)		201	201 👍
personal		project	manager/editor	502	502 👍
personal		project	viewer	502	403 👍 (#8315 (comment))
personal		share jail	all/editor/viewer	502	502 👍
share jail	all/editor/viewer	personal		502	502 👍
share jail	all/editor/viewer	project	manager/editor/viewer	502	502 👍
share jail	all/editor/viewer	share jail	all/editor/viewer	502	502 👍
share jail	all/editor	share jail(same)		201	201 👍
share jail	viewer	share jail(same)		403	403 👍 (#8315 (comment))

Bug Reports

• MOVE a file from Project space (manager/editor) to Project space (manager/editor) returns 502 code #8116
• MOVE a file from Project space (manager/editor) to Personal space returns 502 code #7618
• MOVE between Shares responds with 502 #8063
• Cannot move folder/file from one received share to another #2442
• [OCIS-storage] not possible to move file into a received folder #764
• HTTP statuscode while MOVE between cross-spaces with Viewer role #8315

2. Using file id (Updated)

Test Cases

from	from (role)	to	to (role)	expected	result
project	manager/editor	project(same)		201	201 👍
project	viewer	project(same)		403	403 👍 (#8315 (comment))
project	manager/editor	project	manager/editor	502	502 👍
project	manager/editor	project	viewer	502	403 👍 (#8315 (comment))
project	viewer	project	manager/editor/viewer	502	403 👍 (#8315 (comment))
project	manager/editor	personal		502	502 👍
project	viewer	personal		502	403 👍 (#8315 (comment))
project	manager/editor/viewer	share jail	all/editor/viewer	502	502 👍
personal		personal(same)		201	201 👍
personal		personal(subfolder)		201	201 👍
personal		project	manager/editor	502	502 👍
personal		project	viewer	502	403 👍 (#8315 (comment))
personal		share jail	all/editor/viewer	502	502 👍
share jail	all/editor	share jail(same)		201	403 ❌
share jail	viewer	share jail(same)		403	403 👍
share jail	all/editor	personal		502	502 👍
share jail	viewer	personal		502	403 👍 (#8315 (comment))
share jail	all/editor/viewer	share jail	all/editor/viewer	502	502 👍
share jail	all/editor	project	manager/editor	502	502 👍
share jail	all/editor	project	viewer	502	403 👍 (#8315 (comment))
share jail	viewer	project	manager/editor/viewer	502	403 👍 (#8315 (comment))

Bug Reports

• sharee (editor role) MOVE a file by file-id into shared sub-folder returns 502 #7617
• sharee (editor role) MOVE a file by file-id into Personal space responds with 502 instead of 403 #8124
• sharee (editor role) MOVE a file by file-id into Project space (manager/editor role) responds with 502 instead of 403 #8125

Edge cases:

• moving a file and providing the fileID of the destination destroys data #6739
• MOVE a file into same folder with same name returns 404 instead of 403 #1976
• send (MOVE,COPY) requests to another user's webDav endpoints as normal user gives 400 instead of 404 #3882
• Moving a file out of folder removes the versions #777

[saw-jan]

There will be change in statuscode expectation.

See #8063 (comment)

We should treat a "Cross-Storage" MOVE in ocis like a cross-server move in the RFC like ...when the destination is on another sub-section of the same server namespace. This has the implication that we need to roll back the changes and respond with a 502 Status code like described in the RFC:

[saw-jan]

Fixes:

• fix: revert the status code denied moves cs3org/reva#4480

[ishabaral]

All test cases are added and there is coverage for all bug reports. So closing this issue.