Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sharing NG] Replace dav property public-link-permission with type #8740

Open
JammingBen opened this issue Mar 27, 2024 · 2 comments
Open

[Sharing NG] Replace dav property public-link-permission with type #8740

JammingBen opened this issue Mar 27, 2024 · 2 comments
Assignees
Labels

Comments

@JammingBen
Copy link
Contributor

Describe the bug

When doing a PROPFIND on a public space, the response contains a dav property public-link-permission to indicate the permissions for this link. However, these permissions are being represented via permission bits, which is the old (deprecated) way of the OCS API.

Web needs this information to distinguish between the link types view and uploadOnly, since these can't be distinguished solely by the webdav permissions.

Steps to reproduce

  1. Create a public link for a folder
  2. Do a PROPFIND to list the resources for this folder (e.g. https://host.docker.internal:9200/remote.php/dav/public-files/CIlnOrnDLxMmPHx)
  3. Check the server response for the first resource (= the share itself)

Expected behavior

There is a dav property that represents the link's type, since that's the graph property representing the permissions.

Actual behavior

The is a dav property public-link-permission.

cc @rhafer

@2403905
Copy link
Contributor

2403905 commented Jun 7, 2024

@JammingBen What format do you expect for the public-link-permission?

@JammingBen
Copy link
Contributor Author

@2403905

public-link-permission is the actual behaviour. The new property should reflect the link's type, so I'd name it public-link-type. It should be a simple string representing the type, e.g. view.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants