Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sharing NG] status code list for enable and disable share sync #9176

Closed
S-Panta opened this issue May 15, 2024 · 5 comments
Closed

[Sharing NG] status code list for enable and disable share sync #9176

S-Panta opened this issue May 15, 2024 · 5 comments
Labels

Comments

@S-Panta
Copy link
Contributor

S-Panta commented May 15, 2024

Enable Share Sync

curl -X POST 'https://host.docker.internal:9200/graph/v1beta1/drives/{share-Space-Id}/root/children'  
-d '{
    "remoteItem": {
        "id":"'remote-item-id"
    }
}'
Scenerio Status Code message
enable share sync of a non-existent resource 400 mounting share failed
multiple share sync of a resource 400 mounting share failed
enable share sync with empty item id 400 invalid id
enable share sync of a resource nout shared with sharee 400 mounting share failed
try to enable sync of shared resource when sharer is deleted {if this request is done second time it result is 400 status code but gives mounting share failed message ) 400 converting to drive items failed
try to enable sync of group shared resource when sharer is deleted 400 mounting share failed
mount share multiple time 400 mounting share failed

Disable Share Sync

curl -X DELETE 'https://host.docker.internal:9200/graph/v1beta1/drives/{drive-id}/items/{item-id}' -u username:password
Scenerio Status Code message
non existence resource 400 unmounting share failed
when sharer get deleted 400 unmounting share failed
} unmount multiple time 400 unmounting share failed
invalid item id 400 invalid driveId or itemID

Should all these give same 400 status code?

Related PR : #8939

@S-Panta S-Panta changed the title status code list for enable and disable share sync [Sharing NG] status code list for enable and disable share sync May 15, 2024
@S-Panta
Copy link
Contributor Author

S-Panta commented May 15, 2024

@fschade @rhafer

@S-Panta S-Panta added Type:Bug Interaction:Needs-help Asking some hints to engineering when the issue can't be reproduced and removed Interaction:Needs-help Asking some hints to engineering when the issue can't be reproduced labels May 15, 2024
@rhafer
Copy link
Contributor

rhafer commented May 15, 2024

@2403905 I think this one is at least partially related to #8876

@S-Panta
Copy link
Contributor Author

S-Panta commented May 17, 2024

Related issue: #9001 #8876

@S-Panta
Copy link
Contributor Author

S-Panta commented May 28, 2024

Updated status code and messages
enable share sync scenarios

Scenerio Status Code message
enable share sync of a non-existent resource 404 no shares found
multiple share sync of a resource 409 shares already mounted
enable share sync with empty item id 400 invalid id
enable share sync of a resource not shared with sharee 404 no shares found
try to enable sync of shared resource when sharer is deleted 400 converting to drive items failed
try to enable sync of group shared resource when sharer is deleted 404 no shares found"

disable share sync scenarios

Scenerio Status Code message
when sharer get deleted 404 error getting received share
} unmount multiple time 404 shares already unmounted
invalid item id 400 invalid driveId or itemID

@S-Panta
Copy link
Contributor Author

S-Panta commented May 28, 2024

imo this issue can be closed as the status code given by graph API now make sense in these different scenarios.
@saw-jan @grgprarup

@rhafer rhafer closed this as completed May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants