From d6b29736979e11d79d33b772083f23e2ecc17332 Mon Sep 17 00:00:00 2001 From: "A.Unger" Date: Fri, 26 Feb 2021 10:25:18 +0100 Subject: [PATCH 1/2] delay accounts service startup --- ocis/pkg/runtime/runtime.go | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/ocis/pkg/runtime/runtime.go b/ocis/pkg/runtime/runtime.go index 55f90a8ce30..502e48e4f22 100644 --- a/ocis/pkg/runtime/runtime.go +++ b/ocis/pkg/runtime/runtime.go @@ -50,13 +50,11 @@ var ( "thumbnails", "web", "webdav", - "accounts", - //"graph", - //"graph-explorer", } dependants = []string{ "storage-sharing", + "accounts", } // Maximum number of retries until getting a connection to the rpc runtime service. maxRetries = 10 From c71fbf297a1d9b36804a9b3c4d2d55db74a0dc24 Mon Sep 17 00:00:00 2001 From: "A.Unger" Date: Fri, 26 Feb 2021 10:29:59 +0100 Subject: [PATCH 2/2] add changelog --- changelog/unreleased/accounts-init-regression.md | 8 ++++++++ 1 file changed, 8 insertions(+) create mode 100644 changelog/unreleased/accounts-init-regression.md diff --git a/changelog/unreleased/accounts-init-regression.md b/changelog/unreleased/accounts-init-regression.md new file mode 100644 index 00000000000..e744caa093c --- /dev/null +++ b/changelog/unreleased/accounts-init-regression.md @@ -0,0 +1,8 @@ +Bugfix: Purposely delay accounts service startup + +As it turns out the race condition between `accounts <-> storage-metadata` still remains. This PR is a hotfix, and it should be followed up with a proper fix. Either: + +- block the accounts' initialization until the storage metadata is ready (using the registry) or +- allow the accounts service to initialize and use a message broker to signal the accounts the metadata storage is ready to receive requests. + +https://github.com/owncloud/ocis/pull/1734