Trashbin fails with unknown error when restoring

[jnweiger]

On the web gui of owncloud/ocis:1.0.0-beta8 :

• upload a file
• delete the file
• upload the same file again
• go to trashbin, see the the copy of the file there
• restore from the trashbin, an error occurs:

Expected behaviour:

• the error message should give the reason "cannot restore in the original location XXX, a file with the same name is already there."
• and/or (even better) suggest to rename things to resolve that conflict, then restore.

[jnweiger]

Same as above, but do empty trash:

Expected behaviour: Empty trash works.

[individual-it]

duplicate of https://github.com/owncloud/ocis-reva/issues/118 ?

[butonic]

fixed by cs3org/reva#1103

[PVince81]

it's part of owncloud/ocis-reva#447.

@individual-it @phil-davis any tests to enable on ocis-reva to validate this ?

[individual-it]

tests added in owncloud/core#37831 & owncloud/ocis#482
not many passing, need more investigation

[individual-it]

bug demonstration tests added in owncloud/ocis#489

[individual-it]

phoenix tests added in owncloud/web#3982 , taking off QA-team tag

[exalate-issue-sync]

Artur Neumann commented: current behaiviour is changed, the original file is overwritten without comment. see #196

[jnweiger]

retested with

• ocis-1.0.0-rc1 via https://github.com/owncloud-docker/compose-playground/blob/master/examples/hetzner-deploy/make_ocis_eos_compose_test.sh

Version details ocis-1.0.0-rc1

OCIS_VERSION:         v1.0.0-rc1
ocis --version:       ocis version 199267c^M
git log:              commit 199267c13e916aa8de027a81dbf6733af820369f (HEAD, tag: refs/tags/v1.0.0-rc1)
eos --version:        EOS 4.6.5 (2019)^M
xrootd -v:            v4.11.0^M
bin/ocis contains:
        owncloud/[email protected]
        owncloud/[email protected]
        owncloud/[email protected]
        owncloud/[email protected]
        owncloud/[email protected]
        owncloud/[email protected]
        owncloud/[email protected]
        owncloud/[email protected]
        owncloud/[email protected]
        owncloud/ocis-pkg/[email protected]
        owncloud/[email protected]
        owncloud/[email protected]
        owncloud/[email protected]
        owncloud/[email protected]
        owncloud/[email protected]
        owncloud/[email protected]

Restore works fine in RC1. No error messages when the target name is free. Appropriate errors when the target file or directory exists. Nothing is overwritten.