diff --git a/changelog/unreleased/bugfix-move-files-between-spaces b/changelog/unreleased/bugfix-move-files-between-spaces index 805496a8681..43a7fd9529f 100644 --- a/changelog/unreleased/bugfix-move-files-between-spaces +++ b/changelog/unreleased/bugfix-move-files-between-spaces @@ -3,4 +3,5 @@ Bugfix: Inhibit move files between spaces We've inhibited moving files between spaces and will offer the user to copy instead. https://github.com/owncloud/web/pull/7652 -https://github.com/owncloud/web/issues/6892 \ No newline at end of file +https://github.com/owncloud/web/issues/6892 +https://github.com/owncloud/web/pull/7735 \ No newline at end of file diff --git a/changelog/unreleased/enhancement-make-keybindings-global b/changelog/unreleased/enhancement-make-keybindings-global index e9663a4a26a..6729909dd2d 100644 --- a/changelog/unreleased/enhancement-make-keybindings-global +++ b/changelog/unreleased/enhancement-make-keybindings-global @@ -3,4 +3,5 @@ Enhancement: Make keybindings global We've made keybindings global and introduced a data-attribute to mark elements that need custom keybindings https://github.com/owncloud/web/pull/7569 -https://github.com/owncloud/web/pull/7648 \ No newline at end of file +https://github.com/owncloud/web/pull/7648 +https://github.com/owncloud/web/pull/7735 \ No newline at end of file diff --git a/packages/web-app-files/src/components/FilesList/KeyboardActions.vue b/packages/web-app-files/src/components/FilesList/KeyboardActions.vue index 664513a4ec1..79fad16c00d 100644 --- a/packages/web-app-files/src/components/FilesList/KeyboardActions.vue +++ b/packages/web-app-files/src/components/FilesList/KeyboardActions.vue @@ -84,7 +84,11 @@ export default defineComponent({ areCustomKeyBindingsEnabled() { const activeElementTag = document.activeElement.tagName - if (['textarea', 'input', 'select'].includes(activeElementTag.toLowerCase())) { + const type = document.activeElement.getAttribute('type') + if ( + ['textarea', 'input', 'select'].includes(activeElementTag.toLowerCase()) && + type !== 'checkbox' + ) { return true } const closestSelectionEl = window.getSelection().focusNode as HTMLElement diff --git a/packages/web-app-files/src/helpers/resource/actions/transfer.ts b/packages/web-app-files/src/helpers/resource/actions/transfer.ts index de4da81e0c6..0ba0e2fd5a0 100644 --- a/packages/web-app-files/src/helpers/resource/actions/transfer.ts +++ b/packages/web-app-files/src/helpers/resource/actions/transfer.ts @@ -49,6 +49,9 @@ export class ResourceTransfer extends ConflictDialog { showResultMessage(errors, movedResources: Array, transferType: TransferType) { if (errors.length === 0) { const count = movedResources.length + if (count === 0) { + return + } const ntitle = transferType === TransferType.COPY ? this.$ngettext( diff --git a/packages/web-app-files/src/helpers/resource/actions/upload.ts b/packages/web-app-files/src/helpers/resource/actions/upload.ts index 4ff902c7cf9..a1055e163e1 100644 --- a/packages/web-app-files/src/helpers/resource/actions/upload.ts +++ b/packages/web-app-files/src/helpers/resource/actions/upload.ts @@ -111,11 +111,11 @@ export class ResourcesUpload extends ConflictDialog { }) continue } - + const conflictsLeft = allConflictsCount - count const resolvedConflict: ResolveConflict = await this.resolveFileExists( { name: conflict.name, isFolder } as Resource, - allConflictsCount - count, - false, + conflictsLeft, + conflictsLeft === 1, isFolder ) count++ diff --git a/packages/web-app-files/src/helpers/resource/conflictHandling/conflictDialog.ts b/packages/web-app-files/src/helpers/resource/conflictHandling/conflictDialog.ts index 8b7dd3e035e..7bed6ff143b 100644 --- a/packages/web-app-files/src/helpers/resource/conflictHandling/conflictDialog.ts +++ b/packages/web-app-files/src/helpers/resource/conflictHandling/conflictDialog.ts @@ -130,9 +130,8 @@ export class ConflictDialog { variation: 'danger', icon: 'alarm-warning', title: this.$gettext('Copy here?'), - message: this.$gettext( - 'Moving files from one space to another is not possible. Do you want to copy instead? Note: Links and shares of the original file are not copied.' - ), + customContent: + '

Moving files from one space to another is not possible. Do you want to copy instead?

Note: Links and shares of the original file are not copied.

', cancelText: this.$gettext('Cancel'), confirmText: this.$gettext('Copy here'), onCancel: () => { diff --git a/packages/web-runtime/src/App.vue b/packages/web-runtime/src/App.vue index 38132261b9e..6693fa1fec1 100644 --- a/packages/web-runtime/src/App.vue +++ b/packages/web-runtime/src/App.vue @@ -34,7 +34,11 @@ @confirm-secondary="modal.onConfirmSecondary" @mounted="focusModal" @beforeDestroy="focusModal" - /> + > + +