From a6976efe886939a6db2f53e9c7bd575513bfc57c Mon Sep 17 00:00:00 2001 From: ScharfViktor Date: Mon, 22 Nov 2021 17:24:56 +0100 Subject: [PATCH] fix after review add steps folder Shares fix expected failure --- .../expected-failures-with-oc10-server-oauth2-login.md | 2 +- .../expected-failures-with-ocis-server-ocis-storage.md | 2 +- .../acceptance/features/webUIFilesActionMenu/versions.feature | 3 ++- tests/acceptance/stepDefinitions/filesContext.js | 2 +- 4 files changed, 5 insertions(+), 4 deletions(-) diff --git a/tests/acceptance/expected-failures-with-oc10-server-oauth2-login.md b/tests/acceptance/expected-failures-with-oc10-server-oauth2-login.md index 66e23a8a1e8..6232f83541c 100644 --- a/tests/acceptance/expected-failures-with-oc10-server-oauth2-login.md +++ b/tests/acceptance/expected-failures-with-oc10-server-oauth2-login.md @@ -200,4 +200,4 @@ Other free text and markdown formatting can be used elsewhere in the document if - [webUISharingPermissionToRoot/shareFileWithMultipleUsers.feature:66](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingPermissionToRoot/shareFileWithMultipleUsers.feature#L66) ### [downloading an old version of a file returns 501](https://github.com/owncloud/ocis/issues/2261) -- [webUIFilesActionMenu/versions.feature:104](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIFilesActionMenu/versions.feature#L104) +- [webUIFilesActionMenu/versions.feature:94](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIFilesActionMenu/versions.feature#L94) diff --git a/tests/acceptance/expected-failures-with-ocis-server-ocis-storage.md b/tests/acceptance/expected-failures-with-ocis-server-ocis-storage.md index fd5ed3885a3..83956418eca 100644 --- a/tests/acceptance/expected-failures-with-ocis-server-ocis-storage.md +++ b/tests/acceptance/expected-failures-with-ocis-server-ocis-storage.md @@ -123,7 +123,7 @@ Other free text and markdown formatting can be used elsewhere in the document if - [webUIFilesActionMenu/versions.feature:63](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIFilesActionMenu/versions.feature#L63) ### [downloading an old version of a file returns 501](https://github.com/owncloud/ocis/issues/2261) -- [webUIFilesActionMenu/versions.feature:104](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIFilesActionMenu/versions.feature#L104) +- [webUIFilesActionMenu/versions.feature:94](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIFilesActionMenu/versions.feature#L94) ### [No occ command in ocis](https://github.com/owncloud/ocis/issues/1317) - [webUIRestrictSharing/restrictReSharing.feature:23](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIRestrictSharing/restrictReSharing.feature#L23) diff --git a/tests/acceptance/features/webUIFilesActionMenu/versions.feature b/tests/acceptance/features/webUIFilesActionMenu/versions.feature index 726146ded0d..4319dc3236e 100644 --- a/tests/acceptance/features/webUIFilesActionMenu/versions.feature +++ b/tests/acceptance/features/webUIFilesActionMenu/versions.feature @@ -76,6 +76,7 @@ Feature: Versions of a file @issue-ocis-2319 Scenario: change the file content of a received shared file Given the setting "shareapi_auto_accept_share" of app "core" has been set to "no" + And the administrator has set the default folder for received shares to "Shares" And user "Brian" has been created with default attributes and without skeleton files And user "Brian" has created folder "simple-folder" And user "Brian" has created file "simple-folder/lorem.txt" @@ -95,5 +96,5 @@ Feature: Versions of a file And user "Alice" has uploaded file with content "lorem content" to "lorem.txt" And user "Alice" has logged in using the webUI And the user browses to display the "versions" details of file "lorem.txt" - When the user downloads a file of a previous version using the webUI + When the user downloads a previous version of the file using the webUI Then as "Alice" the content of "lorem.txt" should be the same as the content of local file "lorem.txt" diff --git a/tests/acceptance/stepDefinitions/filesContext.js b/tests/acceptance/stepDefinitions/filesContext.js index 3fb362c521c..0a2cfbf4328 100644 --- a/tests/acceptance/stepDefinitions/filesContext.js +++ b/tests/acceptance/stepDefinitions/filesContext.js @@ -697,7 +697,7 @@ Then( } ) -When('the user downloads a file of a previous version using the webUI', function () { +When('the user downloads a previous version of the file using the webUI', function () { return client.page.FilesPageElement.versionsDialog().downloadFilePreviousVersion() })