From ab13bbc3fc098d3c13834ca6b5a4c85b08dacaa5 Mon Sep 17 00:00:00 2001
From: Benedikt Kulmann <benedikt@kulmann.biz>
Date: Thu, 26 Aug 2021 10:43:28 +0200
Subject: [PATCH] Switch tests to using the toggle button for the sidebar

---
 .../src/components/AppBar/ViewOptions.vue     |   1 +
 .../src/components/SideBar/FileInfo.vue       |   4 +-
 ...-failures-with-oc10-server-oauth2-login.md |   3 -
 ...-failures-with-ocis-server-ocis-storage.md |   6 -
 .../fileFolderActionMenu.feature              |   1 -
 .../webUIFilesDetails/fileDetails.feature     |   5 +-
 .../shareWithGroups.feature                   |   1 +
 .../publicLinkCreate.feature                  |   2 +-
 .../FilesPageElement/appSideBar.js            | 197 ++++++++------
 .../FilesPageElement/contextMenu.js           |  53 ++++
 .../FilesPageElement/fileActionsMenu.js       |  37 ++-
 .../pageObjects/FilesPageElement/filesList.js | 243 ++++++++----------
 .../pageObjects/FilesPageElement/filesRow.js  |  13 -
 .../FilesPageElement/mediaViewerPage.js       |   4 +-
 .../FilesPageElement/sharingDialog.js         |   1 -
 .../pageObjects/markdownEditorPage.js         |   4 +-
 tests/acceptance/pageObjects/personalPage.js  |  32 ---
 .../stepDefinitions/filesContext.js           |  49 +---
 .../stepDefinitions/privateLinksContext.js    |   4 +-
 .../stepDefinitions/publicLinkContext.js      |  49 +---
 .../stepDefinitions/sharingContext.js         |   6 +-
 21 files changed, 326 insertions(+), 389 deletions(-)
 create mode 100644 tests/acceptance/pageObjects/FilesPageElement/contextMenu.js

diff --git a/packages/web-app-files/src/components/AppBar/ViewOptions.vue b/packages/web-app-files/src/components/AppBar/ViewOptions.vue
index 1f459c9cd97..c73518597e3 100644
--- a/packages/web-app-files/src/components/AppBar/ViewOptions.vue
+++ b/packages/web-app-files/src/components/AppBar/ViewOptions.vue
@@ -14,6 +14,7 @@
       <oc-icon name="tune" size="medium" />
     </oc-button>
     <oc-button
+      id="files-toggle-sidebar"
       v-oc-tooltip="toggleSidebarButtonLabel"
       :aria-label="toggleSidebarButtonLabel"
       variation="passive"
diff --git a/packages/web-app-files/src/components/SideBar/FileInfo.vue b/packages/web-app-files/src/components/SideBar/FileInfo.vue
index f9bcedb10ff..3407f3fe65d 100644
--- a/packages/web-app-files/src/components/SideBar/FileInfo.vue
+++ b/packages/web-app-files/src/components/SideBar/FileInfo.vue
@@ -2,9 +2,7 @@
   <div class="file_info">
     <oc-icon :name="highlightedFile.icon" size="large" class="file_info__icon" />
     <div class="file_info__body">
-      <h2 tabindex="-1">
-        {{ highlightedFile.name }}
-      </h2>
+      <h2 tabindex="-1">{{ highlightedFile.name }}</h2>
       <div>
         <template v-if="highlightedFile.size > -1">
           {{ getResourceSize(highlightedFile.size) }},
diff --git a/tests/acceptance/expected-failures-with-oc10-server-oauth2-login.md b/tests/acceptance/expected-failures-with-oc10-server-oauth2-login.md
index e1267cb27e2..5524fd95c24 100644
--- a/tests/acceptance/expected-failures-with-oc10-server-oauth2-login.md
+++ b/tests/acceptance/expected-failures-with-oc10-server-oauth2-login.md
@@ -63,9 +63,6 @@ Other free text and markdown formatting can be used elsewhere in the document if
 -   [webUISharingNotifications/notificationLink.feature:18](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingNotifications/notificationLink.feature#L18)
 -   [webUISharingNotificationsToRoot/notificationLink.feature:17](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingNotificationsToRoot/notificationLink.feature#L17)
 
-### [Cannot determine share source path when sharing same name file from different path in shared-with pages](https://github.com/owncloud/web/issues/5302)
--   [webUISharingPublicBasic/publicLinkCreate.feature:88](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingPublicBasic/publicLinkCreate.feature#L88)
-
 ### [impossible to navigate into a folder in the trashbin](https://github.com/owncloud/web/issues/1725)
 -   [webUITrashbinDelete/trashbinDelete.feature:29](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUITrashbinDelete/trashbinDelete.feature#L29)
 
diff --git a/tests/acceptance/expected-failures-with-ocis-server-ocis-storage.md b/tests/acceptance/expected-failures-with-ocis-server-ocis-storage.md
index 7b4c406c34a..8eacff70a59 100644
--- a/tests/acceptance/expected-failures-with-ocis-server-ocis-storage.md
+++ b/tests/acceptance/expected-failures-with-ocis-server-ocis-storage.md
@@ -53,9 +53,6 @@ Other free text and markdown formatting can be used elsewhere in the document if
 -   [webUISharingInternalUsersShareWithPage/shareWithUsers.feature:118](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingInternalUsersShareWithPage/shareWithUsers.feature#L118)
 -   [webUIResharing1/reshareUsers.feature:230](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIResharing1/reshareUsers.feature#L230)
 
-### [delete pending share option is not available for sharee](https://github.com/owncloud/web/issues/5435)
--   [webUIDeleteFilesFolders/deleteFilesFolders.feature:235](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIDeleteFilesFolders/deleteFilesFolders.feature#L235)
-
 ### [file_path property is not unique for a share created with same resource name i.e already present in sharee](https://github.com/owncloud/ocis/issues/2249)
 -   [webUIRenameFiles/renameFiles.feature:205](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIRenameFiles/renameFiles.feature#L205)
 
@@ -429,9 +426,6 @@ Other free text and markdown formatting can be used elsewhere in the document if
 -   [webUISharingInternalGroupsEdgeCases/shareWithGroupsEdgeCases.feature:41](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingInternalGroupsEdgeCases/shareWithGroupsEdgeCases.feature#L41)
 -   [webUISharingInternalGroupsEdgeCases/shareWithGroupsEdgeCases.feature:42](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingInternalGroupsEdgeCases/shareWithGroupsEdgeCases.feature#L42)
 
-### [Cannot determine share source path when sharing same name file from different path in shared-with pages](https://github.com/owncloud/web/issues/5302)
--   [webUISharingPublicBasic/publicLinkCreate.feature:88](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingPublicBasic/publicLinkCreate.feature#L88)
-
 ### [impossible to navigate into a folder in the trashbin](https://github.com/owncloud/web/issues/1725)
 -   [webUITrashbinDelete/trashbinDelete.feature:29](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUITrashbinDelete/trashbinDelete.feature#L29)
 
diff --git a/tests/acceptance/features/webUIFilesActionMenu/fileFolderActionMenu.feature b/tests/acceptance/features/webUIFilesActionMenu/fileFolderActionMenu.feature
index 157c6aa5efe..d4e7af2f5db 100644
--- a/tests/acceptance/features/webUIFilesActionMenu/fileFolderActionMenu.feature
+++ b/tests/acceptance/features/webUIFilesActionMenu/fileFolderActionMenu.feature
@@ -14,7 +14,6 @@ Background: prepare user and files
   Scenario: observe different actions menu options on selecting different file types or folder
     Given user "Alice" has uploaded file with content "pdf file" to "lorem.pdf"
     And the user has reloaded the current page of the webUI
-    And the app-sidebar for file "lorem.txt" has been visible on the webUI
     When the user opens the actions sidebar panel of folder "simple-folder" on the webUI
     Then the app-sidebar for folder "simple-folder" should be visible on the webUI
     And only the following items with default items should be visible in the actions menu on the webUI
diff --git a/tests/acceptance/features/webUIFilesDetails/fileDetails.feature b/tests/acceptance/features/webUIFilesDetails/fileDetails.feature
index d5a000864d8..a8ea9027f37 100644
--- a/tests/acceptance/features/webUIFilesDetails/fileDetails.feature
+++ b/tests/acceptance/features/webUIFilesDetails/fileDetails.feature
@@ -77,7 +77,7 @@ Feature: User can open the details panel for any file or folder
     And user "Alice" has created a public link with following settings
       | path        | simple-folder         |
     And the user has browsed to the shared-via-link page
-    When the user opens the file action menu of folder "simple-folder" using the webUI
+    When the user opens the actions sidebar panel of file "simple-folder" on the webUI
     Then the thumbnail should be visible in the app-sidebar
     When the user switches to "people" panel in details panel using the webUI
     Then the "people" details panel should be visible
@@ -156,7 +156,7 @@ Feature: User can open the details panel for any file or folder
     When the user browses to the tags page
     And the user searches for tag "simple" using the webUI
     Then folder "simple-folder" should be listed on the webUI
-    When the user opens the file action menu of folder "simple-folder" using the webUI
+    When the user opens the actions sidebar panel of file "simple-folder" on the webUI
     Then the thumbnail should be visible in the app-sidebar
     When the user switches to "people" panel in details panel using the webUI
     Then the "people" details panel should be visible
@@ -180,6 +180,5 @@ Feature: User can open the details panel for any file or folder
   Scenario: the sidebar is invisible after opening the selected folder
     Given user "Alice" has created file "simple-folder"
     And the user has browsed to the files page
-    Given the app-sidebar for file "simple-folder" has been visible on the webUI
     When the user opens folder "simple-folder" using the webUI
     Then the app-sidebar should be invisible
diff --git a/tests/acceptance/features/webUISharingInternalGroupsSharingIndicator/shareWithGroups.feature b/tests/acceptance/features/webUISharingInternalGroupsSharingIndicator/shareWithGroups.feature
index 907c7759f42..8e83638e247 100644
--- a/tests/acceptance/features/webUISharingInternalGroupsSharingIndicator/shareWithGroups.feature
+++ b/tests/acceptance/features/webUISharingInternalGroupsSharingIndicator/shareWithGroups.feature
@@ -140,6 +140,7 @@ Feature: Sharing files and folders with internal groups
       | grp3      |
       | grp4      |
     And user "Alice" has created folder "simple-folder"
+    And user "Alice" has created folder "simple-folder2"
     And user "Alice" has created file "simple-folder/testimage.png"
     When user "Alice" has logged in using the webUI
     Then the following resources should not have share indicators on the webUI
diff --git a/tests/acceptance/features/webUISharingPublicBasic/publicLinkCreate.feature b/tests/acceptance/features/webUISharingPublicBasic/publicLinkCreate.feature
index 6fab6cf16d6..fd4e179628c 100644
--- a/tests/acceptance/features/webUISharingPublicBasic/publicLinkCreate.feature
+++ b/tests/acceptance/features/webUISharingPublicBasic/publicLinkCreate.feature
@@ -85,7 +85,7 @@ Feature: Create public link shares
     Then file "lorem.txt" should be listed on the webUI
 
   @issue-5302
-  Scenario: share two file with same name but different paths by public link
+  Scenario: share two files with same name but different paths by public link
     Given user "Alice" has created folder "simple-folder"
     And user "Alice" has created file "simple-folder/lorem.txt"
     And user "Alice" has created file "lorem.txt"
diff --git a/tests/acceptance/pageObjects/FilesPageElement/appSideBar.js b/tests/acceptance/pageObjects/FilesPageElement/appSideBar.js
index 232960b2000..0ce05b20ba3 100644
--- a/tests/acceptance/pageObjects/FilesPageElement/appSideBar.js
+++ b/tests/acceptance/pageObjects/FilesPageElement/appSideBar.js
@@ -1,29 +1,55 @@
 /* eslint-disable no-unused-expressions */
-const util = require('util')
+const path = require('path')
 const _ = require('lodash')
 const timeoutHelper = require('../../helpers/timeoutHelper')
 
 module.exports = {
   commands: {
     isThumbnailVisible: function() {
-      return this.waitForElementVisible(
-        this.api.page.personalPage().elements.sideBar
-      ).waitForElementVisible(this.elements.fileInfoIcon)
+      return this.waitForElementVisible('@sidebar').waitForElementVisible('@fileInfoIcon')
     },
-    closeSidebar: function(timeout = null) {
-      timeout = timeoutHelper.parseTimeout(timeout)
+    closeSidebarIfOpen: async function(timeout = 300) {
+      if (!(await this.isSideBarOpen(timeout))) {
+        return this.api.page.FilesPageElement.filesList()
+      }
+
       try {
-        this.click({
+        await this.click({
           selector: '@sidebarCloseBtn',
-          timeout: timeout
+          timeout: timeoutHelper.parseTimeout(timeout)
         })
       } catch (e) {
         // do nothing
       }
       return this.api.page.FilesPageElement.filesList()
     },
+    isSideBarOpen: async function(timeout = 500) {
+      const element = this.elements.sidebar
+      let isVisible = false
+      await this.isVisible(
+        {
+          locateStrategy: element.locateStrategy,
+          selector: element.selector,
+          timeout: timeoutHelper.parseTimeout(timeout)
+        },
+        result => {
+          isVisible = result.status === 0
+        }
+      )
+      return isVisible
+    },
+    isSideBarOpenForResource: async function(resource, timeout = 500) {
+      if (!(await this.isSideBarOpen(timeout))) {
+        return false
+      }
+      let resourceName
+      await this.getText('@fileInfoResourceName', function(result) {
+        resourceName = result.value
+      })
+      return resourceName === path.basename(resource)
+    },
     activatePanel: async function(item) {
-      await this.waitForElementVisible(this.api.page.personalPage().elements.sideBar)
+      const panelName = item === 'people' ? 'collaborators' : item
       const active = await this.isPanelActive(
         item,
         this.api.globals.waitForNegativeConditionTimeout
@@ -34,7 +60,7 @@ module.exports = {
         await this.isVisible(
           { locateStrategy: backBtn.locateStrategy, selector: backBtn.selector, timeout: 200 },
           result => {
-            backBtnVisible = result.status === 0
+            backBtnVisible = result.value === true
           }
         )
         if (backBtnVisible) {
@@ -43,30 +69,16 @@ module.exports = {
           })
           await this.waitForAnimationToFinish() // wait for sliding animation to the root panel
         }
-        this.useXpath()
-          .click(this.getXpathOfPanelSelect(item))
+        const menuItemElement = this.elements[panelName + 'PanelMenuItem']
+        await this.click({
+          locateStrategy: menuItemElement.locateStrategy,
+          selector: menuItemElement.selector
+        })
           .waitForAjaxCallsToStartAndFinish()
-          .useCss()
-        await this.waitForAnimationToFinish() // wait for sliding animation to the sub panel
+          .waitForAnimationToFinish() // wait for sliding animation to the sub panel
       }
-      const panelName = item === 'people' ? 'collaborators' : item
-      const element = this.elements[panelName + 'Panel']
-      const selector = element.selector
-      return this.waitForElementPresent(selector)
-    },
-    /**
-     * return the complete xpath of the link to the specified panel in the side-bar
-     * @param item
-     * @returns {string}
-     */
-    getXpathOfPanelSelect: function(item) {
-      return (
-        this.api.page.personalPage().elements.sideBar.selector +
-        util.format(
-          "//button[contains(translate(.,'ABCDEFGHJIKLMNOPQRSTUVWXYZ','abcdefghjiklmnopqrstuvwxyz'),'%s')]",
-          item
-        )
-      )
+      const panelElement = this.elements[panelName + 'Panel']
+      return await this.waitForElementPresent(panelElement.locateStrategy, panelElement.selector)
     },
     getVisibleAccordionItems: async function() {
       const items = []
@@ -81,19 +93,6 @@ module.exports = {
       }
       return items
     },
-    getVisibleActionsMenuItems: async function() {
-      const items = []
-      let elements
-      await this.api.elements('@panelActionsItems', function(result) {
-        elements = result.value
-      })
-      for (const { ELEMENT } of elements) {
-        await this.api.elementIdText(ELEMENT, function(result) {
-          items.push(result.value.toLowerCase())
-        })
-      }
-      return items
-    },
     getActionsMenuItemsExceptDefaults: async function() {
       const defaultItems = ['add to favorites', 'copy', 'move', 'rename', 'delete']
       const items = []
@@ -118,57 +117,66 @@ module.exports = {
     isPanelActive: async function(panelName, timeout = null) {
       panelName = panelName === 'people' ? 'collaborators' : panelName
       const element = this.elements[panelName + 'Panel']
-      const selector = element.selector + '.is-active'
       let isVisible = false
-      timeout = timeoutHelper.parseTimeout(timeout)
-      await this.isVisible({ locateStrategy: 'css selector', selector, timeout }, result => {
-        isVisible = result.value === true
-      })
+      await this.isVisible(
+        {
+          locateStrategy: element.locateStrategy,
+          selector: element.selector,
+          timeout: timeoutHelper.parseTimeout(timeout)
+        },
+        result => {
+          isVisible = result.value === true
+        }
+      )
       return isVisible
     },
     /**
-     * checks if the item with the given selector is present on the files-page-sidebar
+     * checks if it's possible to navigate into the given panel
      *
-     * @param {object} selector
+     * @param {string} panelName
+     * @param {number} timeout
      * @returns {Promise<boolean>}
      */
-    isPanelItemPresent: async function(selector) {
-      let isPresent = true
-      await this.useXpath()
-        .waitForElementVisible(this.api.page.personalPage().elements.sideBar) // sidebar is expected to be opened and visible
-        .api.elements(selector, result => {
-          isPresent = result.value.length > 0
-        })
-        .useCss()
-      return isPresent
+    isPanelSelectable: async function(panelName, timeout = 300) {
+      panelName = panelName === 'people' ? 'collaborators' : panelName
+      const element = this.elements[panelName + 'PanelMenuItem']
+      let isVisible = false
+      await this.isVisible(
+        {
+          locateStrategy: element.locateStrategy,
+          selector: element.selector,
+          timeout: timeoutHelper.parseTimeout(timeout)
+        },
+        result => {
+          isVisible = result.value === true
+        }
+      )
+      return isVisible
     },
-    /**
-     * @returns {Promise<boolean>}
-     */
-    isLinksPanelSelectPresent: function() {
-      return this.isPanelItemPresent(this.elements.linksPanelSelect)
+    isLinksPanelSelectable: async function() {
+      return await this.isPanelSelectable('links')
     },
-    /**
-     * @returns {Promise<boolean>}
-     */
-    isCollaboratorsAccordionItemPresent: function() {
-      return this.isPanelItemPresent(this.elements.collaboratorsPanel)
+    isSharingPanelSelectable: async function() {
+      return await this.isPanelSelectable('people')
     },
     markFavoriteSidebar: function() {
-      return this.useXpath()
-        .waitForElementVisible(this.api.page.personalPage().elements.sideBar)
+      return this.waitForElementVisible('@sidebar')
         .waitForElementVisible('@fileInfoFavoriteDimm')
         .click('@fileInfoFavorite')
         .waitForElementVisible('@fileInfoFavoriteShining')
     },
     unmarkFavoriteSidebar: function() {
-      return this.waitForElementVisible(this.api.page.personalPage().elements.sideBar)
+      return this.waitForElementVisible('@sidebar')
         .waitForElementVisible('@fileInfoFavoriteShining')
         .click('@fileInfoFavorite')
         .waitForElementVisible('@fileInfoFavoriteDimm')
     }
   },
   elements: {
+    sidebar: {
+      selector: '//*[@id="files-sidebar"]',
+      locateStrategy: 'xpath'
+    },
     fileInfoIcon: {
       selector: '.file_info .oc-icon'
     },
@@ -181,6 +189,9 @@ module.exports = {
     fileInfoFavoriteDimm: {
       selector: '.oc-star-dimm'
     },
+    fileInfoResourceName: {
+      selector: '.sidebar-panel.is-active h2'
+    },
     sidebarCloseBtn: {
       selector:
         '//div[contains(@id, "files-sidebar")]//div[contains(@class, "is-active")]//button[contains(@class, "header__close")]',
@@ -200,23 +211,45 @@ module.exports = {
         '//div[contains(@id, "files-sidebar")]//div[@class="sidebar-panel__navigation"]/button',
       locateStrategy: 'xpath'
     },
-    linksPanelSelect: {
-      selector: '#sidebar-panel-links-item-select'
-    },
     collaboratorsPanel: {
-      selector: '#sidebar-panel-sharing-item'
+      selector: '//*[@id="sidebar-panel-sharing-item"]',
+      locateStrategy: 'xpath'
+    },
+    collaboratorsPanelMenuItem: {
+      selector: '//button[@id="sidebar-panel-sharing-item-select"]',
+      locateStrategy: 'xpath'
     },
     linksPanel: {
-      selector: '#sidebar-panel-links-item'
+      selector: '//*[@id="sidebar-panel-links-item"]',
+      locateStrategy: 'xpath'
+    },
+    linksPanelMenuItem: {
+      selector: '//button[@id="sidebar-panel-links-item-select"]',
+      locateStrategy: 'xpath'
     },
     actionsPanel: {
-      selector: '#sidebar-panel-actions-item'
+      selector: '//*[@id="sidebar-panel-actions-item"]',
+      locateStrategy: 'xpath'
+    },
+    actionsPanelMenuItem: {
+      selector: '//button[@id="sidebar-panel-actions-item-select"]',
+      locateStrategy: 'xpath'
     },
     detailsPanel: {
-      selector: '#sidebar-panel-details-item'
+      selector: '//*[@id="sidebar-panel-details-item"]',
+      locateStrategy: 'xpath'
+    },
+    detailsPanelMenuItem: {
+      selector: '//button[@id="sidebar-panel-details-item-select"]',
+      locateStrategy: 'xpath'
     },
     versionsPanel: {
-      selector: '#sidebar-panel-versions-item'
+      selector: '//*[@id="sidebar-panel-versions-item"]',
+      locateStrategy: 'xpath'
+    },
+    versionsPanelMenuItem: {
+      selector: '//button[@id="sidebar-panel-versions-item-select"]',
+      locateStrategy: 'xpath'
     }
   }
 }
diff --git a/tests/acceptance/pageObjects/FilesPageElement/contextMenu.js b/tests/acceptance/pageObjects/FilesPageElement/contextMenu.js
new file mode 100644
index 00000000000..40df79e4f1b
--- /dev/null
+++ b/tests/acceptance/pageObjects/FilesPageElement/contextMenu.js
@@ -0,0 +1,53 @@
+module.exports = {
+  commands: {
+    /**
+     * @enum {string}
+     * @readonly
+     */
+    ContextMenuItem: Object.freeze({
+      showDetails: 'detailsButton',
+      showActions: 'actionsButton'
+    }),
+
+    /**
+     * @param {string} elementName the name of the element (mapped in `ContextMenuItem`)
+     */
+    clickMenuItem: async function(elementName) {
+      const element = this.elements[elementName]
+      await this.click(element.locateStrategy, element.selector)
+      return this
+    },
+
+    /**
+     * Clicks the menu item for showing details
+     *
+     * @returns {*}
+     */
+    showDetails: async function() {
+      await this.clickMenuItem(this.ContextMenuItem.showDetails)
+      await this.waitForAnimationToFinish() // wait for sidebar animation to finish
+      return this
+    },
+
+    /**
+     * Clicks the menu item for showing all actions
+     *
+     * @returns {*}
+     */
+    showActions: async function() {
+      await this.clickMenuItem(this.ContextMenuItem.showActions)
+      await this.waitForAnimationToFinish() // wait for sidebar animation to finish
+      return this
+    }
+  },
+  elements: {
+    detailsButton: {
+      selector: '//button[contains(@class, "oc-files-actions-show-details-trigger")]',
+      locateStrategy: 'xpath'
+    },
+    actionsButton: {
+      selector: '//button[contains(@class, "oc-files-actions-show-actions-trigger")]',
+      locateStrategy: 'xpath'
+    }
+  }
+}
diff --git a/tests/acceptance/pageObjects/FilesPageElement/fileActionsMenu.js b/tests/acceptance/pageObjects/FilesPageElement/fileActionsMenu.js
index 604dea26f98..620968a25aa 100644
--- a/tests/acceptance/pageObjects/FilesPageElement/fileActionsMenu.js
+++ b/tests/acceptance/pageObjects/FilesPageElement/fileActionsMenu.js
@@ -39,12 +39,9 @@ module.exports = {
      * @throws Error
      * @returns {*}
      */
-    performFileAction: function(action) {
+    performFileAction: async function(action) {
       const fileActionBtnSelectorXpath = this.getActionSelector(action)
-      return this.useXpath()
-        .waitForElementVisible(fileActionBtnSelectorXpath)
-        .click(fileActionBtnSelectorXpath)
-        .useCss()
+      return await this.click('xpath', fileActionBtnSelectorXpath)
     },
     /**
      * returns the disabled state of given action
@@ -67,7 +64,7 @@ module.exports = {
      * @returns {Promise<*>}
      */
     delete: async function() {
-      this.performFileAction(this.FileAction.delete)
+      await this.performFileAction(this.FileAction.delete)
       await this.api.page.FilesPageElement.filesList().confirmDeletion()
       return this
     },
@@ -77,8 +74,8 @@ module.exports = {
      * @return {*}
      */
     rename: async function(toName, expectToSucceed = true) {
+      await this.performFileAction(this.FileAction.rename)
       await this.useXpath()
-        .performFileAction(this.FileAction.rename)
         .waitForElementVisible('@dialog')
         .waitForAnimationToFinish() // wait for transition on the modal to finish
         .clearValue('@dialogInput')
@@ -96,33 +93,33 @@ module.exports = {
      * mark as favorite resource using fileActions 'favorite' button
      * @returns {Promise<*>}
      */
-    favorite: function() {
-      return this.performFileAction(this.FileAction.favorite)
+    favorite: async function() {
+      return await this.performFileAction(this.FileAction.favorite)
     },
     /**
      * unmark as favorite resource using fileActions 'favorite' button
      * @returns {Promise<*>}
      */
-    unmarkFavorite: function() {
-      return this.performFileAction(this.FileAction.unmarkFavorite)
+    unmarkFavorite: async function() {
+      return await this.performFileAction(this.FileAction.unmarkFavorite)
     },
     /**
      * @return {Promise<module.exports.commands>}
      */
-    restore: function() {
-      return this.performFileAction(this.FileAction.restore)
+    restore: async function() {
+      return await this.performFileAction(this.FileAction.restore)
     },
     /**
      * @return {Promise<module.exports.commands>}
      */
-    download: function() {
-      return this.performFileAction(this.FileAction.download)
+    download: async function() {
+      return await this.performFileAction(this.FileAction.download)
     },
     /**
      * @return {Promise<module.exports.commands>}
      */
     deleteResourceImmediately: async function() {
-      this.performFileAction(this.FileAction.delete)
+      await this.performFileAction(this.FileAction.delete)
       await this.api.page.FilesPageElement.filesList().confirmDeletion()
 
       return this
@@ -130,14 +127,14 @@ module.exports = {
     /**
      * Trigger the move of a resource via its file action
      */
-    move: function() {
-      return this.performFileAction(this.FileAction.move)
+    move: async function() {
+      return await this.performFileAction(this.FileAction.move)
     },
     /**
      * Trigger the copy of a resource via its file action
      */
-    copy: function() {
-      return this.performFileAction(this.FileAction.copy)
+    copy: async function() {
+      return await this.performFileAction(this.FileAction.copy)
     },
     /**
      * Trigger accepting a share
diff --git a/tests/acceptance/pageObjects/FilesPageElement/filesList.js b/tests/acceptance/pageObjects/FilesPageElement/filesList.js
index 70be3786302..26573d3e7eb 100644
--- a/tests/acceptance/pageObjects/FilesPageElement/filesList.js
+++ b/tests/acceptance/pageObjects/FilesPageElement/filesList.js
@@ -2,8 +2,10 @@ const util = require('util')
 const assert = require('assert')
 const xpathHelper = require('../../helpers/xpath')
 const { client } = require('nightwatch-api')
+const appSideBar = client.page.FilesPageElement.appSideBar()
+const contextMenu = client.page.FilesPageElement.contextMenu()
 const filesRow = client.page.FilesPageElement.filesRow()
-const filesActionsMenu = client.page.FilesPageElement.fileActionsMenu()
+const fileActionsMenu = client.page.FilesPageElement.fileActionsMenu()
 
 module.exports = {
   commands: {
@@ -12,10 +14,16 @@ module.exports = {
      * @return {Promise<*>}
      */
     openSharingDialog: async function(resource) {
-      const appSidebar = client.page.FilesPageElement.appSideBar()
-      await appSidebar.closeSidebar(500)
       await this.openSideBar(resource)
-      return client.page.FilesPageElement.appSideBar().activatePanel('people')
+      return await appSideBar.activatePanel('people')
+    },
+    /**
+     * @param {string} resource
+     * @return {Promise<*>}
+     */
+    openPublicLinkDialog: async function(resource) {
+      await this.openSideBar(resource)
+      return await appSideBar.activatePanel('links')
     },
     /**
      * @param {string} resource
@@ -31,23 +39,13 @@ module.exports = {
 
       return this.useXpath().waitForElementNotPresent(previewSelector)
     },
-    /**
-     * @param {string} fileName
-     * @return {Promise<*>}
-     */
-    openPublicLinkDialog: async function(fileName) {
-      await this.waitForFileVisible(fileName)
-      await this.openSideBar(fileName)
-      return client.page.FilesPageElement.appSideBar().activatePanel('links')
-    },
     /**
      * @param {string} resource
      * @return {Promise<module.exports.commands>}
      */
     deleteFile: async function(resource) {
-      await this.waitForFileVisible(resource)
-      await filesRow.openFileActionsMenu(resource)
-      await filesActionsMenu.delete()
+      await this.openFileActionsMenu(resource)
+      await fileActionsMenu.delete()
       return this
     },
     /**
@@ -55,9 +53,8 @@ module.exports = {
      * @returns {Promise<exports.commands>}
      */
     acceptShare: async function(resource) {
-      await this.waitForFileVisible(resource)
-      await filesRow.openFileActionsMenu(resource)
-      await filesActionsMenu.acceptShare()
+      await this.openFileActionsMenu(resource)
+      await fileActionsMenu.acceptShare()
       return this
     },
     /**
@@ -65,9 +62,8 @@ module.exports = {
      * @returns {Promise<exports.commands>}
      */
     declineShare: async function(resource) {
-      await this.waitForFileVisible(resource)
-      await filesRow.openFileActionsMenu(resource)
-      await filesActionsMenu.declineShare()
+      await this.openFileActionsMenu(resource)
+      await fileActionsMenu.declineShare()
       return this
     },
     /**
@@ -77,40 +73,36 @@ module.exports = {
      * @return {Promise<module.exports.commands>}
      */
     renameFile: async function(fromName, toName, expectToSucceed = true) {
-      await this.waitForFileVisible(fromName)
-      await filesRow.openFileActionsMenu(fromName)
-      await filesActionsMenu.rename(toName, expectToSucceed)
+      await this.openFileActionsMenu(fromName)
+      await fileActionsMenu.rename(toName, expectToSucceed)
       return this
     },
     /**
-     * @param {string} path
+     * @param {string} resource
      * @return {Promise<module.exports.commands>}
      */
-    markFavorite: async function(path) {
-      await this.waitForFileVisible(path)
-      await filesRow.openFileActionsMenu(path)
-      await filesActionsMenu.favorite()
+    markFavorite: async function(resource) {
+      await this.openFileActionsMenu(resource)
+      await fileActionsMenu.favorite()
       return this
     },
     /**
-     * @param {string} path
+     * @param {string} resource
      * @return {Promise<module.exports.commands>}
      */
-    unmarkFavorite: async function(path) {
-      await this.waitForFileVisible(path)
-      await filesRow.openFileActionsMenu(path)
-      await filesActionsMenu.unmarkFavorite()
+    unmarkFavorite: async function(resource) {
+      await this.openFileActionsMenu(resource)
+      await fileActionsMenu.unmarkFavorite()
       return this
     },
     /**
-     * @param {string} element
+     * @param {string} resource
      * @param {string} elementType
      * @return {Promise<module.exports.commands>}
      */
-    restoreFile: async function(element, elementType) {
-      await this.waitForFileWithPathVisible(element, elementType)
-      await filesRow.openFileActionsMenu(element, elementType)
-      await filesActionsMenu.restore()
+    restoreFile: async function(resource, elementType) {
+      await this.openFileActionsMenu(resource, elementType)
+      await fileActionsMenu.restore()
       return this
     },
     /**
@@ -118,9 +110,8 @@ module.exports = {
      * @return {Promise<module.exports.commands>}
      */
     deleteImmediately: async function(resource) {
-      await this.waitForFileVisible(resource)
-      await filesRow.openFileActionsMenu(resource)
-      await filesActionsMenu.deleteResourceImmediately(resource)
+      await this.openFileActionsMenu(resource)
+      await fileActionsMenu.deleteResourceImmediately(resource)
       return this
     },
     /**
@@ -129,18 +120,16 @@ module.exports = {
      * @return {Promise<boolean>}
      */
     isActionAttributeDisabled: async function(action, resource) {
-      await this.waitForFileVisible(resource)
-      await filesRow.openFileActionsMenu(resource)
-      return await filesActionsMenu.getActionDisabledAttr('delete')
+      await this.openFileActionsMenu(resource)
+      return await fileActionsMenu.getActionDisabledAttr('delete')
     },
     /**
      * @param {string} resource
      * @return {Promise<module.exports.commands>}
      */
     downloadFile: async function(resource) {
-      await this.waitForFileVisible(resource)
-      await filesRow.openFileActionsMenu(resource)
-      await filesActionsMenu.download()
+      await this.openFileActionsMenu(resource)
+      await fileActionsMenu.download()
       return this
     },
     /**
@@ -188,6 +177,36 @@ module.exports = {
       return this
     },
 
+    /**
+     * opens context menu for given resource
+     *
+     * @param {string} resource The name or path of a resource
+     * @param {string} elementType The resource type (file|folder|any)
+     * @returns {*}
+     */
+    openContextMenu: async function(resource, elementType = 'any') {
+      await this.waitForFileVisible(resource, elementType)
+      const selectorContextMenu =
+        this.getFileRowSelectorByFileName(resource, elementType) +
+        this.elements.contextBtnInFileRow.selector
+      await this.click('xpath', selectorContextMenu)
+      await this.waitForElementVisible('@contextMenuPanel')
+      return contextMenu
+    },
+
+    /**
+     * opens file-actions menu for given resource
+     *
+     * @param {string} resource The resource name
+     *
+     * @returns {*}
+     */
+    openFileActionsMenu: async function(resource) {
+      await this.openSideBar(resource)
+      await appSideBar.activatePanel('actions')
+      return fileActionsMenu
+    },
+
     /**
      * opens sidebar for given resource
      *
@@ -195,8 +214,31 @@ module.exports = {
      * @returns {*}
      */
     openSideBar: async function(resource) {
-      await this.clickDetailsInContextMenu(resource)
-      return this.api.page.FilesPageElement.appSideBar()
+      // nothing to do if already open for correct resource
+      if (await appSideBar.isSideBarOpenForResource(resource)) {
+        return appSideBar
+      }
+
+      // open the sidebar for the resource
+      await this.clickRow(resource)
+      await this.click('@btnToggleSideBar')
+      await this.waitForAnimationToFinish()
+      return appSideBar
+    },
+    /**
+     * @param {string} resource the file/folder to click
+     */
+    clickRow: async function(resource) {
+      await this.waitForFileVisible(resource)
+      await this.initAjaxCounters()
+        .useXpath()
+        // click in empty space in the tr using coordinates to avoid
+        // clicking on other elements that might be in the front
+        .clickElementAt(this.getFileRowSelectorByFileName(resource), 1, 1)
+        .waitForOutstandingAjaxCalls()
+        .useCss()
+
+      return this
     },
     /**
      *
@@ -218,20 +260,6 @@ module.exports = {
         .waitForOutstandingAjaxCalls()
         .useCss()
     },
-    /**
-     * @param {string} item the file/folder to click
-     */
-    clickDetailsInContextMenu: async function(item) {
-      await this.waitForFileVisible(item)
-      const selectorContextMenu =
-        this.getFileRowSelectorByFileName(item) + this.elements.contextBtnInFileRow.selector
-      await this.click({
-        selector: selectorContextMenu,
-        locateStrategy: 'xpath'
-      })
-      await this.click('@detailsBtnInContextMenu')
-      return this
-    },
 
     /**
      * Toggle enable or disable file/folder select checkbox
@@ -305,7 +333,7 @@ module.exports = {
     waitForFileVisible: async function(fileName, elementType = 'any') {
       const rowSelector = this.getFileRowSelectorByFileName(fileName, elementType)
 
-      await client.page.FilesPageElement.appSideBar().closeSidebar(500)
+      await appSideBar.closeSidebarIfOpen()
       let rowElementId = null
       await this.waitForElementPresent(
         { selector: rowSelector, locateStrategy: 'xpath' },
@@ -317,7 +345,6 @@ module.exports = {
       await this.api.elementIdLocation(rowElementId, result => {
         offset = result.value.y
       })
-
       let firstRowElementId = null
       await this.waitForElementPresent('@fileRow', result => {
         firstRowElementId = result.WebdriverElementId
@@ -327,29 +354,8 @@ module.exports = {
       })
 
       this.api.execute('scrollTo(0,' + offset + ')')
-
       return this
     },
-    /**
-     * Wait for a filerow with given path to be visible
-     * This only works in the favorites page as it uses the whole path of a file rather than just the name
-     * This does not works in cases where the path starts with a space (eg. "  ParentFolder/file.txt")
-     *
-     * @param {string} path
-     * @param {string} elementType
-     */
-    waitForFileWithPathVisible: async function(path, elementType = 'any') {
-      await client.page.FilesPageElement.appSideBar().closeSidebar(500)
-      const linkSelector = this.getFileLinkSelectorByFileName(path, elementType)
-      const rowSelector = this.getFileRowSelectorByFileName(path, elementType)
-      return this.useXpath()
-        .waitForElementVisible(rowSelector)
-        .waitForElementVisible(linkSelector)
-        .getText(linkSelector, function(result) {
-          assert.strictEqual(result.value.trim(), path, 'displayed file name not as expected')
-        })
-        .useCss()
-    },
     /**
      *
      * @param {string} fileName
@@ -538,24 +544,9 @@ module.exports = {
       return this.useCss()
     },
 
-    /**
-     * Returns original string with replaced target character
-     * @param   {string} string     String in which will be the target character replaced
-     * @param   {string} targetChar Target character which is to be replaced
-     * @param   {string} newChar    New character which will replace target character
-     * @returns {string}            String with replaced target character
-     */
-    replaceChar: function(string, targetChar, newChar) {
-      const regex = new RegExp(targetChar, 'g')
-      return string.replace(regex, newChar)
-    },
-
     useQuickAction: async function(resource, action) {
       action = action.replace(/\s/, '-')
-      const actionSelector = util.format(
-        this.api.page.FilesPageElement.filesRow().elements.quickAction.selector,
-        action
-      )
+      const actionSelector = util.format(filesRow.elements.quickAction.selector, action)
       const resourceRowSelector = this.getFileRowSelectorByFileName(resource)
 
       await this.waitForFileVisible(resource)
@@ -566,11 +557,9 @@ module.exports = {
     },
 
     moveResource: async function(resource, target) {
-      await this.waitForFileVisible(resource)
-
       // Trigger move
-      await filesRow.openFileActionsMenu(resource)
-      await filesActionsMenu.move()
+      await this.openFileActionsMenu(resource)
+      await fileActionsMenu.move()
 
       // Execute move
       await client.page.locationPicker().selectFolderAndConfirm(target)
@@ -578,19 +567,6 @@ module.exports = {
       return this
     },
 
-    attemptToMoveResource: async function(resource, target) {
-      await this.waitForFileVisible(resource)
-
-      // Trigger move
-      await filesRow.openFileActionsMenu(resource)
-      await filesActionsMenu.move()
-
-      // select folder
-      await client.page.locationPicker().selectFolder(target)
-
-      return this
-    },
-
     cancelResourceMoveOrCopyProgress: async function() {
       // cancel copy or move
       await this.waitForElementVisible(this.elements.cancelMoveCopyBtn.selector).click(
@@ -602,11 +578,9 @@ module.exports = {
     },
 
     copyResource: async function(resource, target) {
-      await this.waitForFileVisible(resource)
-
       // Trigger copy
-      await filesRow.openFileActionsMenu(resource)
-      await filesActionsMenu.copy()
+      await this.openFileActionsMenu(resource)
+      await fileActionsMenu.copy()
 
       // Execute copy
       await client.page.locationPicker().selectFolderAndConfirm(target)
@@ -614,18 +588,6 @@ module.exports = {
       return this
     },
 
-    attemptToCopyResource: async function(resource, target) {
-      await this.waitForFileVisible(resource)
-
-      // Trigger copy
-      await filesRow.openFileActionsMenu(resource)
-      await filesActionsMenu.copy()
-
-      // Execute copy
-      await client.page.locationPicker().selectFolder(target)
-
-      return this
-    },
     clickOnFileName: function(fileName) {
       const file = this.getFileLinkSelectorByFileName(fileName, 'file')
       return this.useXpath()
@@ -699,8 +661,8 @@ module.exports = {
       selector: '//button[contains(@class, "oc-table-files-btn-action-dropdown")]',
       locateStrategy: 'xpath'
     },
-    detailsBtnInContextMenu: {
-      selector: 'button.oc-files-actions-show-details-trigger'
+    contextMenuPanel: {
+      selector: 'ul#oc-files-context-actions'
     },
     /**
      * This element is concatenated as child of @see fileRowByResourcePath
@@ -765,6 +727,9 @@ module.exports = {
     },
     cancelMoveCopyBtn: {
       selector: '#location-picker-btn-cancel'
+    },
+    btnToggleSideBar: {
+      selector: '#files-toggle-sidebar'
     }
   }
 }
diff --git a/tests/acceptance/pageObjects/FilesPageElement/filesRow.js b/tests/acceptance/pageObjects/FilesPageElement/filesRow.js
index 8169b86ab76..2144550a082 100644
--- a/tests/acceptance/pageObjects/FilesPageElement/filesRow.js
+++ b/tests/acceptance/pageObjects/FilesPageElement/filesRow.js
@@ -3,19 +3,6 @@ const util = require('util')
 
 module.exports = {
   commands: {
-    /**
-     * opens file-actions menu for given resource
-     *
-     * @param {string} resource The resource name
-     * @param {string} elementType The resource type (file|folder)
-     *
-     * @returns {*}
-     */
-    openFileActionsMenu: async function(resource, elementType = 'any') {
-      await this.api.page.FilesPageElement.filesList().openSideBar(resource)
-      await this.api.page.FilesPageElement.appSideBar().activatePanel('actions')
-      return await this.api.page.FilesPageElement.fileActionsMenu()
-    },
     isQuickActionVisible: function(action) {
       action = action.replace(/\s/, '-')
       const actionSelector = util.format(this.elements.quickAction.selector, action)
diff --git a/tests/acceptance/pageObjects/FilesPageElement/mediaViewerPage.js b/tests/acceptance/pageObjects/FilesPageElement/mediaViewerPage.js
index d8180999e6a..da2d023106d 100644
--- a/tests/acceptance/pageObjects/FilesPageElement/mediaViewerPage.js
+++ b/tests/acceptance/pageObjects/FilesPageElement/mediaViewerPage.js
@@ -1,12 +1,12 @@
 const util = require('util')
 const { client } = require('nightwatch-api')
-const filesRow = client.page.FilesPageElement.filesRow()
+const filesList = client.page.FilesPageElement.filesList()
 const filesActionsMenu = client.page.FilesPageElement.fileActionsMenu()
 
 module.exports = {
   commands: {
     openMediaViewer: async function(fileName) {
-      await filesRow.openFileActionsMenu(fileName)
+      await filesList.openFileActionsMenu(fileName)
       await filesActionsMenu.mediaViewer()
 
       return this
diff --git a/tests/acceptance/pageObjects/FilesPageElement/sharingDialog.js b/tests/acceptance/pageObjects/FilesPageElement/sharingDialog.js
index 0d3ae855d85..aa33deb2dfc 100644
--- a/tests/acceptance/pageObjects/FilesPageElement/sharingDialog.js
+++ b/tests/acceptance/pageObjects/FilesPageElement/sharingDialog.js
@@ -144,7 +144,6 @@ module.exports = {
      * @param {string} permissions
      * @param {boolean} remote
      * @param {string} days
-     * @param {boolean} quickAction Asserts whether the quick actions should be used to open new collaborators panel
      *
      * @return void
      */
diff --git a/tests/acceptance/pageObjects/markdownEditorPage.js b/tests/acceptance/pageObjects/markdownEditorPage.js
index 1bbc9695653..233e15b1364 100644
--- a/tests/acceptance/pageObjects/markdownEditorPage.js
+++ b/tests/acceptance/pageObjects/markdownEditorPage.js
@@ -1,7 +1,6 @@
 const { client } = require('nightwatch-api')
 
 const filesList = client.page.FilesPageElement.filesList()
-const filesRow = client.page.FilesPageElement.filesRow()
 const filesActionsMenu = client.page.FilesPageElement.fileActionsMenu()
 
 module.exports = {
@@ -72,8 +71,7 @@ module.exports = {
      * @param {string} fileName
      */
     openMdEditorUsingActionMenu: async function(fileName) {
-      await filesList.waitForFileVisible(fileName)
-      await filesRow.openFileActionsMenu(fileName)
+      await filesList.openFileActionsMenu(fileName)
       await filesActionsMenu.markdownEditor()
       return this
     }
diff --git a/tests/acceptance/pageObjects/personalPage.js b/tests/acceptance/pageObjects/personalPage.js
index 87b23278d1e..c8fa4e9af17 100644
--- a/tests/acceptance/pageObjects/personalPage.js
+++ b/tests/acceptance/pageObjects/personalPage.js
@@ -1,6 +1,5 @@
 const util = require('util')
 const xpathHelper = require('../helpers/xpath')
-const timeoutHelper = require('../helpers/timeoutHelper')
 const { join, normalize } = require('../helpers/path')
 const { client } = require('nightwatch-api')
 
@@ -235,30 +234,6 @@ module.exports = {
         .waitForAjaxCallsToStartAndFinish()
         .waitForElementNotPresent('@dialog')
     },
-    isSidebarVisible: async function(timeout = null) {
-      let isVisible = false
-      timeout = timeoutHelper.parseTimeout(timeout)
-      await this.isVisible(
-        {
-          locateStrategy: this.elements.sideBar.locateStrategy,
-          selector: this.elements.sideBar.selector,
-          timeout: timeout
-        },
-        result => {
-          isVisible = result.status === 0
-        }
-      )
-      return isVisible
-    },
-    checkSidebarItem: function(resourceName) {
-      return this.getText('@sidebarItemName', function(itemName) {
-        this.assert.strictEqual(
-          itemName.value,
-          resourceName,
-          `In sidebar is different item - ${itemName.value}`
-        )
-      })
-    },
     confirmFileOverwrite: async function() {
       await this.waitForAnimationToFinish() // wait for transition on the modal to finish
         .click('@dialogConfirmBtnEnabled')
@@ -418,13 +393,6 @@ module.exports = {
     fileUploadProgress: {
       selector: '#files-upload-progress'
     },
-    sideBar: {
-      selector: '//div[contains(@id, "files-sidebar")]',
-      locateStrategy: 'xpath'
-    },
-    sidebarItemName: {
-      selector: '.sidebar-panel.is-active h2'
-    },
     dialog: {
       selector: '.oc-modal'
     },
diff --git a/tests/acceptance/stepDefinitions/filesContext.js b/tests/acceptance/stepDefinitions/filesContext.js
index 8e1d1679e18..417f592ec79 100644
--- a/tests/acceptance/stepDefinitions/filesContext.js
+++ b/tests/acceptance/stepDefinitions/filesContext.js
@@ -177,8 +177,8 @@ Given('the user has opened the share dialog for file/folder {string}', function(
   return client.page.FilesPageElement.filesList().openSharingDialog(fileName)
 })
 
-When('the user closes the app-sidebar using the webUI', function() {
-  return client.page.FilesPageElement.appSideBar().closeSidebar(100)
+When('the user closes the app-sidebar using the webUI', async function() {
+  return await client.page.FilesPageElement.appSideBar().closeSidebarIfOpen()
 })
 
 When('the user browses to folder {string} using the breadcrumb on the webUI', resource =>
@@ -422,7 +422,7 @@ Then('folder {string} should be listed on the webUI', folder => {
 })
 
 Then('file/folder with path {string} should be listed on the webUI', function(path) {
-  return client.page.FilesPageElement.filesList().waitForFileWithPathVisible(path)
+  return client.page.FilesPageElement.filesList().waitForFileVisible(path)
 })
 
 Then('the last uploaded folder should be listed on the webUI', async function() {
@@ -493,8 +493,7 @@ Then('the versions list for resource {string} should contain {int} entry/entries
 
   assert.strictEqual(count, expectedNumber)
 
-  client.page.FilesPageElement.appSideBar().closeSidebar(100)
-
+  await api.appSideBar().closeSidebarIfOpen()
   return this
 })
 
@@ -825,7 +824,7 @@ Then('file/folder {string} should be marked as favorite on the webUI', async fun
   await client.page.FilesPageElement.filesList().openSideBar(path)
 
   client.expect.element(selector).to.be.present
-  client.page.FilesPageElement.appSideBar().closeSidebar()
+  await client.page.FilesPageElement.appSideBar().closeSidebarIfOpen()
 
   return client
 })
@@ -835,7 +834,7 @@ Then('file/folder {string} should not be marked as favorite on the webUI', async
   await client.page.FilesPageElement.filesList().openSideBar(path)
 
   client.expect.element(selector).to.be.present
-  client.page.FilesPageElement.appSideBar().closeSidebar()
+  await client.page.FilesPageElement.appSideBar().closeSidebarIfOpen()
 
   return client
 })
@@ -848,14 +847,12 @@ Then(/the count of files and folders shown on the webUI should be (\d+)/, async
 })
 
 Then('the app-sidebar should be visible', async function() {
-  const visible = await client.page.personalPage().isSidebarVisible()
+  const visible = await client.page.FilesPageElement.appSideBar().isSideBarOpen()
   assert.strictEqual(visible, true, 'app-sidebar should be visible, but is not')
 })
 
 Then('the app-sidebar should be invisible', async function() {
-  const visible = await client.page
-    .personalPage()
-    .isSidebarVisible(client.globals.waitForNegativeConditionTimeout)
+  const visible = await client.page.FilesPageElement.appSideBar().isSideBarOpen()
   assert.strictEqual(visible, false, 'app-sidebar should be invisible, but is not')
 })
 
@@ -1020,16 +1017,15 @@ Then(
 When(
   'the user opens the actions sidebar panel of file/folder {string} on the webUI',
   async function(resource) {
-    await client.page.FilesPageElement.filesRow().openFileActionsMenu(resource)
+    await client.page.FilesPageElement.filesList().openFileActionsMenu(resource)
   }
 )
 
 Then('the app-sidebar for file/folder {string} should be visible on the webUI', async function(
   resource
 ) {
-  const visible = await client.page.personalPage().isSidebarVisible()
+  const visible = await client.page.FilesPageElement.appSideBar().isSideBarOpenForResource(resource)
   assert.strictEqual(visible, true, 'app-sidebar should be visible, but is not')
-  return client.page.personalPage().checkSidebarItem(resource)
 })
 
 Then('the thumbnail should be visible in the app-sidebar', function() {
@@ -1257,8 +1253,8 @@ Then('the move here file/folder button should be disabled', function() {
 When('the user selects move action for folder/file {string} using the webUI', async function(
   resource
 ) {
-  await client.page.FilesPageElement.filesRow().openFileActionsMenu(resource)
-  return client.page.FilesPageElement.fileActionsMenu().move()
+  await client.page.FilesPageElement.filesList().openFileActionsMenu(resource)
+  return await client.page.FilesPageElement.fileActionsMenu().move()
 })
 
 When('the user cancels the attempt to move/copy resources using the webUI', function() {
@@ -1311,18 +1307,11 @@ When('the user tries to copy file/folder {string} into folder {string} using the
     })
 })
 
-When('the user opens the file action menu of file/folder {string} using the webUI', async function(
-  resource
-) {
-  await client.page.FilesPageElement.filesList().waitForFileVisible(resource)
-  await client.page.FilesPageElement.filesRow().openFileActionsMenu(resource)
-})
-
 When('the user selects copy action for file/folder {string} using the webUI', async function(
   resource
 ) {
-  await client.page.FilesPageElement.filesRow().openFileActionsMenu(resource)
-  return client.page.FilesPageElement.fileActionsMenu().copy()
+  await client.page.FilesPageElement.filesList().openFileActionsMenu(resource)
+  return await client.page.FilesPageElement.fileActionsMenu().copy()
 })
 
 When(
@@ -1393,16 +1382,6 @@ Then(
   }
 )
 
-Given('the app-sidebar for file/folder {string} has been visible on the webUI', async function(
-  resource
-) {
-  await client.page.FilesPageElement.filesList().openSideBar(resource)
-
-  const visible = await client.page.personalPage().isSidebarVisible()
-  assert.strictEqual(visible, true, 'app-sidebar should be visible, but is not')
-  return client.page.personalPage().checkSidebarItem(resource)
-})
-
 Then(
   'only the following items with default items should be visible in the actions menu on the webUI',
   async function(table) {
diff --git a/tests/acceptance/stepDefinitions/privateLinksContext.js b/tests/acceptance/stepDefinitions/privateLinksContext.js
index cc3eb24e91b..cfdb5dd60cf 100644
--- a/tests/acceptance/stepDefinitions/privateLinksContext.js
+++ b/tests/acceptance/stepDefinitions/privateLinksContext.js
@@ -5,9 +5,7 @@ const webdav = require('../helpers/webdavHelper')
 When(
   'the user copies the private link of the file/folder/resource {string} using the webUI',
   async function(resource) {
-    await client.page.FilesPageElement.appSideBar()
-      .closeSidebar(100)
-      .openPublicLinkDialog(resource)
+    await client.page.FilesPageElement.filesList().openPublicLinkDialog(resource)
     return client.page.FilesPageElement.publicLinksDialog().copyPrivateLink()
   }
 )
diff --git a/tests/acceptance/stepDefinitions/publicLinkContext.js b/tests/acceptance/stepDefinitions/publicLinkContext.js
index 45fe7d5ad33..bde43c7dec0 100644
--- a/tests/acceptance/stepDefinitions/publicLinkContext.js
+++ b/tests/acceptance/stepDefinitions/publicLinkContext.js
@@ -10,9 +10,7 @@ const loginHelper = require('../helpers/loginHelper')
 When(
   'the user (tries to )create/creates a new public link for file/folder/resource {string} using the webUI',
   async function(resource) {
-    await client.page.FilesPageElement.appSideBar()
-      .closeSidebar(100)
-      .openPublicLinkDialog(resource)
+    await client.page.FilesPageElement.filesList().openPublicLinkDialog(resource)
     return client.page.FilesPageElement.publicLinksDialog().addNewLink()
   }
 )
@@ -21,9 +19,7 @@ When(
   'the user (tries to )create/creates a new public link for file/folder/resource {string} using the webUI with',
   async function(resource, settingsTable) {
     const settings = settingsTable.rowsHash()
-    await client.page.FilesPageElement.appSideBar()
-      .closeSidebar(100)
-      .openPublicLinkDialog(resource)
+    await client.page.FilesPageElement.filesList().openPublicLinkDialog(resource)
     return client.page.FilesPageElement.publicLinksDialog().addNewLink(settings)
   }
 )
@@ -31,9 +27,7 @@ When(
 When(
   'the user (tries to) create a new public link for file/folder/resource {string} which expires in {string} day/days using the webUI',
   async function(resource, days) {
-    await client.page.FilesPageElement.appSideBar()
-      .closeSidebar(100)
-      .openPublicLinkDialog(resource)
+    await client.page.FilesPageElement.filesList().openPublicLinkDialog(resource)
     return client.page.FilesPageElement.publicLinksDialog().setPublicLinkDate(days)
   }
 )
@@ -96,9 +90,7 @@ const loadPublicLinkWithPassword = async function(linkCreator, password, newSess
 
 const editPublicLink = async function(linkName, resource, dataTable) {
   const editData = dataTable.rowsHash()
-  await client.page.FilesPageElement.appSideBar()
-    .closeSidebar(100)
-    .openPublicLinkDialog(resource)
+  await client.page.FilesPageElement.filesList().openPublicLinkDialog(resource)
   await client.page.FilesPageElement.publicLinksDialog().editPublicLink(linkName, editData)
   return client.page.FilesPageElement.publicLinksDialog().savePublicLink()
 }
@@ -161,9 +153,7 @@ When(
   'the user edits the public link named {string} of file/folder/resource {string} changing following but not saving',
   async function(linkName, resource, dataTable) {
     const editData = dataTable.rowsHash()
-    await client.page.FilesPageElement.appSideBar()
-      .closeSidebar(100)
-      .openPublicLinkDialog(resource)
+    await client.page.FilesPageElement.filesList().openPublicLinkDialog(resource)
     return client.page.FilesPageElement.publicLinksDialog().editPublicLink(linkName, editData)
   }
 )
@@ -199,10 +189,7 @@ When(
   'the user tries to edit expiration of the public link named {string} of file {string} to past date {string}',
   async function(linkName, resource, pastDate) {
     const api = client.page.FilesPageElement
-    await api
-      .appSideBar()
-      .closeSidebar(100)
-      .openPublicLinkDialog(resource)
+    await api.filesList().openPublicLinkDialog(resource)
     await api.publicLinksDialog().clickLinkEditBtn(linkName)
     const value = sharingHelper.calculateDate(pastDate)
     const dateToSet = new Date(Date.parse(value))
@@ -217,9 +204,7 @@ When(
 When(
   'the user removes the public link named {string} of file/folder/resource {string} using the webUI',
   async function(linkName, resource) {
-    await client.page.FilesPageElement.appSideBar()
-      .closeSidebar(100)
-      .openPublicLinkDialog(resource)
+    await client.page.FilesPageElement.filesList().openPublicLinkDialog(resource)
     return client.page.FilesPageElement.publicLinksDialog().removePublicLink(linkName)
   }
 )
@@ -227,9 +212,7 @@ When(
 When(
   'the user cancels remove the public link named {string} of file/folder/resource {string} using the webUI',
   async function(linkName, resource) {
-    await client.page.FilesPageElement.appSideBar()
-      .closeSidebar(100)
-      .openPublicLinkDialog(resource)
+    await client.page.FilesPageElement.filesList().openPublicLinkDialog(resource)
     return client.page.FilesPageElement.publicLinksDialog().cancelRemovePublicLink(linkName)
   }
 )
@@ -248,9 +231,7 @@ Then(
 )
 
 async function findMatchingPublicLinkByName(name, role, resource, via = null) {
-  await client.page.FilesPageElement.appSideBar()
-    .closeSidebar(100)
-    .openPublicLinkDialog(resource)
+  await client.page.FilesPageElement.filesList().openPublicLinkDialog(resource)
 
   const shares = await client.page.FilesPageElement.publicLinksDialog().getPublicLinkList()
 
@@ -291,16 +272,10 @@ Then(
   }
 )
 
-When('the user closes the public link details sidebar', function() {
-  return client.page.FilesPageElement.appSideBar().closeSidebar(100)
-})
-
 When(
   'the user copies the url of public link named {string} of file/folder/resource {string} using the webUI',
   async function(linkName, resource) {
-    await client.page.FilesPageElement.appSideBar()
-      .closeSidebar(100)
-      .openPublicLinkDialog(resource)
+    await client.page.FilesPageElement.filesList().openPublicLinkDialog(resource)
     return client.page.FilesPageElement.publicLinksDialog().copyPublicLinkURI(linkName)
   }
 )
@@ -315,9 +290,7 @@ Then(
   'a public link with the last created link share token as name should be listed for resource {string} on the webUI',
   async function(resource) {
     const lastShare = await sharingHelper.fetchLastPublicLinkShare(client.globals.currentUser)
-    await client.page.FilesPageElement.appSideBar()
-      .closeSidebar(100)
-      .openPublicLinkDialog(resource)
+    await client.page.FilesPageElement.filesList().openPublicLinkDialog(resource)
     const shares = await client.page.FilesPageElement.publicLinksDialog().getPublicLinkList()
     const share = shares.find(link => link.name === lastShare.token)
     return assert.ok(share.name.length > 0)
diff --git a/tests/acceptance/stepDefinitions/sharingContext.js b/tests/acceptance/stepDefinitions/sharingContext.js
index 4c0c616048b..23aa47fdab1 100644
--- a/tests/acceptance/stepDefinitions/sharingContext.js
+++ b/tests/acceptance/stepDefinitions/sharingContext.js
@@ -41,8 +41,6 @@ const userSharesFileOrFolderWithUserOrGroup = async function(
     await api.filesList().openSharingDialog(file)
   }
 
-  await api.sharingDialog().waitForAnimationToFinish()
-
   return api
     .sharingDialog()
     .shareWithUserOrGroup(sharee, shareWithGroup, role, permissions, remote, null)
@@ -690,9 +688,9 @@ Then('it should not be possible to share file/folder {string} using the webUI',
   const state = await filesList.isSharingButtonPresent(resource)
   assert.ok(!state, `Error: Sharing button for resource ${resource} is not in disabled state`)
   await filesList.openSideBar(resource)
-  const linkItemState = await appSideBar.isLinksPanelSelectPresent()
+  const linkItemState = await appSideBar.isLinksPanelSelectable()
   assert.ok(!linkItemState, `Error: Sidebar 'Links' panel for resource ${resource} is present`)
-  const collaboratorsItemState = await appSideBar.isCollaboratorsAccordionItemPresent()
+  const collaboratorsItemState = await appSideBar.isSharingPanelSelectable()
   assert.ok(
     !collaboratorsItemState,
     `Error: Sidebar 'People' panel for resource ${resource} is present`