Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove vue2-dropzone package #1953

Closed
LukasHirt opened this issue Sep 11, 2019 · 6 comments
Closed

Remove vue2-dropzone package #1953

LukasHirt opened this issue Sep 11, 2019 · 6 comments

Comments

@LukasHirt
Copy link
Collaborator

Description

Remove vue2-dropzone package from files app since we don't really use it's features and what we use from it can be replaced with events.

@LukasHirt LukasHirt added this to the backlog milestone Sep 11, 2019
@PVince81 PVince81 added the Topic:good-first-issue beginner friendly task label Sep 12, 2019
@pascalwengerter
Copy link
Contributor

@LukasHirt did you re-introduce vue2-dropzone in the evil PR (or decided to keep it, after all)?

@LukasHirt
Copy link
Collaborator Author

It was never removed, was it?

@pascalwengerter
Copy link
Contributor

Nope. My understanding was that at some point in history it might've been possible (after #2239 was merged) but it seems to be a valid part of the application (again)? Then we can possibly close the issue

@LukasHirt
Copy link
Collaborator Author

When implementing the dropzone originally we used the mentioned lib. We are using only a super limited set of features that are easily replaced with native events so we do not need that lib. This ticket is not about removing the dropzone itself. Only the lib under the hood should be removed and replaced with those native events...

@pascalwengerter
Copy link
Contributor

I see, thanks for clarification!

@pascalwengerter
Copy link
Contributor

Closing in favor of #6019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants