-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Public link access for file editor apps #1996
Comments
Markdown app doesn't work, but likely for different reasons: Raised here: #2076 |
Would be nice to have an Opportunity to do this. If it possible a short example would be great. |
Maybe @LukasHirt can provide some hints? |
This would need two features in Web:
Both should be quite straight forward to implement. What I am a bit uncertain about is the server part. Currently, we're redirecting the link in oC10 to the new WebUI. I need to check if the redirect could already handle some arbitrary params or if it would need to be extended which would then mean the need for a new release of the server. |
I think there's a misunderstanding. If I understand correctly, this ticket is about making viewers/editors (e.g., media viewer or a text editor) available when accessing files via a public link. Currently those are only available for logged in users. |
@pmaier1 I think Yes and No, It depends on your application model. In the first place it would be awesome (as you mentioned) to be able to open publicly shared files with an editor/viewer by link. For more advanced Applications it is perhaps necessary to route the request to an Service outside of Ocis/oC10 (Extension). |
Ah, okay. Sorry for the confusion. I remember we once discussed opening the files directly in those editors and my brain merged it into this ticket 🙈 Then we'd have to first check and potentially adjust the sdk to use the correct headers in such case and then just enable it in editors (there is a check for the route so we'd only add public as enabled). I'll check the sdk and will see how much would need to be changed there. |
Provide public link access for file editor apps.
It means the editor should open for files accessible through public links. (also single file shares!)
I suggest we do this for the text editor and/or markdown app to figure out the missing pieces and also to provide an example app for other file editor app developers.
@pmaier1 @LukasHirt
The text was updated successfully, but these errors were encountered: