Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public link access for file editor apps #1996

Closed
PVince81 opened this issue Sep 17, 2019 · 8 comments
Closed

Public link access for file editor apps #1996

PVince81 opened this issue Sep 17, 2019 · 8 comments
Labels
Milestone

Comments

@PVince81
Copy link
Contributor

Provide public link access for file editor apps.

It means the editor should open for files accessible through public links. (also single file shares!)

I suggest we do this for the text editor and/or markdown app to figure out the missing pieces and also to provide an example app for other file editor app developers.

@pmaier1 @LukasHirt

@PVince81 PVince81 modified the milestones: backlog, Milestone 1: Phoenix for users Sep 24, 2019
@PVince81
Copy link
Contributor Author

PVince81 commented Sep 26, 2019

Markdown app doesn't work, but likely for different reasons:
image

Raised here: #2076

@MonksterFX
Copy link

Would be nice to have an Opportunity to do this. If it possible a short example would be great.

@pmaier1
Copy link
Contributor

pmaier1 commented Jan 11, 2021

Maybe @LukasHirt can provide some hints?

@LukasHirt
Copy link
Collaborator

LukasHirt commented Jan 11, 2021

This would need two features in Web:

  • Offer a select for which app should be used. Could be a dropdown in the create link dialogue
  • Handle the param in the URL when opening the link to open the correct app

Both should be quite straight forward to implement. What I am a bit uncertain about is the server part. Currently, we're redirecting the link in oC10 to the new WebUI. I need to check if the redirect could already handle some arbitrary params or if it would need to be extended which would then mean the need for a new release of the server.

@pmaier1
Copy link
Contributor

pmaier1 commented Jan 11, 2021

This would need two features in Web:

I think there's a misunderstanding. If I understand correctly, this ticket is about making viewers/editors (e.g., media viewer or a text editor) available when accessing files via a public link. Currently those are only available for logged in users.

@MonksterFX
Copy link

MonksterFX commented Jan 11, 2021

@pmaier1 I think Yes and No, It depends on your application model. In the first place it would be awesome (as you mentioned) to be able to open publicly shared files with an editor/viewer by link.

For more advanced Applications it is perhaps necessary to route the request to an Service outside of Ocis/oC10 (Extension).

@LukasHirt
Copy link
Collaborator

Ah, okay. Sorry for the confusion. I remember we once discussed opening the files directly in those editors and my brain merged it into this ticket 🙈

Then we'd have to first check and potentially adjust the sdk to use the correct headers in such case and then just enable it in editors (there is a check for the route so we'd only add public as enabled). I'll check the sdk and will see how much would need to be changed there.

@kulmann
Copy link
Contributor

kulmann commented Apr 11, 2022

This has recently been done in #6667
Also, in #6763 the (originally) markdown editor has been renamed to text editor.
Closing this ticket as done ✅

@kulmann kulmann closed this as completed Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants