Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media viewer preloading #2052

Closed
PVince81 opened this issue Sep 24, 2019 · 6 comments · Fixed by #8051
Closed

Media viewer preloading #2052

PVince81 opened this issue Sep 24, 2019 · 6 comments · Fixed by #8051

Comments

@PVince81
Copy link
Contributor

The current media viewer implementation is missing image preloading.

When clicking on the icon for going to the next picture, the current picture fades out and I need to wait a few seconds for the new one to load. This is a rather frustrating experience.
The OC 10 media viewer was smoother thanks to preloading.

@felixheidecke

@PVince81 PVince81 added this to the Milestone 1: Phoenix for users milestone Sep 24, 2019
@PVince81 PVince81 mentioned this issue Sep 24, 2019
2 tasks
@kulmann kulmann removed this from the Milestone 1: Phoenix for users milestone Oct 27, 2022
@kulmann
Copy link
Contributor

kulmann commented Nov 16, 2022

This is a good idea for images. For audio and video formats I'd like to keep the current behaviour of loading the file when playback gets triggered.

@kulmann kulmann mentioned this issue Nov 16, 2022
2 tasks
@AlexAndBear
Copy link
Contributor

@kulmann should there be a limitation, like only preload the first 200 images ?

@dschmidt
Copy link
Member

dschmidt commented Dec 1, 2022

@kulmann should there be a limitation, like only preload the first 200 images ?

I'm not @kulmann :-P but imho: YES YES YES YES YES and YES. Imagine opening a huge phone backup folder with thousands of images hammering the backend with thousands of requests and caching the results in memory, I doubt this gives a better feel of performance than right now 😅

I would argue instead of loading "the first 200 images" we should rather load the previous and next x pictures when the active file changes (where probably something like 10 is more than enough)

@kulmann
Copy link
Contributor

kulmann commented Dec 1, 2022

@kulmann should there be a limitation, like only preload the first 200 images ?

I'd say for the currently shown image only preload the previous 10 and next 10 images (which needs to respect the currently active sorting of the files of course). If you navigate to the next image, preload one more image (the 11th, which now became the 10th).

@AlexAndBear
Copy link
Contributor

if the next file is a video file should I still try to preload the next image?

@kulmann
Copy link
Contributor

kulmann commented Dec 5, 2022

if the next file is a video file should I still try to preload the next image?

I'd say

  • only preload the next x files
  • only actually preload if the file is an image :trollface:

=> preload filecount = 5
=> if the next files are 1. image, 2. video, 3. image, 4. image, 5. audio, 6. image, 7. image
=> preload 1, 3, 4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants