Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QA] Media player is not used for mp3 files #5275

Closed
jnweiger opened this issue Dec 15, 2020 · 5 comments
Closed

[QA] Media player is not used for mp3 files #5275

jnweiger opened this issue Dec 15, 2020 · 5 comments

Comments

@jnweiger
Copy link
Contributor

Deployed ocis master 2020-12-15 13:00h via hetzner-deploy/make_ocis_test.sh -> ocis/deployments/examples/ocis_traefik/

Expected behaviour: As it is technically able to play mp3, that mime type should also be registered with the media player.

@individual-it
Copy link
Member

individual-it commented Dec 21, 2020

  • ToDo QA-team: check what the current state is of the media viewer tests (I believe we created some basic ones) and add this case

@swoichha
Copy link
Contributor

swoichha commented Dec 22, 2020

Also, there is no Open in Mediaviewer in file actions menu for mp3 files

media-viewer.mp4

@kulmann
Copy link
Contributor

kulmann commented Dec 22, 2020

You can find the mimetypes file extensions that the mediaviewer currently accepts here:

extensions: [

@kulmann
Copy link
Contributor

kulmann commented Dec 22, 2020

The question whether or not the Mediaviewer should be used for playing audio files at all still needs concepting. In my opinion the Mediaviewer in its current state is not a good fit for that. Even for videos it is not a good solution - only serves as a rough preview. No decent media controls, etc.

@swoichha swoichha self-assigned this Dec 22, 2020
@swoichha swoichha removed their assignment Dec 30, 2020
@refs refs changed the title [QA] media player is not used for mp3 files [QA] Media player is not used for mp3 files Jan 13, 2021
@pascalwengerter pascalwengerter transferred this issue from owncloud/ocis Jun 15, 2021
@pascalwengerter
Copy link
Contributor

Has been resolved via #6514 thanks to @kulmann 🎶

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants