Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 4.4.0 #5943

Closed
22 tasks done
kulmann opened this issue Oct 25, 2021 · 5 comments
Closed
22 tasks done

Release 4.4.0 #5943

kulmann opened this issue Oct 25, 2021 · 5 comments

Comments

@kulmann
Copy link
Contributor

kulmann commented Oct 25, 2021

Release checklist

  • pin release issue @kulmann
  • prepare release rc: @kulmann
    • create a branch release-4.4.0 @kulmann
    • update the version in packages/web-integration-oc10/appinfo/info.xml @kulmann
    • update the version in package.json @kulmann
    • update the version in sonar-project.properties @kulmann
    • move changelog/unreleased/* to changelog/VERSION_YYYY-MM-DD @kulmann
    • update the ocis commit id in .drone.env to the most recent one from ocis master (i.e. let the web UI tests run on most recent ocis master) @kulmann
    • commit, push and create draft PR for this branch @kulmann
  • create pre release tag v4.4.0-rc1 from the release branch @kulmann
  • smoke test
  • if needed, fix issues or write down known issues
  • update YYYY-MM-DD to current date in changelog/VERSION_YYYY-MM-DD
  • Make sure translations are up to date
  • repeat above steps if a new rc is needed
  • Run translations sync job once again
  • go to the releases section and click Draft a new Release. Use v4.4.0 as a tag (the v prefix is important) and 4.4.0 as name and publish it
  • ping in internal #btr channel to create a signed release and ask them to upload it to a) the github release page, b) marketplace.owncloud.com, c) portal.owncloud.com, d) customer.owncloud.com
  • merge release branch back to master (CI must be green)
@kulmann
Copy link
Contributor Author

kulmann commented Oct 26, 2021

Smoke test rc1 against oc10 app

  • ✔️ as gunter - upload arch/mips folder from linux kernel (1945 files)

    • progress bar is not sticky
    • expanding the upload progress section slows down browser & upload time significantly
  • ✔️ as gunter - share the folder to alice as viewer
    - sharing is not possible before the upload finished (user invite field doesn't stay focussed)

  • ✔️ as alice - share is already accepted. declining and accepting again works as expected (buttons in shared with me table, batch action, right sidebar)

  • ✔️ as alice - try do delete file from shared folder
    - individual delete action not visible, good
    - batch delete action not visible, good
    - context menu action not visible, good

  • ✔️ as alice - try to add file
    - not possible (which is expected) but drag & drop upload didn't handle it. opened file in new tab instead.

  • ❌ as alice - copy 16 folders from share to home

    • no visible feedback that it's in progress
    • UI still weirdly usable, ended up in an active upload drop zone. folder listing after copy shows ? as folder size on some of the copied folders.
  • ✔️ as gunter - add new file to share

  • ✔️ as alice - receive new file in existing share

  • ✔️ as gunter - unshare folder from shared with others

  • ✔️ as alice - try to revisit old share

    • shows resource not found upon page reload, good
    • going back to All files or Shared with me doesn't list the share anymore, good
  • ✔️ as gunter - share folder with alice again, but as editor

  • ✔️ as alice - rename file

    • via right sidebar, works, good
    • via context menu, works, good
  • ✔️ as gunter - add file

  • ✔️ as alice - delete file

    • via right sidebar, works, good
    • via context menu, works, good
  • ✔️ as alice - create public link on any folder

  • ✔️ as alice delete file and recover it

  • ✔️ as alice create version of textfile

  • ✔️ as alice view version history of text file

  • ✔️ as alice download newest version of text file

  • ✔️ download older version of text file

  • ✔️ restore older version of text file

    • no visible feedback about the success
    • preview is not updated
  • ✔️ as alice - upload avatar in classic UI

    • login as dave, having a share with alice
    • shared with others page loads and shows avatars
  • ✔️ as alice, move a file into subfolder via drag and drop

  • ✔️ as alice, navigate into a folder, open right sidebar without selection, share current folder with gunter

Findings from smoke testing:

  • mouse drop event doesn't trigger the upload dropzone anymore. Instead the dropped file opens in a new tab and the web ui shows a successfully moved 0 items message (unchanged, will be fixed in next release). Drag & drop for move kills drag & drop for upload #5808
  • coming back from mediaviewer doesn't highlight the selected file anymore in the files list (unchanged)

@pascalwengerter
Copy link
Contributor

Smoke test standalone against oc10

  • ❌ as admin - upload 20.000 files in 7 folders to home

    • browser gets slowed down less than expected
    • upload freezes halfway through, doesn't get picked up again. Not yet uploaded files are lost upon page reload
  • ✔️ as admin - share the folder as viewer

  • ✔️ as alice - share is already accepted. declining and accepting again works as expected (buttons in shared with me table, batch action, right sidebar)

  • ✔️ as alice - try do delete file from shared folder
    - individual delete action not visible, good
    - batch delete action not visible, good
    - context menu action not visible, good

  • ✔️ as alice - try to add file
    - not possible (which is expected) but drag & drop doesnt work, which is acceptable

  • ✔️ as alice - copy 100 files from share to home
    move from shared folder makes browser lag alot sometimes freeze

  • ✔️ as admin - add new file to share

  • ✔️ as alice - receive new file in existing share

  • ✔️ as admin - unshare folder from shared with others

  • ✔️ as alice - try to revisit old share

    • shows resource not found upon page reload, good
    • going back to All files or Shared with me doesn't list the share anymore, good
  • ✔️ as admin - share folder with alice again, but as editor

  • ✔️ as alice - rename file

    • via right sidebar, works, good
    • via context menu, works, good
  • ✔️ as admin - add file

  • ✔️ as alice - delete file

    • via right sidebar, works, good
    • via context menu, works, good
  • ✔️ as alice - create public link on any folder

  • ✔️ as alice delete file and recover it

  • ✔️ as alice create version of textfile

  • ✔️ as alice view version history of text file

  • ✔️ as alice download newest version of text file

  • ✔️ download older version of text file

  • ✔️ restore older version of text file

    • no visible feedback about the success
    • preview is updated
  • ✔️ as alice - upload avatar in classic UI

    • login as admin, having a share with alice
    • shared with others page loads and shows avatars
  • ✔️ as alice, move a file into subfolder via drag and drop

  • ✔️ as alice, navigate into a folder, open right sidebar without selection, share current folder with admin

@ScharfViktor
Copy link
Contributor

SmokeTest against ocis

branch: v4.4.0-rc1

Case 1: admin share folder(with file) to marie:

Admin:

  • upload big file 30gb - slow, 6.4Gb for 10min
  • upload folder with 848 files. - uploaded only 465 files for 10 min.
  • Check pagination, count items per page.
  • upload folder(drag folder) "folder_to_share" with file.pdf
  • share folder "folder_to_share" to marie with edit right

Marie:

  • accept "folder_to_share"
  • rename "folder_to_share" (?admin don't see)
  • upload new file "file.txt" to "folder_to_share" (admin see new file)
  • rename file.pdf (use rigth click) (admin see that file changed name)
  • try to move "folder_to_share" to "/" (400)
  • copy "folder_to_share" to "/"

Admin:

  • add new file.jpeg to "folder_to_share" (marie can see file without access)
  • move file.pdf to "/" (marie can not see file.pdf)
  • add new "file.txt" create new version. (marie can see new version)

Marie:

  • can download both versions (!error 501)
  • restore old version

Admin:

  • change share "folder_to_share" from "edit" to "viewer" (marie cannot rename/move/delete/download file in folder and cannot create new document in the folder)

Marie:

  • decline folder (but folder exist in Shares - bug) - existing bug

Admin:

  • delete folder "folder_to_share" (marie: folder Shares empty)

Case 2: admin share file to marie:

Admin:

  • upload file.jpeg
  • share file.jpeg to marie with rigth viewer (use main menu. find marie by email [email protected])

Marie:

  • accept file (marie can open/download/copy file but cannot delete/move/rename)
  • copy file to "/"
  • open file in Mediaviewer
  • download file

Admin:

  • change share "file.jpeg" from "viewer" to "edit"(marie can open/download/copy/rename file)

Marie:

  • rename file (admin don't see)

Admin:

  • unshare "file.jpeg" (marie cannot see "file.jpeg" in Shares/Shared for me but see the copied file)

Case 3: admin create public links to folder

Admin:

  • create folder "for upload"
  • add link with name "to_upload" with role "Uploader" with pass and expiration date
  • open link (can only upload)
  • upload file (admin can see new file)
  • refresh page(page is empty)
  • change share "for upload" from "Uploader" to "edit"
  • open old link (it work as upload)
  • open new link (can open/download/copy/rename/move files)
  • admin add new file to "for upload"
  • refresh link (file exist)
  • admin change pass (refresh link)

Case 4: admin create link to file

Admin:

  • create file png
  • add link with main menu
  • open link(can open, download, see)
  • change link, add pass
  • refresh page (input pass)
  • delete link
  • refresh page (resourse not found)
  • delete file
  • restore
  • delete
  • Empty trash

Case 5: create new user:

Admin:

  • create new account "tom"

Tom:

  • go to account
  • change language

Admin:

  • block user (Login Error access denied)
  • delete user (Logon failed)
  • logout

No remarks blocking the release were found

@pascalwengerter
Copy link
Contributor

Smoke test with ocis wopi deployment example (on oCIS master) and locally built web-4.4.0-rc1


archiver v2 feature

  • ✔️ as admin - upload a folder test-folder with three files as content of the folder
    • ✔️right click contextmenu shows Download folder and downloads a download.tar which can be extracted properly on Ubuntu
    • ✔️ All actions sidebar panel shows Download folder and downloads a download.tar which can be extracted properly on Ubuntu
    • ✔️ the Download batch action for the selected test-folder downloads a download.tar which can be extracted properly on Ubuntu
  • ✔️ as admin - adding a file to the selection still shows the Download batch action
    • ✔️ batch action downloads a download.tar which can be extracted properly on Ubuntu
  • ✔️ as admin - removing the folder from the selection again still shows the Download batch action
    • ✔️ batch action does a single file download since only one file was selected

app provider feature

  • ✔️ as einstein - upload a file example.odt
  • ✔️ right click contextmenu shows Open in Collabora + actually opens it in Collabora
  • ✔️ All actions sidebar panel shows Open in Collabora + actually opens it in Collabora
  • ✔️ using the default action on the file opens it in Collabora
  • ❌ Collabora shows all kinds of exceptions and doesn't render itself properly. Unusable. -> seems to be a collabora issue, not web related.
  • ✔️ Onlyoffice works properly
  • ✔️ as einstein - upload a file lorem-markdown.md
  • ✔️ CodiMD works properly

Remarks

  • context menu has a weirdly huge bottom padding
  • the order of Onlyoffice and Collabora in the actions and contextmenu seems to be random. feels weird.

@pascalwengerter
Copy link
Contributor

Closed via #5944

@kulmann kulmann unpinned this issue Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants