Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unite "Links" + "People" in "Share" Panel #6621

Closed
7 of 8 tasks
tbsbdr opened this issue Mar 18, 2022 · 5 comments · Fixed by #6820
Closed
7 of 8 tasks

Unite "Links" + "People" in "Share" Panel #6621

tbsbdr opened this issue Mar 18, 2022 · 5 comments · Fixed by #6820
Assignees
Labels
Type:Story User Story

Comments

@tbsbdr
Copy link

tbsbdr commented Mar 18, 2022

Description

User Stories

  • (Comprehend) As a user I want to see at a glance how and who has access to a resource so that I can make sure that no unwanted access is disclosed.

  • (Edit) As a user I want to manage access to a resource so that I'm in full control of resource-access.

Note:
The usecase "Just quickly sharing a resource" is covered by rightclick and quickactions and not No1 focus of this story.

Value

  • data loss prevention by-design

  • Simplify resource access-management

Acceptance Criteria

  • Panel headline is "Share"

  • Right sidebar gets wider (eg. 1/3) so that line-breaks of the scopes "Everyone with the link v can edit v" are avoided

  • OC10 only: Private link gets moved to top right corner, as in screenshots

  • OC10 only: Links-Section holds only public Links, Headline: "Share via public link"

  • oCIS only: Links-Section holds Scoped links Headline: "Share via link"

  • Quick Link: Concept is introduced for oc10 and oCIS:

    • Quickaction-Link creates/copies always the quick-link
    • if more links are needed, they can get created via click on add link
  • Sharee-List is initialy truncated to the first 3 items; (Note: this also applies to the Spaces-Share list which is grouped into Shared with and Space members)

    • show all expands, shows all Sharee-list entries
    • show less collapes, shows the first 3 items
  • Shared column / Status => People & Link share indicators stay, get updated to "anchor scroll" in Shares sidebar panel

Cherries on top:

  • Sidebar title selected item "name" doesn't slide when changing panels

Questions

  • Should we make the sidebar "wider" again?
  • Are "Link share items" expandable, similar to "People share items"?
  • How many "People" shares are initially visible?
  • Should "People" and "Link" shares be expandable (akin to Summary/Details HTML tag) inside the Shares panel?
@exalate-issue-sync
Copy link

Pascal Wengerter commented: oCIS only: Private link is not shown on top right corner any more that isn't the case right now anyways, private link is shown/hidden based on capabilities ;)

@exalate-issue-sync
Copy link

Tobias Baader commented: yep, removed it - saw it in contrast to oc10 only

@exalate-issue-sync
Copy link

Florian Schade commented: PR -> #6701

@settings settings bot removed the p3-medium label Apr 6, 2022
@tbsbdr
Copy link
Author

tbsbdr commented Apr 6, 2022

We had a discussion how to confirm to the users, that the link had been copied in a little bit less disturbing and more polite, in-place way than via a toast.

Problems:

  • a) If we only use an Icon like 📋 -> ✅ and change it on-click for confirmation, it looks nice but is not accessible for everyone -> Icon only should be avoided if possible (more about icon usability)
  • b) If we use text and the button text changes from "copy" -> "copied" or "copia" -> "copiado de" the button gets jumpy because of its changing width.

Proposals

1: use "Ok" as a kind of literal (needs no translation -> doesn't jump)

@pascalwengerter I would say even the change of the text doesn't feel so nice - though the width is fixed in the example:
2022-04-06_22-22-20 (1)

2: use the URL icon + URL to display success

I would prefer this one as it doesn't "pull the carpet" under your mouse-pointer:
2022-04-06_22-25-17 (1)
Could be even nicer eg. via pushing-in from left to right and back again. Didn't want to go into more detail without your feedback.

Should we go on with proposal 2?

@kulmann
Copy link
Contributor

kulmann commented Apr 7, 2022

Proposal 2 looks nice 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type:Story User Story
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants