Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Buffer is not defined" in typescript files #6821

Closed
elizavetaRa opened this issue Apr 27, 2022 · 2 comments
Closed

"Buffer is not defined" in typescript files #6821

elizavetaRa opened this issue Apr 27, 2022 · 2 comments

Comments

@elizavetaRa
Copy link
Member

Buffer is used in useAppFileHandling.ts for basic auth. It throws error "Buffer is not defined" and causes auth to fail. Because of this, external apps are not working in password protected public links

Steps to reproduce

  1. Create public link with password for a document that opens with an external app
  2. Open public link
  3. Open the document: error by external app
@elizavetaRa
Copy link
Member Author

We have internally a fix for that
which uses the "buffer" library. I found that it's also possible to polyfill buffer. Which would be the better solution?

@pascalwengerter
Copy link
Contributor

Should already be fixed as part of #6202

@diocas diocas closed this as completed Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants