Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 5.7.0 #7219

Closed
33 of 36 tasks
kulmann opened this issue Jul 6, 2022 · 3 comments · Fixed by #7175
Closed
33 of 36 tasks

Release 5.7.0 #7219

kulmann opened this issue Jul 6, 2022 · 3 comments · Fixed by #7175

Comments

@kulmann
Copy link
Contributor

kulmann commented Jul 6, 2022

Release checklist

  • pin release issue @kulmann
  • release & bump ODS if needed
  • release & bump SDK if needed
  • prepare release rc
    • create a branch release-5.7.0 @kulmann
    • update the version in packages/web-integration-oc10/appinfo/info.xml @kulmann
    • update the version in package.json @kulmann
    • update the version in sonar-project.properties @kulmann
    • move changelog/unreleased/* to changelog/VERSION_YYYY-MM-DD @kulmann
    • update the ocis commit id in .drone.env to the most recent one from ocis master (let's see how it goes) @kulmann
    • commit, push and create draft PR for this branch @kulmann
  • create pre release tag v5.7.0-rc.1 from the release branch @kulmann (2022-06-23)
  • create pre release tag v5.7.0-rc.2 from the release branch @kulmann (2022-07-07)
  • create pre release tag v5.7.0-rc.3 from the release branch @kulmann (2022-07-07)
  • create pre release tag v5.7.0-rc.4 from the release branch @kulmann (2022-07-08)
  • create pre release tag v5.7.0-rc.5 from the release branch @pascalwengerter (2022-07-11)
  • create pre release tag v5.7.0-rc.6 from the release branch @kulmann (2022-08-01)
  • create pre-release tag v5.7.0-rc.7 from the release branch @kulmann (2022-08-02)
  • create pre-release tag v5.7.0-rc.8 from the release branch @kulmann (2022-08-08)
  • create pre-release tag v5.7.0-rc.9 from the release branch @kulmann (2022-08-10)
  • create pre-release tag v5.7.0-rc.10 from the release branch @kulmann (2022-08-23)
  • create pre-release tag v5.7.0-rc.11 from the release branch @kulmann (2022-09-02)
  • create pre-release tag v5.7.0-rc.12 from the release branch @kulmann (2022-09-08)
  • smoke test
  • if needed, fix issues or write down known issues
  • update YYYY-MM-DD to current date in changelog/VERSION_YYYY-MM-DD
  • Make sure translations are up to date by updating them in Transifex and restarting translation sync job https://drone.owncloud.com/owncloud/translation-sync/
  • repeat above steps if a new rc is needed
  • Run translations sync job once again
  • go to the releases section and click Draft a new Release. Use v5.7.0 as a tag (the v prefix is important) and 5.7.0 as name and publish it
  • ping in internal #btr channel to create a signed release and ask them to upload it to a) the github release page, b) marketplace.owncloud.com, c) portal.owncloud.com, d) customer.owncloud.com
  • merge release branch back to master (CI must be green)
@kulmann kulmann pinned this issue Jul 6, 2022
@labkode labkode unpinned this issue Jul 7, 2022
@pascalwengerter pascalwengerter pinned this issue Jul 11, 2022
@ScharfViktor
Copy link
Contributor

v5.7.0-rc.5

Case 1: admin share folder(with file) to marie:

Admin:

Marie:

  • accept "folder_to_share"
  • re-share to einstein as viewer (ensure that einstein gets file)
  • rename "folder_to_share" - cannot rename folder in new implementation
  • upload new file "file.txt" to "folder_to_share" (admin see new file)
  • open pdf file
  • rename file.pdf (use rigth click) (admin see that file changed name)

Einstein:

  • accept file
  • cannot rename/move/delete/upload file in folder and cannot create new document in the folder

Admin:

  • add new file.jpeg to "folder_to_share"
  • move file.pdf to root "personal" (marie can not see file.pdf)
  • add new "file.txt" create new version. (use drag and drop)
  • open txt file in markdown-editor. Change and save.

Marie:

  • can download both versions
  • restore old version

Einstein:

  • can download only last version
  • cannot restore old version

Marie:

  • decline folder (removed from shares folder) - Einstein still has a folder
  • accept again

Admin:

  • delete folder "folder_to_share" (removed from shared with me, removed from Marie and Einstein)

Case 2: admin share file to marie:

Admin:

  • upload file.jpeg
  • share file.jpeg to "user" group

Marie:

  • accept file (marie can open/download/copy file but cannot delete/move/rename) - cannot copy paste in share jail
  • open file in Mediaviewer
  • download file

Admin:

  • share "file.txt" with rigth edit (use main menu. find marie by email [email protected])

Marie:

Admin:

  • unshare "file.jpeg" (marie cannot see "file.jpeg")

Case 3: admin create public links to folder

Admin:

  • create folder "for upload"
  • add link with name "to_upload" with role "Uploader" with pass and expiration date
  • open link (can only upload)
  • upload file (admin can see new file)
  • change share "for upload" from "Uploader" to "edit"
  • admin add new file to folder "for upload"
  • refresh link (file exist)
  • admin change pass (refresh link has to type new pass)

Case 4: admin create link to file

Admin:

  • create file png
  • add link with main menu
  • open link(can open, download, see) in the incognito tab
  • change link, add pass
  • refresh page (input pass)
  • delete link
  • refresh page (resource not found)
  • delete file
  • restore
  • delete
  • Empty trash

Case 5: space story:

Katherine:

  • create space
  • add space image
  • add subtitle "for test"
  • edit description
  • try to upload file (more 1 Gb)
  • increase quota to 5Gb and try again
  • delete file
  • add member Marie with edit role
  • add member Einstein with viewer role

Marie:

  • can see space without accepting
  • change image and description
  • can upload file/folder and create file and folder
  • cannot create resource sharing and space sharing
  • can see deleted files and can restore files from trash
  • cannot disable space

Einstein:

  • can see space without accepting
  • cannot change image and description
  • cannot upload file/folder and create file and folder
  • cannot create resource sharing and space sharing
  • can see deleted files and cannot restore files from trash
  • cannot disable space

Katherine change Einstein role to manager

Case 6: create new user via accounts:

Admin (test via api):

  • create new account "tom" use graph Api
  • create new group
  • share folder with group
  • change language
  • delete users

Remarks:

  • `12T11:43:51Z ERR failed to send a message error="rpc error: code = Unknown desc = gateway: error calling GetGroup: rpc error: code = Unauthenticated desc = auth: core access token not found" event=ShareCreated service=notifications

2022-07-12T11:43:59Z ERR failed to send a message error="could not send mail: dial tcp 127.0.0.1:1025: connect: connection refused" event=ShareCreated service=notifications`

@kulmann
Copy link
Contributor Author

kulmann commented Sep 2, 2022

smoke testing v5.7.0-rc.11 with web as oc10-app

  • ❌ as gunter - upload arch/mips folder from linux kernel (1801 files)
    - ❌ via drag and drop folder upload broken.
    - ✔️ via folder upload button works

  • ✔️ as gunter - share the folder to alice as viewer

  • ✔️ as alice - share is already accepted. declining and accepting again works as expected (buttons in shared with me table, batch action, right sidebar)

  • ✔️ as alice - try do delete file from shared folder
    - individual delete action not visible, good
    - batch delete action not visible, good
    - context menu action not visible, good

  • ✔️ as alice - try to add file
    - not possible (which is expected)
    - drag & drop upload handle it with an error (which is good)

  • ✔️ as alice - copy 16 folders from share to home (via copy & paste actions above table)-

    • no visible feedback that it's in progress, but works
  • ✔️ as alice - copy 16 folders from share to home (via keyboard actions cmd+c / cmd+v)

  • ✔️ as gunter - add a file (some image) to share

  • ✔️ as alice - receive new file in existing share

    • visible in file list
    • can be opened in preview app
  • ✔️ as gunter - unshare folder from shared with others

  • ✔️ as alice - try to revisit old share

    • shows resource not found upon page reload, good
    • going back to All files or Shared with me doesn't list the share anymore, good
  • ✔️ as gunter - share folder with alice again, but as editor
    - setting and removing an expiration date work as expected, good

  • ✔️ as alice - rename a file

    • via right sidebar, works, good
    • via context menu, works, good
  • ✔️ as gunter - add file

  • ✔️ as alice - delete file

    • via right sidebar, works, good
    • via context menu, works, good
    • via batch action, works, good
  • ✔️ as alice - create quick link on any folder

  • ✔️ as alice delete file and recover it

  • ✔️ as alice create version of textfile

  • ✔️ as alice view version history of text file

  • ✔️ as alice download newest version of text file

  • ✔️ download older version of text file

  • ✔️ restore older version of text file

    • no visible feedback about the success
    • preview is not updated
  • ✔️ as alice - upload avatar in classic UI

    • see own avatar in top bar (far right)
    • login as gunter, having a share with alice
      • shared with others page loads
      • avatar of alice is not shown (bad)
  • ✔️ as alice, move a file into subfolder via drag and drop

  • ✔️ as alice, move multiple files & folders into subfolder via drag and drop

  • ✔️ as alice, navigate into a folder, open right sidebar without selection, share current folder with gunter

Remarks / findings

  • font embedding is broken (release blocker) -> fixed in 2f5cd3f
  • drag and drop folder upload is broken, see screenshot (release blocker) -> seems to be an issue when using http (i.e. without ssl). needs to be confirmed. Would not be a release blocker then. -> confirmed that this doesn't happen with https connection.

Screenshot 2022-09-02 at 20 33 32

more context: broken in Google Chrome. Safari works as expected though.

  • navigate into "shared with me" page without shares, shows console error
[Vue warn]: Invalid prop: type check failed for prop "sortBy". Expected String, got Undefined 

(not a release blocker), fixed on release branch

@kulmann kulmann self-assigned this Sep 9, 2022
@kulmann
Copy link
Contributor Author

kulmann commented Sep 9, 2022

v5.7.0 final was released today ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants