Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QA] add ability to run the full webUI CI without stopping early #7547

Closed
grgprarup opened this issue Aug 30, 2022 · 5 comments · Fixed by #7558
Closed

[QA] add ability to run the full webUI CI without stopping early #7547

grgprarup opened this issue Aug 30, 2022 · 5 comments · Fixed by #7558
Assignees
Labels

Comments

@grgprarup
Copy link
Contributor

grgprarup commented Aug 30, 2022

The whole build pipelines get stopped when an early fail occurs in e2e test pipelines, even if the PRs have full-ci in them.

Implementation for acceptance is done here #5184
Need to add for e2e pipelines so that if the PR title has full-ci in it then do not stop early - let all the pipelines run.

Related issues: #5183, owncloud/ocis#2107

Some builds which show the current behavior: https://drone.owncloud.com/owncloud/web/27900, https://drone.owncloud.com/owncloud/web/27899

CC @phil-davis @individual-it

@kiranparajuli589
Copy link
Contributor

imo the stated feature is already there:

web/.drone.star

Line 1334 in 12a4494

if ("full-ci" in ctx.build.title.lower()):

@kiranparajuli589
Copy link
Contributor

kiranparajuli589 commented Aug 30, 2022

After viewing the provided build examples, the full-ci logic may be missing for the e2e pipelines.

Also, acceptance test pipelines do not need to depend on e2e test pipelines.

@saw-jan
Copy link
Member

saw-jan commented Aug 30, 2022

I guess we only want to run acceptance if and only if the e2e tests pass that's why the acceptance is dependent on e2e (because eventually both try to test the same features).

But I really don't know the reasons, just my guesses. Maybe the dependency was there by mistake

CC @grgprarup @kiranparajuli589 @individual-it @phil-davis

@kiranparajuli589
Copy link
Contributor

kiranparajuli589 commented Aug 30, 2022

Acceptance tests waiting for e2e are not so nice in terms of resource consumption and there is nothing to depend for. The CI has to wait for about 5 minutes more for the acceptance tests.
If there aren't any other specific|strong reasons behind it, then I feel the dependency should be fixed.

@ScharfViktor
Copy link
Contributor

I agree with @kiranparajuli589. At first, when e2e was small and fast, it made sense. But now we have a lot of e2e tests and increasing coverage. Acceptance tests don't have to wait IMHO

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants