-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[QA] add ability to run the full webUI CI without stopping early #7547
Comments
imo the stated feature is already there: Line 1334 in 12a4494
|
After viewing the provided build examples, the full-ci logic may be missing for the Also, |
I guess we only want to run acceptance if and only if the e2e tests pass that's why the acceptance is dependent on e2e (because eventually both try to test the same features). But I really don't know the reasons, just my guesses. Maybe the dependency was there by mistake |
Acceptance tests waiting for e2e are not so nice in terms of resource consumption and there is nothing to depend for. The CI has to wait for about 5 minutes more for the acceptance tests. |
I agree with @kiranparajuli589. At first, when e2e was small and fast, it made sense. But now we have a lot of e2e tests and increasing coverage. Acceptance tests don't have to wait IMHO |
The whole build pipelines get stopped when an early fail occurs in
e2e
test pipelines, even if the PRs havefull-ci
in them.Implementation for acceptance is done here #5184
Need to add for e2e pipelines so that if the PR title has
full-ci
in it then do not stop early - let all the pipelines run.Related issues: #5183, owncloud/ocis#2107
Some builds which show the current behavior: https://drone.owncloud.com/owncloud/web/27900, https://drone.owncloud.com/owncloud/web/27899
CC @phil-davis @individual-it
The text was updated successfully, but these errors were encountered: