Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[web] Image Preview crops images and can't scroll #7728

Closed
willmackay opened this issue Oct 3, 2022 · 3 comments
Closed

[web] Image Preview crops images and can't scroll #7728

willmackay opened this issue Oct 3, 2022 · 3 comments
Assignees
Labels
Priority:p3-medium Normal priority

Comments

@willmackay
Copy link

Steps to reproduce

  1. Upload file with wide or tall aspect ratio
  2. Click image file to preview it
  3. Observe image is cropped
  4. Try to scroll cropped part of image into view

Expected behaviour

Scroll functionality to see more of the image would be nice, especially for wide or tall images which get cropped more severely.

Actual behaviour

Image is cropped and no scroll functionality exists to see cropped parts

Environment general

Operating system: Debian 11

Backend (ownCloud Core or Infinite Scale): OCIS

Are you using an external user-backend, if yes which one: No

Environment ownCloud Infinite Scale

Version: 2.0.0-beta8

Updated from an older Infinite Scale or fresh install: Updated from 2.0.0-beta5

Where did you install Infinite Scale from: Binary download on OCIS releases page

Client configuration

Browser: Opera, Firefox

Operating system: Windows, Android

Related issues

Please see #7160 and #6700 for similar issues.

Opera Snapshot_2022-10-03_153258_ocis alyrica net

@tbsbdr
Copy link

tbsbdr commented Oct 4, 2022

👍 good point

  • the initial preview-image should not be cropped (users should see the whole image at a glance initially)
  • zoomed-in images should be x/y-scrollable via mouse-drag and also via keyboard arrows for better accessbility

@JammingBen JammingBen self-assigned this Oct 7, 2022
@JammingBen
Copy link
Contributor

This seems to be a backend issue. I have an image with the size of 4288 x 2844. Now I request a preview from the server:

https://host.docker.internal:9200/remote.php/dav/spaces/1284d238-aa92-42ce-bdc4-0b0000009157%24c2e72b36-179d-4a39-8d24-a7a696d76797/ESC_large_ISS022_ISS022-E-11387-edit_01.jpeg?scalingup=0&preview=1&a=1&c=cfaee0f51228a2299ec139f1642d88fe&x=4000

The result is a cropped image. The result is cropped as long as the x query param is smaller than the original width of the image. The following results in a not-cropped image:

https://host.docker.internal:9200/remote.php/dav/spaces/1284d238-aa92-42ce-bdc4-0b0000009157%24c2e72b36-179d-4a39-8d24-a7a696d76797/ESC_large_ISS022_ISS022-E-11387-edit_01.jpeg?scalingup=0&preview=1&a=1&c=cfaee0f51228a2299ec139f1642d88fe&x=5000

We could set preview=0, which also disables the cropping. But then the image is delivered with 100% dimensions - we don't want that. What we basically want for the mediaviewer is to resize the image without cropping it. @C0rby is it possible to introduce an additional crop param to determine this?

@michaelstingl
Copy link
Contributor

michaelstingl commented Jan 12, 2023

CleanShot 2023-01-12 at 17 27 43@2x CleanShot 2023-01-12 at 17 27 51@2x
oC10
web.owncloud.com
oCIS ⚠️
ocis.ocis-web.latest.owncloud.works

@michaelstingl michaelstingl reopened this Jan 12, 2023
@tbsbdr tbsbdr added the Priority:p3-medium Normal priority label Jan 13, 2023
@kulmann kulmann moved this to Blocked in Web Support Board Jun 19, 2023
@JammingBen JammingBen moved this from Blocked to In progress in Web Support Board Oct 9, 2023
@JammingBen JammingBen moved this from Qualification to Backlog in Infinite Scale Team Board Oct 12, 2023
@JammingBen JammingBen changed the title Image Preview crops images and can't scroll [web] Image Preview crops images and can't scroll Oct 12, 2023
@micbar micbar moved this from Backlog to In progress in Infinite Scale Team Board Oct 16, 2023
@fschade fschade moved this from In progress to Done in Infinite Scale Team Board Oct 17, 2023
@fschade fschade moved this from In progress to Done in Web Support Board Oct 17, 2023
@fschade fschade closed this as completed Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:p3-medium Normal priority
Projects
Archived in project
Status: Done
Development

No branches or pull requests

5 participants