Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display remaining time on link shares with expiration date #8211

Closed
hurradieweltgehtunter opened this issue Jan 11, 2023 · 7 comments · Fixed by #8866
Closed

Display remaining time on link shares with expiration date #8211

hurradieweltgehtunter opened this issue Jan 11, 2023 · 7 comments · Fixed by #8866
Assignees
Labels
Category:Enhancement Add new functionality Topic:good-first-issue beginner friendly task

Comments

@hurradieweltgehtunter
Copy link
Contributor

It would be nice to have a little indicator showing how much time is left until a share expires.

grafik

@hurradieweltgehtunter hurradieweltgehtunter added the Category:Enhancement Add new functionality label Jan 11, 2023
@kulmann kulmann added the Topic:good-first-issue beginner friendly task label Mar 29, 2023
@lookacat lookacat self-assigned this Apr 19, 2023
@kulmann
Copy link
Contributor

kulmann commented May 2, 2023

Will be removed again in #8965 as the role labels are much longer now and the space is insufficient to display such a hint. The calendar icon has a tooltip with the corresponding text. Sufficient for now.

@hurradieweltgehtunter
Copy link
Contributor Author

IMO we need to have a concept rework of the whole sharing dialog in the right sidebar. Too many "fixes" which get reverted.

@tbsbdr
Copy link

tbsbdr commented May 2, 2023

Too many "fixes" which get reverted.

which ones?

@hurradieweltgehtunter
Copy link
Contributor Author

this one (obviously), pill style of sharing roles, link share role "internal", layout of sharing link creation form, discussion about the purpose of quicklinks VS "normal" sharing links", why is the private link not available anymore but for example iOS and desktop still uses them ...
I didn't count them one by one but since I have been dealing with web, issues especially about the right sidebar sharing dialogue popped up again and again.

@kulmann
Copy link
Contributor

kulmann commented May 2, 2023

why is the private link not available anymore but for example iOS and desktop still uses them ...

That one is by design. Private link is not a good user facing concept. But it's a good thing for client-to-client handover. Nothing wrong with that.

@hurradieweltgehtunter
Copy link
Contributor Author

why is the private link not available anymore but for example iOS and desktop still uses them ...

That one is by design. Private link is not a good user facing concept. But it's a good thing for client-to-client handover. Nothing wrong with that.

iOS lets me use the private link, too.
But I'm not starting a discussion here, we had that :)I just can remember that we had the sharing dialog in the right sidebar in some conversations but we moved it to after customer release.

@kulmann
Copy link
Contributor

kulmann commented May 2, 2023

why is the private link not available anymore but for example iOS and desktop still uses them ...

That one is by design. Private link is not a good user facing concept. But it's a good thing for client-to-client handover. Nothing wrong with that.

iOS lets me use the private link, too.

That's not intended and will be fixed at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category:Enhancement Add new functionality Topic:good-first-issue beginner friendly task
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants