Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[web] Provide all modal dialogs with loading spinners #9183

Closed
hurradieweltgehtunter opened this issue Jun 7, 2023 · 2 comments · Fixed by #10787
Closed

[web] Provide all modal dialogs with loading spinners #9183

hurradieweltgehtunter opened this issue Jun 7, 2023 · 2 comments · Fixed by #10787
Assignees
Labels
Category:Enhancement Add new functionality Priority:p2-high Escalation, on top of current planning, release blocker Web-only Issue without backend dependecies

Comments

@hurradieweltgehtunter
Copy link
Contributor

hurradieweltgehtunter commented Jun 7, 2023

All buttons, which confirm a form or some sort of dialog, should receive a spinner, which indicates that the desired action is running. This applies to:

— Modals
— Forms, for example sharing dialogue
— …

Current state leaves the user often with an unresponsive UI, which seems to be doing nothing or broken.
The user is tempted to reload the page, which cancels the action running in the background and leads to unwanted results.

Related:

For modals:

  • show loading indicator in submit button if action is in progress (same as in sharing when inviting users)
  • Add an offset after which the indicator appears (maybe 700ms as in sharing?)

visual

loading indicator like we have it already in the share button
screenshot_002558

@hurradieweltgehtunter hurradieweltgehtunter added the Category:Enhancement Add new functionality label Jun 7, 2023
@kulmann
Copy link
Contributor

kulmann commented Jun 9, 2023

On top of that we also really do need to prevent submitting the respective action multiple times, see e.g. #9189

@hurradieweltgehtunter
Copy link
Contributor Author

On top of that we also really do need to prevent submitting the respective action multiple times, see e.g. #9189

I think this is also connected to #9018

@tbsbdr tbsbdr added Web-only Issue without backend dependecies Priority:p2-high Escalation, on top of current planning, release blocker labels Mar 5, 2024
@JammingBen JammingBen changed the title Provide all dialogs with loading spinners Provide all modal dialogs with loading spinners Apr 11, 2024
@tbsbdr tbsbdr changed the title Provide all modal dialogs with loading spinners [web] Provide all modal dialogs with loading spinners Apr 15, 2024
@AlexAndBear AlexAndBear self-assigned this Apr 15, 2024
@AlexAndBear AlexAndBear moved this from Backlog to In progress in Infinite Scale Team Board Apr 15, 2024
@AlexAndBear AlexAndBear moved this from In progress to Done in Infinite Scale Team Board Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category:Enhancement Add new functionality Priority:p2-high Escalation, on top of current planning, release blocker Web-only Issue without backend dependecies
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants