Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide alternative to store user language setting #9243

Closed
tbsbdr opened this issue Jun 15, 2023 · 6 comments · Fixed by #9924
Closed

Provide alternative to store user language setting #9243

tbsbdr opened this issue Jun 15, 2023 · 6 comments · Fixed by #9924

Comments

@tbsbdr
Copy link

tbsbdr commented Jun 15, 2023

Description

User Stories

  • As a developer I need a way to store the user-language without the ocis settings api so that I'm not fixed to store the user-language via the the ocis settings-service.

Value

Acceptance Criteria

  • user language needs to be available in get request to /me in the graph api
  • user language can be updated via patch request to /users/{id} in the graph api
  • web needs to use these 2 requests for the user language (dont use the settings api any more)
  • check if the query for values-list can be removed if only used for getting the current language
  • web needs to provide a hard-coded list of all available languages. Currently:
image

Note: settings api should only be available internal via grpc
Note: needs backend change (for both ocis and reva master)

Definition of ready

[ ] everybody needs to understand the value written in the user story
[ ] acceptance criteria has to be defined
[ ] all dependencies of the user story need to be identified
[ ] feature should be seen from an end user perspective
[ ] user story has to be estimated
[ ] story points need to be less then 20

Definition of done

  • Functional requirements
    [ ] functionality described in the user story works
    [ ] acceptance criteria are fulfilled
  • Quality
    [ ] code review happened
    [ ] CI is green
    [ ] critical code received unit tests by the developer
    [ ] automated tests passed (if automated tests are not available, this test needs to be created and passed
  • Non-functional requirements
    [ ] no sonar cloud issues

refers to: 89949c3

tbsbdr referenced this issue Jun 15, 2023
Because our Reva backend doesn't implement the settings API
@tbsbdr tbsbdr added this to the CERN Web Merge milestone Jul 10, 2023
@butonic
Copy link
Member

butonic commented Oct 12, 2023

we should add the preferredLanguage property to the libre graph user resouce as it exists in ms graph:

Property Type Description
preferredLanguage String The preferred language for the user. The preferred language format is based on RFC 4646. The name is a combination of an ISO 639 two-letter lowercase culture code associated with the language, and an ISO 3166 two-letter uppercase subculture code associated with the country or region. Example: "en-US", or "es-ES". Returned by default. Supports $filter (eq, ne, not, ge, le, in, startsWith, and eq on null values)

@micbar
Copy link
Contributor

micbar commented Oct 12, 2023

Fine for me.

@tbsbdr
Copy link
Author

tbsbdr commented Oct 13, 2023

@tbsbdr tbsbdr moved this from Qualification to Backlog in Infinite Scale Team Board Oct 13, 2023
@lookacat lookacat self-assigned this Nov 6, 2023
@lookacat lookacat moved this from Backlog to In progress in Infinite Scale Team Board Nov 6, 2023
@lookacat lookacat moved this from In progress to Backlog in Infinite Scale Team Board Nov 6, 2023
@lookacat lookacat removed their assignment Nov 6, 2023
@2403905
Copy link
Contributor

2403905 commented Nov 9, 2023

  1. @tbsbdr @micbar Are we keep the two-letter format 'en' or move to the "en-US" ?

@butonic
2. Could the available languages look like https://learn.microsoft.com/en-us/graph/api/outlookuser-supportedlanguages?view=graph-rest-1.0&tabs=http

@AlexAndBear AlexAndBear self-assigned this Nov 9, 2023
@AlexAndBear AlexAndBear moved this from Backlog to In progress in Infinite Scale Team Board Nov 10, 2023
@AlexAndBear
Copy link
Contributor

  1. @tbsbdr @micbar Are we keep the two-letter format 'en' or move to the "en-US" ?

@butonic 2. Could the available languages look like https://learn.microsoft.com/en-us/graph/api/outlookuser-supportedlanguages?view=graph-rest-1.0&tabs=http

we keep the two-letter format, but the API will accept and expose ISO lang codes as well

@AlexAndBear
Copy link
Contributor

Note: I updated the story points to 8 because its a little bit more complex than we thought first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

6 participants