Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Streamline resource and share id types #9921

Closed
JammingBen opened this issue Nov 8, 2023 · 2 comments
Closed

Streamline resource and share id types #9921

JammingBen opened this issue Nov 8, 2023 · 2 comments
Assignees
@kulmann
Labels
Category:Technical Technical ehancements

Comments

@JammingBen
Copy link
Contributor

Resource and share ids are currently typed as string | number for some reason, although all ids are strings effectively. We should adjust the type here to better reflect the actual type.

\cc @dschmidt
@JammingBen JammingBen added the Category:Technical Technical ehancements label Nov 8, 2023
@kulmann
Copy link
Contributor

kulmann commented Nov 8, 2023

Comes from the oc10 days where ids could be numbers. Agreed, we should remove the number type from the code base now....

Assigning myself, as I'm currently prototyping something which includes work on those types...

@kulmann kulmann self-assigned this Nov 8, 2023
@kulmann kulmann moved this from Qualification to Refactor / Technical Debt in Infinite Scale Team Board Nov 8, 2023
@JammingBen
Copy link
Contributor Author

Closing here since that has been fixed via #10111.

@github-project-automation github-project-automation bot moved this from Refactor / Technical Debt to Done in Infinite Scale Team Board Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kulmann kulmann

Labels
Category:Technical Technical ehancements
Projects
Infinite Scale Team Board
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kulmann @JammingBen