From 785fc40bef05cd7c810e18a5efaae6ed4e5b8a74 Mon Sep 17 00:00:00 2001 From: Benedikt Kulmann Date: Mon, 23 Aug 2021 23:51:22 +0200 Subject: [PATCH 1/3] Update to ODS 9.3.0 --- packages/web-app-files/src/mixins/actions/showActions.js | 6 ++++-- packages/web-app-files/src/mixins/actions/showDetails.js | 6 ++++-- packages/web-runtime/package.json | 2 +- yarn.lock | 8 ++++---- 4 files changed, 13 insertions(+), 9 deletions(-) diff --git a/packages/web-app-files/src/mixins/actions/showActions.js b/packages/web-app-files/src/mixins/actions/showActions.js index 1143ee23bde..6f38ae13a87 100644 --- a/packages/web-app-files/src/mixins/actions/showActions.js +++ b/packages/web-app-files/src/mixins/actions/showActions.js @@ -1,4 +1,4 @@ -import { mapMutations } from 'vuex' +import { mapActions, mapMutations } from 'vuex' import { isTrashbinRoute } from '../../helpers/route' export default { @@ -18,8 +18,10 @@ export default { }, methods: { ...mapMutations('Files', ['SET_APP_SIDEBAR_ACTIVE_PANEL']), + ...mapActions('Files/sidebar', { openSidebar: 'open' }), - $_showActions_trigger() { + async $_showActions_trigger() { + await this.openSidebar() this.SET_APP_SIDEBAR_ACTIVE_PANEL(isTrashbinRoute(this.$route) ? null : 'actions-item') } } diff --git a/packages/web-app-files/src/mixins/actions/showDetails.js b/packages/web-app-files/src/mixins/actions/showDetails.js index 095e078af64..dea62371487 100644 --- a/packages/web-app-files/src/mixins/actions/showDetails.js +++ b/packages/web-app-files/src/mixins/actions/showDetails.js @@ -1,4 +1,4 @@ -import { mapMutations } from 'vuex' +import { mapActions, mapMutations } from 'vuex' import { isTrashbinRoute } from '../../helpers/route' export default { @@ -18,8 +18,10 @@ export default { }, methods: { ...mapMutations('Files', ['SET_APP_SIDEBAR_ACTIVE_PANEL']), + ...mapActions('Files/sidebar', { openSidebar: 'open' }), - $_showDetails_trigger() { + async $_showDetails_trigger() { + await this.openSidebar() this.SET_APP_SIDEBAR_ACTIVE_PANEL(null) } } diff --git a/packages/web-runtime/package.json b/packages/web-runtime/package.json index 1112a08933f..07ad34770b9 100644 --- a/packages/web-runtime/package.json +++ b/packages/web-runtime/package.json @@ -13,7 +13,7 @@ "lodash-es": "^4.17.21", "luxon": "^1.27.0", "oidc-client": "1.11.5", - "owncloud-design-system": "^9.2.0", + "owncloud-design-system": "^9.3.0", "owncloud-sdk": "1.0.0-2296", "p-queue": "^6.1.1", "portal-vue": "^2.1.7", diff --git a/yarn.lock b/yarn.lock index efad515ca81..8f25026d5b4 100644 --- a/yarn.lock +++ b/yarn.lock @@ -8244,10 +8244,10 @@ ospec@3.1.0: dependencies: glob "^7.1.3" -owncloud-design-system@^9.2.0: - version "9.2.0" - resolved "https://registry.yarnpkg.com/owncloud-design-system/-/owncloud-design-system-9.2.0.tgz#1e1dfe2fd7bdafe2e80fcebadf841877b908420d" - integrity sha512-EcDoe3NvX112wk9q+JUIOUDjRrvBXVs16w+ZBv1+fq+9LbXqWbgUTPkkFqKZRNWEN/wbgyDFqoczunQHTIa8jA== +owncloud-design-system@^9.3.0: + version "9.3.0" + resolved "https://registry.yarnpkg.com/owncloud-design-system/-/owncloud-design-system-9.3.0.tgz#d27b7562ca7548074a4bcf4ed3128e92a248a8a1" + integrity sha512-wOQAd6XXRmNq7+9NNP2m6TKJKt7Xx4hzeghAbeu+7YPCmNHlay7B4IhEpuCt0N+WxPqGg3NiTZQ42PUF4vKM1g== owncloud-sdk@1.0.0-2296: version "1.0.0-2296" From ee85491c4325565e157affcab13e245b892f750c Mon Sep 17 00:00:00 2001 From: Benedikt Kulmann Date: Tue, 24 Aug 2021 10:12:16 +0200 Subject: [PATCH 2/3] Add changelog --- changelog/unreleased/enhancement-update-ods | 12 ++++++++++++ 1 file changed, 12 insertions(+) create mode 100644 changelog/unreleased/enhancement-update-ods diff --git a/changelog/unreleased/enhancement-update-ods b/changelog/unreleased/enhancement-update-ods new file mode 100644 index 00000000000..e82c37fc29c --- /dev/null +++ b/changelog/unreleased/enhancement-update-ods @@ -0,0 +1,12 @@ +Enhancement: Update ODS to 9.3.0 + +We updated the ownCloud Design System to version 9.3.0. Please refer to the full changelog in the ODS release (linked) for more details. Summary: +- Bugfix - Fix search for options provided as objects: https://github.com/owncloud/owncloud-design-system/pull/1602 +- Bugfix - Contextmenu button triggered wrong event: https://github.com/owncloud/owncloud-design-system/pull/1610 +- Bugfix - Use pointer cursor for OcSelect actions: https://github.com/owncloud/owncloud-design-system/pull/1604 +- Enhancement - OcTableFiles Contextmenu Tooltip: https://github.com/owncloud/owncloud-design-system/pull/1610 +- Enhancement - Highlight droptarget in OcTableFiles: https://github.com/owncloud/owncloud-design-system/pull/1610 +- Enhancement - Remove "Showdetails" button in OcTableFiles: https://github.com/owncloud/owncloud-design-system/pull/1610 + +https://github.com/owncloud/web/pull/5725 +https://github.com/owncloud/owncloud-design-system/releases/tag/v9.3.0 From 52be900f42e6a740a97af54e3f8274a6b452fcef Mon Sep 17 00:00:00 2001 From: Benedikt Kulmann Date: Tue, 24 Aug 2021 11:01:42 +0200 Subject: [PATCH 3/3] Rewrite tests to use details button in context menu for sidebar --- __fixtures__/sharedViaLinkFiles.js | 8 +- dev/docker/oc10.web.config.json | 12 +- dev/docker/ocis.web.config.json | 68 ++--- .../src/components/AppBar/ViewOptions.vue | 1 + .../src/components/SideBar/FileInfo.vue | 8 +- .../web-app-files/src/helpers/resources.js | 2 +- ...-failures-with-oc10-server-oauth2-login.md | 3 - ...-failures-with-ocis-server-ocis-storage.md | 13 +- .../fileFolderActionMenu.feature | 1 - .../webUIFilesDetails/fileDetails.feature | 21 +- .../accessingPrivateLinks.feature | 5 +- .../shareWithGroups.feature | 1 + .../publicLinkCreate.feature | 2 +- .../shareByPublicLink.feature | 2 +- .../FilesPageElement/appSideBar.js | 213 ++++++++----- .../FilesPageElement/contextMenu.js | 53 ++++ .../FilesPageElement/fileActionsMenu.js | 37 ++- .../pageObjects/FilesPageElement/filesList.js | 288 ++++++++---------- .../pageObjects/FilesPageElement/filesRow.js | 39 --- .../FilesPageElement/mediaViewerPage.js | 4 +- .../FilesPageElement/sharingDialog.js | 75 ++--- .../pageObjects/markdownEditorPage.js | 4 +- tests/acceptance/pageObjects/personalPage.js | 32 -- tests/acceptance/pageObjects/webPage.js | 7 +- .../stepDefinitions/filesContext.js | 77 ++--- .../stepDefinitions/generalContext.js | 17 +- .../stepDefinitions/privateLinksContext.js | 27 +- .../stepDefinitions/publicLinkContext.js | 49 +-- .../stepDefinitions/sharingContext.js | 14 +- 29 files changed, 519 insertions(+), 564 deletions(-) create mode 100644 tests/acceptance/pageObjects/FilesPageElement/contextMenu.js diff --git a/__fixtures__/sharedViaLinkFiles.js b/__fixtures__/sharedViaLinkFiles.js index 86dbe952a61..d6a4e1d536e 100644 --- a/__fixtures__/sharedViaLinkFiles.js +++ b/__fixtures__/sharedViaLinkFiles.js @@ -20,8 +20,8 @@ const files = { storage_id: 'home::admin', storage: 2, item_type: 'folder', - item_source: 3009, - file_source: 3009, + item_source: 3007, + file_source: 3007, file_parent: 6, file_target: '/Documents', name: 'Quick action link', @@ -55,8 +55,8 @@ const files = { storage_id: 'home::admin', storage: 2, item_type: 'folder', - item_source: 3009, - file_source: 3009, + item_source: 3008, + file_source: 3008, file_parent: 6, file_target: '/.hidden-folder', name: 'Quick action link', diff --git a/dev/docker/oc10.web.config.json b/dev/docker/oc10.web.config.json index f2782dc632a..fbe3a0b3bf3 100644 --- a/dev/docker/oc10.web.config.json +++ b/dev/docker/oc10.web.config.json @@ -1,16 +1,12 @@ { - "server" : "http://host.docker.internal:8080", + "server": "http://host.docker.internal:8080", "auth": { "clientId": "M8W5mo3wQV3VHWYsaYpWhkr8dwa949i4GljCkedHhl7GWqmHMkxSeJgK2PcS0jt5", "url": "http://host.docker.internal:8080/index.php/apps/oauth2/api/v1/token", "authUrl": "http://host.docker.internal:8080/index.php/apps/oauth2/authorize" }, - "apps": [ - "files", - "media-viewer", - "search" - ], - "applications" : [ + "apps": ["files", "media-viewer", "markdown-editor", "search"], + "applications": [ { "title": { "en": "Classic Design", @@ -32,4 +28,4 @@ "url": "http://host.docker.internal:8080/index.php/settings/personal" } ] -} \ No newline at end of file +} diff --git a/dev/docker/ocis.web.config.json b/dev/docker/ocis.web.config.json index 61d2e261b6c..4f070366228 100644 --- a/dev/docker/ocis.web.config.json +++ b/dev/docker/ocis.web.config.json @@ -1,39 +1,35 @@ { - "server": "https://host.docker.internal:9200", - "theme": "https://host.docker.internal:9200/themes/owncloud/theme.json", - "version": "0.1.0", - "openIdConnect": { - "metadata_url": "https://host.docker.internal:9200/.well-known/openid-configuration", - "authority": "https://host.docker.internal:9200", - "client_id": "web", - "response_type": "code", - "scope": "openid profile email" + "server": "https://host.docker.internal:9200", + "theme": "https://host.docker.internal:9200/themes/owncloud/theme.json", + "version": "0.1.0", + "openIdConnect": { + "metadata_url": "https://host.docker.internal:9200/.well-known/openid-configuration", + "authority": "https://host.docker.internal:9200", + "client_id": "web", + "response_type": "code", + "scope": "openid profile email" + }, + "options": { + "hideSearchBar": true + }, + "apps": ["files", "media-viewer", "markdown-editor", "search"], + "external_apps": [ + { + "id": "settings", + "path": "https://host.docker.internal:9200/settings.js" }, - "options": { - "hideSearchBar": true + { + "id": "accounts", + "path": "https://host.docker.internal:9200/accounts.js" }, - "apps": [ - "files", - "media-viewer", - "search" - ], - "external_apps": [ - { - "id": "settings", - "path": "https://host.docker.internal:9200/settings.js" - }, - { - "id": "accounts", - "path": "https://host.docker.internal:9200/accounts.js" - }, - { - "id": "draw-io", - "path": "web-app-draw-io", - "config": { - "url": "https://embed.diagrams.net", - "autosave": false, - "theme": "minimal" - } - } - ] -} \ No newline at end of file + { + "id": "draw-io", + "path": "web-app-draw-io", + "config": { + "url": "https://embed.diagrams.net", + "autosave": false, + "theme": "minimal" + } + } + ] +} diff --git a/packages/web-app-files/src/components/AppBar/ViewOptions.vue b/packages/web-app-files/src/components/AppBar/ViewOptions.vue index 1f459c9cd97..c73518597e3 100644 --- a/packages/web-app-files/src/components/AppBar/ViewOptions.vue +++ b/packages/web-app-files/src/components/AppBar/ViewOptions.vue @@ -14,6 +14,7 @@

- {{ highlightedFile.name }} +