From cd06bceb6c95bb6a0f61b3b500ffeef66cefa3c6 Mon Sep 17 00:00:00 2001
From: Jan <j.ackermann91@gmail.com>
Date: Thu, 20 Apr 2023 03:20:41 +0200
Subject: [PATCH 1/9] Show read-only user-attributes as locked

---
 .../src/components/OcSelect/OcSelect.vue      |  1 +
 .../components/Users/SideBar/EditPanel.vue    | 19 +++++++--
 .../web-pkg/src/components/QuotaSelect.vue    | 42 +------------------
 .../src/components/Spaces/QuotaModal.vue      |  2 +-
 .../composables/capability/useCapability.ts   |  6 +++
 5 files changed, 26 insertions(+), 44 deletions(-)

diff --git a/packages/design-system/src/components/OcSelect/OcSelect.vue b/packages/design-system/src/components/OcSelect/OcSelect.vue
index 90363aa3cbb..2fedaba2ce8 100644
--- a/packages/design-system/src/components/OcSelect/OcSelect.vue
+++ b/packages/design-system/src/components/OcSelect/OcSelect.vue
@@ -288,6 +288,7 @@ export default defineComponent({
       )
     },
     messageText() {
+      console.log(this.descriptionMessage)
       if (this.errorMessage) {
         return this.errorMessage
       }
diff --git a/packages/web-app-admin-settings/src/components/Users/SideBar/EditPanel.vue b/packages/web-app-admin-settings/src/components/Users/SideBar/EditPanel.vue
index b49f75cdb25..bc106c3ade4 100644
--- a/packages/web-app-admin-settings/src/components/Users/SideBar/EditPanel.vue
+++ b/packages/web-app-admin-settings/src/components/Users/SideBar/EditPanel.vue
@@ -10,6 +10,7 @@
           :label="$gettext('User name')"
           :error-message="formData.userName.errorMessage"
           :fix-message-line="true"
+          :read-only="isInputFieldReadOnly('user.onPremisesSamAccountName')"
           @update:model-value="validateUserName"
         />
         <oc-text-input
@@ -19,6 +20,7 @@
           :label="$gettext('First and last name')"
           :error-message="formData.displayName.errorMessage"
           :fix-message-line="true"
+          :read-only="isInputFieldReadOnly('user.displayName')"
           @update:model-value="validateDisplayName"
         />
         <oc-text-input
@@ -29,6 +31,7 @@
           :error-message="formData.email.errorMessage"
           type="email"
           :fix-message-line="true"
+          :read-only="isInputFieldReadOnly('user.mail')"
           @change="validateEmail"
         />
         <oc-text-input
@@ -39,6 +42,7 @@
           type="password"
           :fix-message-line="true"
           placeholder="●●●●●●●●"
+          :read-only="isInputFieldReadOnly('user.passwordProfile')"
           @update:model-value="onUpdatePassword"
         />
         <div class="oc-mb-s">
@@ -49,6 +53,7 @@
             option-label="displayName"
             :options="translatedRoleOptions"
             :clearable="false"
+            :read-only="isInputFieldReadOnly('user.appRoleAssignments')"
             @update:model-value="onUpdateRole"
           />
           <div class="oc-text-input-message"></div>
@@ -61,6 +66,7 @@
             :label="$gettext('Login')"
             :options="loginOptions"
             :clearable="false"
+            :read-only="isInputFieldReadOnly('user.accountEnabled')"
             @update:model-value="onUpdateLogin"
           />
 
@@ -71,15 +77,16 @@
           :key="'quota-select-' + user.id"
           :disabled="isQuotaInputDisabled"
           class="oc-mb-s"
-          :title="$gettext('Personal quota')"
+          :label="$gettext('Personal quota')"
           :total-quota="editUser.drive?.quota?.total || 0"
           :max-quota="maxQuota"
           :fix-message-line="true"
           :description-message="
-            isQuotaInputDisabled
+            isQuotaInputDisabled && !isInputFieldReadOnly('drive.quota')
               ? $gettext('To set an individual quota, the user needs to have logged in once.')
               : ''
           "
+          :read-only="isInputFieldReadOnly('drive.quota')"
           @selected-option-change="changeSelectedQuotaOption"
         />
         <group-select
@@ -109,7 +116,7 @@ import GroupSelect from '../GroupSelect.vue'
 import QuotaSelect from 'web-pkg/src/components/QuotaSelect.vue'
 import { cloneDeep } from 'lodash-es'
 import { AppRole, AppRoleAssignment, Group, User } from 'web-client/src/generated'
-import { MaybeRef, useClientService, useStore } from 'web-pkg'
+import { MaybeRef, useCapabilityReadOnlyUserAttributes, useClientService, useStore } from 'web-pkg'
 import { useCapabilitySpacesMaxQuota } from 'web-pkg/src/composables'
 
 export default defineComponent({
@@ -161,11 +168,17 @@ export default defineComponent({
         (g) => !selectedGroups.some((s) => s.id === g.id) && !g.groupTypes?.includes('ReadOnly')
       )
     })
+    const readOnlyUserAttributes = useCapabilityReadOnlyUserAttributes()
 
     const isLoginInputDisabled = computed(() => currentUser.uuid === (props.user as User).id)
 
+    const isInputFieldReadOnly = (key) => {
+      return readOnlyUserAttributes.value.includes(key)
+    }
+
     return {
       maxQuota: useCapabilitySpacesMaxQuota(),
+      isInputFieldReadOnly,
       isLoginInputDisabled,
       editUser,
       formData,
diff --git a/packages/web-pkg/src/components/QuotaSelect.vue b/packages/web-pkg/src/components/QuotaSelect.vue
index c35b10b3874..cb53be59722 100644
--- a/packages/web-pkg/src/components/QuotaSelect.vue
+++ b/packages/web-pkg/src/components/QuotaSelect.vue
@@ -4,21 +4,17 @@
       ref="select"
       :model-value="selectedOption"
       :selectable="optionSelectable"
-      :disabled="disabled"
       taggable
       push-tags
       :clearable="false"
       :options="options"
       :create-option="createOption"
       option-label="displayValue"
-      :label="title"
-      :fix-message-line="fixMessageLine"
-      :error-message="errorMessage"
-      :warning-message="warningMessage"
-      :description-message="descriptionMessage"
+      v-bind="$attrs"
       @update:model-value="onUpdate"
     >
       <template #selected-option="{ displayValue }">
+        <oc-icon v-if="$attrs['read-only']" name="lock" class="oc-mr-xs" size="small" />
         <span v-text="displayValue" />
       </template>
       <template #search="{ attributes, events }">
@@ -52,40 +48,6 @@ export default {
       type: Number,
       default: 0
     },
-    disabled: {
-      type: Boolean,
-      default: false
-    },
-
-    /**
-     * Whether or not vertical space below the input should be reserved for a one line message,
-     * so that content actually appearing there doesn't shift the layout.
-     */
-    fixMessageLine: {
-      type: Boolean,
-      default: false
-    },
-    /**
-     * A warning message which is shown below the select.
-     */
-    warningMessage: {
-      type: String,
-      default: null
-    },
-    /**
-     * An error message which is shown below the select.
-     */
-    errorMessage: {
-      type: String,
-      default: null
-    },
-    /**
-     * A description text which is shown below the select field.
-     */
-    descriptionMessage: {
-      type: String,
-      default: null
-    }
   },
   emits: ['selectedOptionChange'],
   data: function () {
diff --git a/packages/web-pkg/src/components/Spaces/QuotaModal.vue b/packages/web-pkg/src/components/Spaces/QuotaModal.vue
index 7a600c03f8e..45f3906931b 100644
--- a/packages/web-pkg/src/components/Spaces/QuotaModal.vue
+++ b/packages/web-pkg/src/components/Spaces/QuotaModal.vue
@@ -11,7 +11,7 @@
       <template #content>
         <quota-select
           id="quota-select-batch-action-form"
-          :title="$gettext('Quota')"
+          :label="$gettext('Quota')"
           :total-quota="selectedOption"
           :max-quota="maxQuota"
           @selected-option-change="changeSelectedQuotaOption"
diff --git a/packages/web-pkg/src/composables/capability/useCapability.ts b/packages/web-pkg/src/composables/capability/useCapability.ts
index 8b599f0428e..eca24b5e0c4 100644
--- a/packages/web-pkg/src/composables/capability/useCapability.ts
+++ b/packages/web-pkg/src/composables/capability/useCapability.ts
@@ -48,12 +48,18 @@ export const useCapabilityFilesSharingResharingDefault = createCapabilityComposa
 
 export const useCapabilitySpacesEnabled = createCapabilityComposable('spaces.enabled', false)
 export const useCapabilitySpacesMaxQuota = createCapabilityComposable('spaces.max_quota', 0)
+
 export const useCapabilityProjectSpacesEnabled = createCapabilityComposable(
   'spaces.projects',
   false
 )
 export const useCapabilityShareJailEnabled = createCapabilityComposable('spaces.share_jail', false)
 
+export const useCapabilityReadOnlyUserAttributes = createCapabilityComposable(
+  'graph.read_only_user_attributes',
+  []
+)
+
 export const useCapabilityFilesFavorites = createCapabilityComposable('files.favorites', false)
 
 export const useCapabilityFilesTusSupportHttpMethodOverride = createCapabilityComposable<boolean>(

From 6cc1d54ee5bf652f0a0a99e78148839f445ebe11 Mon Sep 17 00:00:00 2001
From: Jan <j.ackermann91@gmail.com>
Date: Thu, 20 Apr 2023 03:21:34 +0200
Subject: [PATCH 2/9] rm console.log

---
 packages/design-system/src/components/OcSelect/OcSelect.vue | 1 -
 1 file changed, 1 deletion(-)

diff --git a/packages/design-system/src/components/OcSelect/OcSelect.vue b/packages/design-system/src/components/OcSelect/OcSelect.vue
index 2fedaba2ce8..90363aa3cbb 100644
--- a/packages/design-system/src/components/OcSelect/OcSelect.vue
+++ b/packages/design-system/src/components/OcSelect/OcSelect.vue
@@ -288,7 +288,6 @@ export default defineComponent({
       )
     },
     messageText() {
-      console.log(this.descriptionMessage)
       if (this.errorMessage) {
         return this.errorMessage
       }

From 6be817db62b95b7121ede53f876fac8e9d891b0a Mon Sep 17 00:00:00 2001
From: Jan <j.ackermann91@gmail.com>
Date: Thu, 20 Apr 2023 03:23:54 +0200
Subject: [PATCH 3/9] clean up

---
 .../src/components/Users/SideBar/EditPanel.vue                | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/packages/web-app-admin-settings/src/components/Users/SideBar/EditPanel.vue b/packages/web-app-admin-settings/src/components/Users/SideBar/EditPanel.vue
index bc106c3ade4..76e16531923 100644
--- a/packages/web-app-admin-settings/src/components/Users/SideBar/EditPanel.vue
+++ b/packages/web-app-admin-settings/src/components/Users/SideBar/EditPanel.vue
@@ -168,10 +168,8 @@ export default defineComponent({
         (g) => !selectedGroups.some((s) => s.id === g.id) && !g.groupTypes?.includes('ReadOnly')
       )
     })
-    const readOnlyUserAttributes = useCapabilityReadOnlyUserAttributes()
-
     const isLoginInputDisabled = computed(() => currentUser.uuid === (props.user as User).id)
-
+    const readOnlyUserAttributes = useCapabilityReadOnlyUserAttributes()
     const isInputFieldReadOnly = (key) => {
       return readOnlyUserAttributes.value.includes(key)
     }

From ef7b2de9f145a4f6f56ee66b21b8f481a68fc551 Mon Sep 17 00:00:00 2001
From: Jan <j.ackermann91@gmail.com>
Date: Thu, 20 Apr 2023 03:40:08 +0200
Subject: [PATCH 4/9] Add unit test

---
 .../Users/SideBar/EditPanel.spec.ts           | 23 ++++++++++++++++++-
 1 file changed, 22 insertions(+), 1 deletion(-)

diff --git a/packages/web-app-admin-settings/tests/unit/components/Users/SideBar/EditPanel.spec.ts b/packages/web-app-admin-settings/tests/unit/components/Users/SideBar/EditPanel.spec.ts
index 7c20fd29518..7d1543ee74a 100644
--- a/packages/web-app-admin-settings/tests/unit/components/Users/SideBar/EditPanel.spec.ts
+++ b/packages/web-app-admin-settings/tests/unit/components/Users/SideBar/EditPanel.spec.ts
@@ -35,6 +35,18 @@ describe('EditPanel', () => {
     expect(groupOptions.length).toBe(1)
     expect(groupOptions[0].id).toEqual(availableGroupOptions[1].id)
   })
+
+  describe('method "isInputFieldReadOnly"', () => {
+    it('should be true if included in capability ReadOnlyUserAttributes list', () => {
+      const { wrapper } = getWrapper({ readOnlyUserAttributes: ['user.displayName'] })
+      expect(wrapper.vm.isInputFieldReadOnly('user.displayName')).toBeTruthy()
+    })
+    it('should be false if not included in capability ReadOnlyUserAttributes list', () => {
+      const { wrapper } = getWrapper()
+      expect(wrapper.vm.isInputFieldReadOnly('user.displayName')).toBeFalsy()
+    })
+  })
+
   describe('method "revertChanges"', () => {
     it('should revert changes on property editUser', () => {
       const { wrapper } = getWrapper()
@@ -159,9 +171,18 @@ describe('EditPanel', () => {
   })
 })
 
-function getWrapper({ selectedGroups = [], groups = availableGroupOptions } = {}) {
+function getWrapper({
+  readOnlyUserAttributes = [],
+  selectedGroups = [],
+  groups = availableGroupOptions
+} = {}) {
   const mocks = defaultComponentMocks()
   const storeOptions = defaultStoreMockOptions
+  storeOptions.getters.capabilities.mockReturnValue({
+    graph: {
+      read_only_user_attributes: readOnlyUserAttributes
+    }
+  })
   const store = createStore(storeOptions)
   return {
     mocks,

From be677f0d91220abc0e87c5caacd2826277da57d0 Mon Sep 17 00:00:00 2001
From: Jan <j.ackermann91@gmail.com>
Date: Thu, 20 Apr 2023 03:42:15 +0200
Subject: [PATCH 5/9] Lint

---
 packages/web-pkg/src/components/QuotaSelect.vue | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/packages/web-pkg/src/components/QuotaSelect.vue b/packages/web-pkg/src/components/QuotaSelect.vue
index cb53be59722..43e41b5ae26 100644
--- a/packages/web-pkg/src/components/QuotaSelect.vue
+++ b/packages/web-pkg/src/components/QuotaSelect.vue
@@ -47,7 +47,7 @@ export default {
     maxQuota: {
       type: Number,
       default: 0
-    },
+    }
   },
   emits: ['selectedOptionChange'],
   data: function () {

From 32546f327131311d294d050b1451ae99b197b0fb Mon Sep 17 00:00:00 2001
From: Jan <j.ackermann91@gmail.com>
Date: Thu, 20 Apr 2023 03:54:09 +0200
Subject: [PATCH 6/9] Rm unused prop

---
 packages/web-pkg/src/components/QuotaSelect.vue | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/packages/web-pkg/src/components/QuotaSelect.vue b/packages/web-pkg/src/components/QuotaSelect.vue
index 43e41b5ae26..36b301fa510 100644
--- a/packages/web-pkg/src/components/QuotaSelect.vue
+++ b/packages/web-pkg/src/components/QuotaSelect.vue
@@ -36,10 +36,6 @@ import { formatFileSize } from 'web-pkg'
 export default {
   name: 'QuotaSelect',
   props: {
-    title: {
-      type: String,
-      required: true
-    },
     totalQuota: {
       type: Number,
       default: 0

From b10abbbc97742da2f271f31cdb6a05bdedd6aaea Mon Sep 17 00:00:00 2001
From: Jan <j.ackermann91@gmail.com>
Date: Thu, 20 Apr 2023 04:04:50 +0200
Subject: [PATCH 7/9] Update snapshots

---
 .../Users/SideBar/__snapshots__/EditPanel.spec.ts.snap          | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/packages/web-app-admin-settings/tests/unit/components/Users/SideBar/__snapshots__/EditPanel.spec.ts.snap b/packages/web-app-admin-settings/tests/unit/components/Users/SideBar/__snapshots__/EditPanel.spec.ts.snap
index 7561cc87043..b0804cc4c86 100644
--- a/packages/web-app-admin-settings/tests/unit/components/Users/SideBar/__snapshots__/EditPanel.spec.ts.snap
+++ b/packages/web-app-admin-settings/tests/unit/components/Users/SideBar/__snapshots__/EditPanel.spec.ts.snap
@@ -17,7 +17,7 @@ exports[`EditPanel renders all available inputs 1`] = `
         <oc-select-stub clearable="false" disabled="false" filter="[Function]" fixmessageline="false" id="login-input" label="Login" loading="false" model-value="[object Object]" multiple="false" optionlabel="label" options="[object Object],[object Object]" readonly="false" searchable="true"></oc-select-stub>
         <div class="oc-text-input-message"></div>
       </div>
-      <quota-select-stub class="oc-mb-s" descriptionmessage="" disabled="false" fixmessageline="true" id="quota-select-form" maxquota="0" title="Personal quota" totalquota="0"></quota-select-stub>
+      <quota-select-stub class="oc-mb-s" description-message="" disabled="false" fix-message-line="true" id="quota-select-form" label="Personal quota" maxquota="0" read-only="false" totalquota="0"></quota-select-stub>
       <group-select-stub class="oc-mb-s" groupoptions="undefined,undefined" selectedgroups=""></group-select-stub>
     </div>
     <compare-save-dialog-stub class="edit-compare-save-dialog oc-mb-l" compareobject="[object Object]" confirmbuttondisabled="false" originalobject="[object Object]"></compare-save-dialog-stub>

From 46d030c5fe0dfeb151012bce08b36b8187b26594 Mon Sep 17 00:00:00 2001
From: Jan <j.ackermann91@gmail.com>
Date: Thu, 20 Apr 2023 04:18:52 +0200
Subject: [PATCH 8/9] Add changelog item

---
 .../enhancement-respect-user-readonly-configuration       | 8 ++++++++
 1 file changed, 8 insertions(+)
 create mode 100644 changelog/unreleased/enhancement-respect-user-readonly-configuration

diff --git a/changelog/unreleased/enhancement-respect-user-readonly-configuration b/changelog/unreleased/enhancement-respect-user-readonly-configuration
new file mode 100644
index 00000000000..f95fc5e769d
--- /dev/null
+++ b/changelog/unreleased/enhancement-respect-user-readonly-configuration
@@ -0,0 +1,8 @@
+Enhancement: Respect user read-only configuration by the server
+
+The user edit dialog in the user management will respect the server's FRONTEND_READONLY_USER_ATTRIBUTES configuration,
+recent fields will be disabled and will have a lock icon to visualize, that those fields are read-only.
+
+https://github.com/owncloud/web/pull/8868
+https://github.com/owncloud/web/issues/8840
+

From d7b1d962bc50bf86e0f71dcbb4d1950382e9c306 Mon Sep 17 00:00:00 2001
From: Jan <jackermann@owncloud.com>
Date: Thu, 20 Apr 2023 09:30:42 +0200
Subject: [PATCH 9/9] Update
 packages/web-app-admin-settings/src/components/Users/SideBar/EditPanel.vue

Co-authored-by: Jannik Stehle <50302941+JammingBen@users.noreply.github.com>
---
 .../src/components/Users/SideBar/EditPanel.vue                  | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/packages/web-app-admin-settings/src/components/Users/SideBar/EditPanel.vue b/packages/web-app-admin-settings/src/components/Users/SideBar/EditPanel.vue
index 76e16531923..519745ae525 100644
--- a/packages/web-app-admin-settings/src/components/Users/SideBar/EditPanel.vue
+++ b/packages/web-app-admin-settings/src/components/Users/SideBar/EditPanel.vue
@@ -171,7 +171,7 @@ export default defineComponent({
     const isLoginInputDisabled = computed(() => currentUser.uuid === (props.user as User).id)
     const readOnlyUserAttributes = useCapabilityReadOnlyUserAttributes()
     const isInputFieldReadOnly = (key) => {
-      return readOnlyUserAttributes.value.includes(key)
+      return unref(readOnlyUserAttributes).includes(key)
     }
 
     return {