-
-
Notifications
You must be signed in to change notification settings - Fork 509
/
Copy pathrules.rs
507 lines (444 loc) · 18.1 KB
/
rules.rs
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
use std::{borrow::Cow, fmt};
use rustc_hash::{FxHashMap, FxHashSet};
use schemars::{gen::SchemaGenerator, schema::Schema, JsonSchema};
use serde::{
de::{self, Deserializer, Visitor},
ser::SerializeMap,
Deserialize, Serialize,
};
use oxc_diagnostics::{Error, OxcDiagnostic};
use crate::{
rules::{RuleEnum, RULES},
utils::{is_eslint_rule_adapted_to_typescript, is_jest_rule_adapted_to_vitest},
AllowWarnDeny, RuleWithSeverity,
};
type RuleSet = FxHashSet<RuleWithSeverity>;
// TS type is `Record<string, RuleConf>`
// - type SeverityConf = 0 | 1 | 2 | "off" | "warn" | "error";
// - type RuleConf = SeverityConf | [SeverityConf, ...any[]];
// <https://github.com/eslint/eslint/blob/ce838adc3b673e52a151f36da0eedf5876977514/lib/shared/types.js#L12>
// Note: when update document comment, also update `DummyRuleMap`'s description in this file.
#[derive(Debug, Clone, Default)]
#[cfg_attr(test, derive(PartialEq))]
pub struct OxlintRules {
/// List of all configured rules
pub(crate) rules: Vec<ESLintRule>,
}
impl OxlintRules {
pub fn new(rules: Vec<ESLintRule>) -> Self {
Self { rules }
}
/// Returns `true` if there are no rules.
pub fn is_empty(&self) -> bool {
self.rules.is_empty()
}
}
/// A fully qualified rule name, e.g. `eslint/no-console` or `react/rule-of-hooks`.
/// Includes the plugin name, the rule name, and the configuration for the rule (if any).
/// This does not imply the rule is known to the linter as that, only that it is configured.
#[derive(Debug, Clone)]
#[cfg_attr(test, derive(PartialEq))]
pub struct ESLintRule {
/// Name of the plugin: `eslint`, `react`, etc.
pub plugin_name: String,
/// Name of the rule: `no-console`, `prefer-const`, etc.
pub rule_name: String,
/// Severity of the rule: `off`, `warn`, `error`, etc.
pub severity: AllowWarnDeny,
/// JSON configuration for the rule, if any.
pub config: Option<serde_json::Value>,
}
impl OxlintRules {
#[allow(clippy::option_if_let_else, clippy::print_stderr)]
pub(crate) fn override_rules(&self, rules_for_override: &mut RuleSet, all_rules: &[RuleEnum]) {
use itertools::Itertools;
let mut rules_to_replace: Vec<RuleWithSeverity> = vec![];
let mut rules_to_remove: Vec<RuleWithSeverity> = vec![];
// Rules can have the same name but different plugin names
let lookup = self.rules.iter().into_group_map_by(|r| r.rule_name.as_str());
for (name, rule_configs) in &lookup {
match rule_configs.len() {
0 => unreachable!(),
1 => {
let rule_config = &rule_configs[0];
let (rule_name, plugin_name) = transform_rule_and_plugin_name(
&rule_config.rule_name,
&rule_config.plugin_name,
);
let severity = rule_config.severity;
match severity {
AllowWarnDeny::Warn | AllowWarnDeny::Deny => {
if let Some(rule) = all_rules
.iter()
.find(|r| r.name() == rule_name && r.plugin_name() == plugin_name)
{
let config = rule_config.config.clone().unwrap_or_default();
let rule = rule.read_json(config);
rules_to_replace.push(RuleWithSeverity::new(rule, severity));
}
}
AllowWarnDeny::Allow => {
if let Some(rule) = rules_for_override
.iter()
.find(|r| r.name() == rule_name && r.plugin_name() == plugin_name)
{
let rule = rule.clone();
rules_to_remove.push(rule);
}
// If the given rule is not found in the rule list (for example, if all rules are disabled),
// then look it up in the entire rules list and add it.
else if let Some(rule) = all_rules
.iter()
.find(|r| r.name() == rule_name && r.plugin_name() == plugin_name)
{
let config = rule_config.config.clone().unwrap_or_default();
let rule = rule.read_json(config);
rules_to_remove.push(RuleWithSeverity::new(rule, severity));
}
}
}
}
_ => {
let rules = rules_for_override
.iter()
.filter_map(|r| {
if r.name() == *name {
Some((r.plugin_name(), r))
} else {
None
}
})
.collect::<FxHashMap<_, _>>();
for rule_config in rule_configs {
let (rule_name, plugin_name) = transform_rule_and_plugin_name(
&rule_config.rule_name,
&rule_config.plugin_name,
);
if rule_config.severity.is_warn_deny() {
let config = rule_config.config.clone().unwrap_or_default();
if let Some(rule) = rules.get(&plugin_name) {
rules_to_replace.push(RuleWithSeverity::new(
rule.read_json(config),
rule.severity,
));
}
// If the given rule is not found in the rule list (for example, if all rules are disabled),
// then look it up in the entire rules list and add it.
else if let Some(rule) = all_rules
.iter()
.find(|r| r.name() == rule_name && r.plugin_name() == plugin_name)
{
rules_to_replace.push(RuleWithSeverity::new(
rule.read_json(config),
rule_config.severity,
));
}
} else if let Some(&rule) = rules.get(&plugin_name) {
rules_to_remove.push(rule.clone());
}
}
}
}
}
for rule in rules_to_remove {
rules_for_override.remove(&rule);
}
for rule in rules_to_replace {
rules_for_override.replace(rule);
}
}
}
fn transform_rule_and_plugin_name<'a>(
rule_name: &'a str,
plugin_name: &'a str,
) -> (&'a str, &'a str) {
let plugin_name = match plugin_name {
"vitest" if is_jest_rule_adapted_to_vitest(rule_name) => "jest",
"unicorn" if rule_name == "no-negated-condition" => "eslint",
"typescript" if is_eslint_rule_adapted_to_typescript(rule_name) => "eslint",
_ => plugin_name,
};
(rule_name, plugin_name)
}
impl JsonSchema for OxlintRules {
fn schema_name() -> String {
"OxlintRules".to_owned()
}
fn schema_id() -> Cow<'static, str> {
Cow::Borrowed("OxlintRules")
}
fn json_schema(gen: &mut SchemaGenerator) -> Schema {
#[allow(unused)]
#[derive(Debug, Clone, JsonSchema)]
#[serde(untagged)]
enum DummyRule {
Toggle(AllowWarnDeny),
ToggleAndConfig(Vec<serde_json::Value>),
}
#[allow(unused)]
#[derive(Debug, JsonSchema)]
#[schemars(
description = "See [Oxlint Rules](https://oxc.rs/docs/guide/usage/linter/rules.html)"
)]
struct DummyRuleMap(pub FxHashMap<String, DummyRule>);
gen.subschema_for::<DummyRuleMap>()
}
}
impl Serialize for OxlintRules {
fn serialize<S>(&self, s: S) -> Result<S::Ok, S::Error>
where
S: serde::Serializer,
{
let mut rules = s.serialize_map(Some(self.rules.len()))?;
for rule in &self.rules {
let key = rule.full_name();
match rule.config.as_ref() {
// e.g. unicorn/some-rule: ["warn", { foo: "bar" }]
Some(config) if !config.is_null() => {
let value = (rule.severity.as_str(), config);
rules.serialize_entry(&key, &value)?;
}
// e.g. unicorn/some-rule: "warn"
_ => {
rules.serialize_entry(&key, rule.severity.as_str())?;
}
}
}
rules.end()
}
}
// Manually implement Deserialize because the type is a bit complex...
// - Handle single value form and array form
// - SeverityConf into AllowWarnDeny
// - Align plugin names
impl<'de> Deserialize<'de> for OxlintRules {
fn deserialize<D>(deserializer: D) -> Result<Self, D::Error>
where
D: Deserializer<'de>,
{
struct OxlintRulesVisitor;
impl<'de> Visitor<'de> for OxlintRulesVisitor {
type Value = OxlintRules;
fn expecting(&self, formatter: &mut fmt::Formatter) -> fmt::Result {
formatter.write_str("Record<string, SeverityConf | [SeverityConf, ...any[]]>")
}
fn visit_map<M>(self, mut map: M) -> Result<Self::Value, M::Error>
where
M: de::MapAccess<'de>,
{
let mut rules = vec![];
while let Some((key, value)) = map.next_entry::<String, serde_json::Value>()? {
let (plugin_name, rule_name) = parse_rule_key(&key);
let (severity, config) = parse_rule_value(&value).map_err(de::Error::custom)?;
rules.push(ESLintRule { plugin_name, rule_name, severity, config });
}
Ok(OxlintRules { rules })
}
}
deserializer.deserialize_any(OxlintRulesVisitor)
}
}
fn parse_rule_key(name: &str) -> (String, String) {
let Some((plugin_name, rule_name)) = name.split_once('/') else {
return (
RULES
.iter()
.find(|r| r.name() == name)
.map_or("unknown_plugin", RuleEnum::plugin_name)
.to_string(),
name.to_string(),
);
};
let (oxlint_plugin_name, rule_name) = match plugin_name {
"@typescript-eslint" => ("typescript", rule_name),
"jsx-a11y" => ("jsx_a11y", rule_name),
"react-perf" => ("react_perf", rule_name),
// e.g. "@next/next/google-font-display"
"@next" => ("nextjs", rule_name.trim_start_matches("next/")),
// For backwards compatibility, react hook rules reside in the react plugin.
"react-hooks" => ("react", rule_name),
// For backwards compatibility, deepscan rules reside in the oxc plugin.
"deepscan" => ("oxc", rule_name),
_ => (plugin_name, rule_name),
};
(oxlint_plugin_name.to_string(), rule_name.to_string())
}
fn parse_rule_value(
value: &serde_json::Value,
) -> Result<(AllowWarnDeny, Option<serde_json::Value>), Error> {
match value {
serde_json::Value::String(_) | serde_json::Value::Number(_) => {
let severity = AllowWarnDeny::try_from(value)?;
Ok((severity, None))
}
serde_json::Value::Array(v) => {
if v.is_empty() {
return Err(failed_to_parse_rule_value(
&value.to_string(),
"Type should be `[SeverityConf, ...any[]`",
)
.into());
}
// The first item should be SeverityConf
let severity = AllowWarnDeny::try_from(v.first().unwrap())?;
// e.g. ["warn"], [0]
let config = if v.len() == 1 {
None
// e.g. ["error", "args", { type: "whatever" }, ["len", "also"]]
} else {
Some(serde_json::Value::Array(v.iter().skip(1).cloned().collect::<Vec<_>>()))
};
Ok((severity, config))
}
_ => Err(failed_to_parse_rule_value(
&value.to_string(),
"Type should be `SeverityConf | [SeverityConf, ...any[]]`",
)
.into()),
}
}
fn failed_to_parse_rule_value(value: &str, err: &str) -> OxcDiagnostic {
OxcDiagnostic::error(format!("Failed to rule value {value:?} with error {err:?}"))
}
impl ESLintRule {
/// Returns `<plugin_name>/<rule_name>` for non-eslint rules. For eslint rules, returns
/// `<rule_name>`.
// This is effectively the inverse operation for `parse_rule_key`.
pub fn full_name(&self) -> Cow<'_, str> {
if self.plugin_name == "eslint" {
Cow::Borrowed(self.rule_name.as_str())
} else {
Cow::Owned(format!("{}/{}", self.plugin_name, self.rule_name))
}
}
}
#[cfg(test)]
#[allow(clippy::default_trait_access)]
mod test {
use serde::Deserialize;
use serde_json::{json, Value};
use crate::{
rules::{RuleEnum, RULES},
AllowWarnDeny, RuleWithSeverity,
};
use super::{OxlintRules, RuleSet};
#[test]
fn test_parse_rules() {
let rules = OxlintRules::deserialize(&json!({
"no-console": "off",
"foo/no-unused-vars": [1],
"dummy": ["error", "arg1", "args2"],
"@next/next/noop": 2,
}))
.unwrap();
let mut rules = rules.rules.iter();
let r1 = rules.next().unwrap();
assert_eq!(r1.rule_name, "no-console");
assert_eq!(r1.plugin_name, "eslint");
assert!(r1.severity.is_allow());
assert!(r1.config.is_none());
let r2 = rules.next().unwrap();
assert_eq!(r2.rule_name, "no-unused-vars");
assert_eq!(r2.plugin_name, "foo");
assert!(r2.severity.is_warn_deny());
assert!(r2.config.is_none());
let r3 = rules.next().unwrap();
assert_eq!(r3.rule_name, "dummy");
assert_eq!(r3.plugin_name, "unknown_plugin");
assert!(r3.severity.is_warn_deny());
assert_eq!(r3.config, Some(serde_json::json!(["arg1", "args2"])));
let r4 = rules.next().unwrap();
assert_eq!(r4.rule_name, "noop");
assert_eq!(r4.plugin_name, "nextjs");
assert!(r4.severity.is_warn_deny());
assert!(r4.config.is_none());
}
#[test]
fn test_parse_rules_default() {
let rules = OxlintRules::default();
assert!(rules.is_empty());
}
fn r#override(rules: &mut RuleSet, rules_rc: &Value) {
let rules_config = OxlintRules::deserialize(rules_rc).unwrap();
rules_config.override_rules(rules, &RULES);
}
#[test]
fn test_override_empty() {
let mut rules = RuleSet::default();
let configs = [json!({ "no-console": "error" }), json!({ "eslint/no-console": "error" })];
for config in configs {
rules.clear();
r#override(&mut rules, &config);
assert_eq!(rules.len(), 1, "{config:?}");
let rule = rules.iter().next().unwrap();
assert_eq!(rule.name(), "no-console", "{config:?}");
assert_eq!(rule.severity, AllowWarnDeny::Deny, "{config:?}");
}
}
// FIXME
#[test]
#[should_panic(
expected = "eslint rules should be configurable by their typescript-eslint reimplementations:"
)]
fn test_override_empty_fixme() {
let config = json!({ "@typescript-eslint/no-console": "error" });
let mut rules = RuleSet::default();
rules.clear();
r#override(&mut rules, &config);
assert_eq!(
rules.len(),
1,
"eslint rules should be configurable by their typescript-eslint reimplementations: {config:?}"
);
let rule = rules.iter().next().unwrap();
assert_eq!(
rule.name(),
"no-console",
"eslint rules should be configurable by their typescript-eslint reimplementations: {config:?}"
);
assert_eq!(
rule.severity,
AllowWarnDeny::Deny,
"eslint rules should be configurable by their typescript-eslint reimplementations: {config:?}"
);
}
#[test]
fn test_override_allow() {
let mut rules = RuleSet::default();
rules.insert(RuleWithSeverity {
rule: RuleEnum::EslintNoConsole(Default::default()),
severity: AllowWarnDeny::Deny,
});
r#override(&mut rules, &json!({ "eslint/no-console": "off" }));
assert!(rules.is_empty());
}
#[test]
fn test_override_plugin_prefix_duplicates() {
let configs = [
// FIXME: this should be valid
// json!({ "@typescript-eslint/no-unused-vars": "error" }),
json!({ "no-unused-vars": "off", "typescript/no-unused-vars": "error" }),
json!({ "no-unused-vars": "off", "@typescript-eslint/no-unused-vars": "error" }),
];
for config in &configs {
let mut rules = RuleSet::default();
r#override(&mut rules, config);
assert_eq!(rules.len(), 1, "{config:?}");
let rule = rules.iter().next().unwrap();
assert_eq!(rule.name(), "no-unused-vars", "{config:?}");
assert_eq!(rule.severity, AllowWarnDeny::Deny, "{config:?}");
}
for config in &configs {
let mut rules = RuleSet::default();
rules.insert(RuleWithSeverity {
rule: RuleEnum::EslintNoUnusedVars(Default::default()),
severity: AllowWarnDeny::Warn,
});
r#override(&mut rules, config);
assert_eq!(rules.len(), 1, "{config:?}");
let rule = rules.iter().next().unwrap();
assert_eq!(rule.name(), "no-unused-vars", "{config:?}");
assert_eq!(rule.severity, AllowWarnDeny::Warn, "{config:?}");
}
}
}