From 36e4a2875c89d5d396a28ecf0442d1a04cabe5a6 Mon Sep 17 00:00:00 2001
From: DonIsaac <22823424+DonIsaac@users.noreply.github.com>
Date: Sat, 24 Aug 2024 04:49:30 +0000
Subject: [PATCH] fix(linter/no-unused-vars): panic in variable declarator
 usage checks (#5160)

Part of #5129
---
 .../src/rules/eslint/no_unused_vars/usage.rs         | 12 +++---------
 1 file changed, 3 insertions(+), 9 deletions(-)

diff --git a/crates/oxc_linter/src/rules/eslint/no_unused_vars/usage.rs b/crates/oxc_linter/src/rules/eslint/no_unused_vars/usage.rs
index e160ccec73419..da47a11b86a66 100644
--- a/crates/oxc_linter/src/rules/eslint/no_unused_vars/usage.rs
+++ b/crates/oxc_linter/src/rules/eslint/no_unused_vars/usage.rs
@@ -333,12 +333,9 @@ impl<'s, 'a> Symbol<'s, 'a> {
             match node.kind() {
                 // references used in declaration of another variable are definitely
                 // used by others
-                AstKind::VariableDeclarator(v) => {
-                    // let a = a; is a static semantic error, even if `a` is shadowed.
-                    debug_assert!(
-                        v.id.kind.get_identifier().map_or_else(|| true, |id| id != name),
-                        "While traversing {name}'s reference's parent nodes, found {name}'s declaration. This algorithm assumes that variable declarations do not appear in references."
-                    );
+                AstKind::VariableDeclarator(_)
+                | AstKind::JSXExpressionContainer(_)
+                | AstKind::Argument(_) => {
                     // definitely used, short-circuit
                     return false;
                 }
@@ -382,9 +379,6 @@ impl<'s, 'a> Symbol<'s, 'a> {
                 | AstKind::WhileStatement(_) => {
                     break;
                 }
-                AstKind::JSXExpressionContainer(_) | AstKind::Argument(_) => {
-                    return false;
-                }
                 // this is needed to handle `return () => foo++`
                 AstKind::ExpressionStatement(_) => {
                     if self.is_in_return_statement(node.id()) {